Hi, can a developer running PHP 5.2 try to reproduce this bug [0] ?
[0] https://sourceforge.net/p/phpmyadmin/bugs/3783/
2013/1/25 Marc Delisle marc@infomarc.info:
Hi, can a developer running PHP 5.2 try to reproduce this bug [0] ?
I'm running 5.3.*, so I cannot test it, but of what I've read about changes in PHP 5.3 and what I know of classes and static methods, the way it is implemented and used in transformations and DisplayResults.class.php is a bit of a mess.
A mix of strings, methods, methodnames and class instances is assigned to $transformation_plugin, so you can never be sure if it is an class instance or something else. Replacing the :: with -> should do the trick, because there is already a check if $transformation_plugin is an instanciated class (type = object)
I've fixed the changes in commits d53f984a71 and 688642560d
Le 2013-01-25 18:21, Dieter Adriaenssens a écrit :
2013/1/25 Marc Delisle marc@infomarc.info:
Hi, can a developer running PHP 5.2 try to reproduce this bug [0] ?
I'm running 5.3.*, so I cannot test it, but of what I've read about changes in PHP 5.3 and what I know of classes and static methods, the way it is implemented and used in transformations and DisplayResults.class.php is a bit of a mess.
A mix of strings, methods, methodnames and class instances is assigned to $transformation_plugin, so you can never be sure if it is an class instance or something else. Replacing the :: with -> should do the trick, because there is already a check if $transformation_plugin is an instanciated class (type = object)
I've fixed the changes in commits d53f984a71 and 688642560d
I finally installed PHP 5.2 and am testing. I committed an additional fix, see the bug ticket.
After testing, I plan to release 4.0.0-alpha2.
-
Dieter Adriaenssens -
Marc Delisle