Hi Marc, Now that my exams are finished :), I have started to look at the script "tbl_select.php" for planning the refactoring. As the script is used for searching a table using a form in the UI, it contains two sections:- 1. If block that "displays the selection form". 2. else to do the search work.
Looking at the search form display part, it is done using raw HTML-PHP mix with calls to functions from some library files, so first main concern should be to handle the HTML-PHP mix and convert the code into functions. About that I saw the wiki page for Roadmap to 4.0 [0] :- "The current <html> and <?php> mix will be cleaned up in the process. The <html> output will be moved to lib/include files which can be called by either the index page or by the specific files (which can still be referenced separately)."
So, to move HTML to lib/include files, slicing proper reusable HTML blocks from the script should be done, followed by moving it to a lib/include file, and then calling the include file at proper places. Is this the way, I should proceed ?
[0] http://wiki.phpmyadmin.net/pma/FOSDEM_2012_Meeting
Regards
Le 2012-05-08 02:44, Atul Pratap Singh a écrit : (...)
So, to move HTML to lib/include files, slicing proper reusable HTML blocks from the script should be done, followed by moving it to a lib/include file, and then calling the include file at proper places. Is this the way, I should proceed ?
Hi Atul, it depends: do you plan to create a class for this, or use global functions?
For an example using a class, look at libraries/Menu.class.php. The _getBreadcrumbs() function returns some HTML and is called afterwards with an "echo".
You should have just one library file that will contain all your refactored functions for tbl_select.php.
On Tue, May 8, 2012 at 3:24 PM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-08 02:44, Atul Pratap Singh a écrit : (...)
So, to move HTML to lib/include files, slicing proper reusable HTML
blocks
from the script should be done, followed by moving it to a lib/include file, and then calling the include file at proper places. Is this the
way,
I should proceed ?
Hi Atul, it depends: do you plan to create a class for this, or use global functions?
For an example using a class, look at libraries/Menu.class.php. The
_getBreadcrumbs() function returns some HTML and is called afterwards with an "echo".
You should have just one library file that will contain all your refactored functions for tbl_select.php.
Marc, yes I would like to form a class. As there is already a library for
"tbl_select.php" i.e. "tbl_select.lib.php" and it contains some functions, Should I refactor it and convert it into a class file for "tbl_select.php" and "tbl_zoom_select.php" ?
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2012-05-08 16:18, Atul Pratap Singh a écrit :
On Tue, May 8, 2012 at 3:24 PM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-08 02:44, Atul Pratap Singh a écrit : (...)
So, to move HTML to lib/include files, slicing proper reusable HTML
blocks
from the script should be done, followed by moving it to a lib/include file, and then calling the include file at proper places. Is this the
way,
I should proceed ?
Hi Atul, it depends: do you plan to create a class for this, or use global functions?
For an example using a class, look at libraries/Menu.class.php. The
_getBreadcrumbs() function returns some HTML and is called afterwards with an "echo".
You should have just one library file that will contain all your refactored functions for tbl_select.php.
Marc, yes I would like to form a class. As there is already a library for
"tbl_select.php" i.e. "tbl_select.lib.php" and it contains some functions, Should I refactor it and convert it into a class file for "tbl_select.php" and "tbl_zoom_select.php" ?
Yes, good idea.
On Wed, May 9, 2012 at 1:57 AM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-08 16:18, Atul Pratap Singh a écrit :
On Tue, May 8, 2012 at 3:24 PM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-08 02:44, Atul Pratap Singh a écrit : (...)
So, to move HTML to lib/include files, slicing proper reusable HTML
blocks
from the script should be done, followed by moving it to a lib/include file, and then calling the include file at proper places. Is this the
way,
I should proceed ?
Hi Atul, it depends: do you plan to create a class for this, or use global functions?
For an example using a class, look at libraries/Menu.class.php. The
_getBreadcrumbs() function returns some HTML and is called afterwards with an "echo".
You should have just one library file that will contain all your refactored functions for tbl_select.php.
Marc, yes I would like to form a class. As there is already a library
for
"tbl_select.php" i.e. "tbl_select.lib.php" and it contains some
functions,
Should I refactor it and convert it into a class file for
"tbl_select.php"
and "tbl_zoom_select.php" ?
Yes, good idea.
Thanks Marc, will show you a few commits in a day or two :).
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Wed, May 9, 2012 at 2:28 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Wed, May 9, 2012 at 1:57 AM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-08 16:18, Atul Pratap Singh a écrit :
On Tue, May 8, 2012 at 3:24 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2012-05-08 02:44, Atul Pratap Singh a écrit : (...)
So, to move HTML to lib/include files, slicing proper reusable HTML
blocks
from the script should be done, followed by moving it to a lib/include file, and then calling the include file at proper places. Is this the
way,
I should proceed ?
Hi Atul, it depends: do you plan to create a class for this, or use global functions?
For an example using a class, look at libraries/Menu.class.php. The
_getBreadcrumbs() function returns some HTML and is called afterwards with an "echo".
You should have just one library file that will contain all your refactored functions for tbl_select.php.
Marc, yes I would like to form a class. As there is already a library
for
"tbl_select.php" i.e. "tbl_select.lib.php" and it contains some
functions,
Should I refactor it and convert it into a class file for
"tbl_select.php"
and "tbl_zoom_select.php" ?
Yes, good idea.
Thanks Marc, will show you a few commits in a day or two :).
Hi Marc, Sorry for the delay. I have done some refactoring in tbl_select.php. Part of the script responsible for displaying table search form(which was earlier done using HTML-PHP mix) has now been converted into functions displaying HTML. Please checkout [0].
[0] https://github.com/zixtor/phpmyadmin/commit/36d56fb2ea56e47b3979cfb07ff3ad5a...
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.
Le 2012-05-15 09:42, Atul Pratap Singh a écrit :
On Wed, May 9, 2012 at 2:28 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Wed, May 9, 2012 at 1:57 AM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-08 16:18, Atul Pratap Singh a écrit :
On Tue, May 8, 2012 at 3:24 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2012-05-08 02:44, Atul Pratap Singh a écrit : (...)
So, to move HTML to lib/include files, slicing proper reusable HTML
blocks
from the script should be done, followed by moving it to a lib/include file, and then calling the include file at proper places. Is this the
way,
I should proceed ?
Hi Atul, it depends: do you plan to create a class for this, or use global functions?
For an example using a class, look at libraries/Menu.class.php. The
_getBreadcrumbs() function returns some HTML and is called afterwards with an "echo".
You should have just one library file that will contain all your refactored functions for tbl_select.php.
Marc, yes I would like to form a class. As there is already a library
for
"tbl_select.php" i.e. "tbl_select.lib.php" and it contains some
functions,
Should I refactor it and convert it into a class file for
"tbl_select.php"
and "tbl_zoom_select.php" ?
Yes, good idea.
Thanks Marc, will show you a few commits in a day or two :).
Hi Marc, Sorry for the delay. I have done some refactoring in tbl_select.php. Part of the script responsible for displaying table search form(which was earlier done using HTML-PHP mix) has now been converted into functions displaying HTML. Please checkout [0].
[0] https://github.com/zixtor/phpmyadmin/commit/36d56fb2ea56e47b3979cfb07ff3ad5a...
Thanks Atul, I started to have a look and added my comments directly to github.
On Tue, May 15, 2012 at 10:37 PM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-15 09:42, Atul Pratap Singh a écrit :
On Wed, May 9, 2012 at 2:28 AM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Wed, May 9, 2012 at 1:57 AM, Marc Delisle marc@infomarc.info
wrote:
Le 2012-05-08 16:18, Atul Pratap Singh a écrit :
On Tue, May 8, 2012 at 3:24 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2012-05-08 02:44, Atul Pratap Singh a écrit : (...) > > So, to move HTML to lib/include files, slicing proper reusable HTML blocks > from the script should be done, followed by moving it to a
lib/include
> file, and then calling the include file at proper places. Is this
the
way, > I should proceed ? >
Hi Atul, it depends: do you plan to create a class for this, or use global functions?
For an example using a class, look at libraries/Menu.class.php. The
_getBreadcrumbs() function returns some HTML and is called afterwards with an "echo".
You should have just one library file that will contain all your refactored functions for tbl_select.php.
Marc, yes I would like to form a class. As there is already a library
for
"tbl_select.php" i.e. "tbl_select.lib.php" and it contains some
functions,
Should I refactor it and convert it into a class file for
"tbl_select.php"
and "tbl_zoom_select.php" ?
Yes, good idea.
Thanks Marc, will show you a few commits in a day or two :).
Hi Marc, Sorry for the delay. I have done some refactoring in tbl_select.php. Part of the script responsible for displaying table search form(which was earlier done using HTML-PHP mix) has now been converted into functions displaying HTML. Please checkout [0].
[0]
https://github.com/zixtor/phpmyadmin/commit/36d56fb2ea56e47b3979cfb07ff3ad5a...
Thanks Atul, I started to have a look and added my comments directly to github.
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Marc, I have now converted the SQL query execution part of tbl_select.php into functions. Please checkout [0]
[0] https://github.com/zixtor/phpmyadmin/commit/360e2063ea271030d3042e3d0d2b6b5b...
Le 2012-05-21 10:31, Atul Pratap Singh a écrit :
Hi Marc, I have now converted the SQL query execution part of tbl_select.php into functions. Please checkout [0]
[0] https://github.com/zixtor/phpmyadmin/commit/360e2063ea271030d3042e3d0d2b6b5b...
Hi Atul, OK, I'll check this today.
By the way, I am working on tbl_zoom_select.php and some js files to replace Highcharts with jqplot, I expect to finish soon and merge to QA_3_5, then master.
On Mon, May 21, 2012 at 8:30 PM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-21 10:31, Atul Pratap Singh a écrit :
Hi Marc, I have now converted the SQL query execution part of tbl_select.php into functions. Please checkout [0]
[0]
https://github.com/zixtor/phpmyadmin/commit/360e2063ea271030d3042e3d0d2b6b5b...
Hi Atul, OK, I'll check this today.
By the way, I am working on tbl_zoom_select.php and some js files to replace Highcharts with jqplot, I expect to finish soon and merge to QA_3_5, then master.
Ok Marc, Next I would move the functions formed in "tbl_select.php" to
"libraries/tbl_select.lib.php" followed by the refactoring in "tbl_zoom_select.php" (After you merge the jqplot changes in master).
-- Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2012-05-21 11:22, Atul Pratap Singh a écrit :
On Mon, May 21, 2012 at 8:30 PM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-21 10:31, Atul Pratap Singh a écrit :
Hi Marc, I have now converted the SQL query execution part of tbl_select.php into functions. Please checkout [0]
[0]
https://github.com/zixtor/phpmyadmin/commit/360e2063ea271030d3042e3d0d2b6b5b...
Hi Atul, OK, I'll check this today.
By the way, I am working on tbl_zoom_select.php and some js files to replace Highcharts with jqplot, I expect to finish soon and merge to QA_3_5, then master.
Ok Marc, Next I would move the functions formed in "tbl_select.php" to
"libraries/tbl_select.lib.php" followed by the refactoring in "tbl_zoom_select.php" (After you merge the jqplot changes in master).
Hi Atul, upstream master now contains tbl_zoom_select.php with the jqplot changes.
On Fri, May 25, 2012 at 2:37 AM, Marc Delisle marc@infomarc.info wrote:
Le 2012-05-21 11:22, Atul Pratap Singh a écrit :
On Mon, May 21, 2012 at 8:30 PM, Marc Delisle marc@infomarc.info
wrote:
Le 2012-05-21 10:31, Atul Pratap Singh a écrit :
Hi Marc, I have now converted the SQL query execution part of tbl_select.php
into
functions. Please checkout [0]
[0]
https://github.com/zixtor/phpmyadmin/commit/360e2063ea271030d3042e3d0d2b6b5b...
Hi Atul, OK, I'll check this today.
By the way, I am working on tbl_zoom_select.php and some js files to replace Highcharts with jqplot, I expect to finish soon and merge to QA_3_5, then master.
Ok Marc, Next I would move the functions formed in "tbl_select.php" to
"libraries/tbl_select.lib.php" followed by the refactoring in "tbl_zoom_select.php" (After you merge the jqplot changes in master).
Hi Atul, upstream master now contains tbl_zoom_select.php with the jqplot changes.
Thanks Marc, I'll now start refactoring in 'tbl_zoom_select.php'.
--
Marc Delisle http://infomarc.info
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-
Atul Pratap Singh -
Marc Delisle