[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Structure ->Index->Edit
Hi Marc,
I started working with ajaxify the Index->Edit option in Table->Structure. I added the following two action for tbl_structure.js file to handle the ajax.
1. $("#table_index tbody tr td.edit_index.ajax").live('click') - Correctly loads the "*index_frm*" to a dialog box 2. $("#index_frm.ajax input[name=do_save_data]").live('click') - which try to save the action.
But when I try to change the "*Index type*" it shows an js error in firebug. Then I checked it with non ajax event of index edit. In that case also it gives an error. It seems there is an error in the previously development which does not match the name of the option elements. Should I correct that or just consider on ajax event only.
Regards, Thilanka.
Hi Marc,
I worked with the ajax event in Index->Edit option but not with the issue previously mentioned by mail. I pushed my changes to the repo. Please check that. Thank you.
Regards, Thilanka.
Le 2011-07-01 14:25, Thilanka Kaushalya a écrit :
Hi Marc,
I worked with the ajax event in Index->Edit option but not with the issue previously mentioned by mail. I pushed my changes to the repo. Please check that. Thank you.
Regards, Thilanka.
Thilanka, this works fine. I could merge this but your code is becoming more difficult to merge.
This is because I can't merge your latest commit, due to the presence of the unfinished "Ajaxify Table-> Browse->Multiple rows->Export" in your tree.
So I would have to cherry-pick just some commits but this is error-prone.
Hi Marc,
this works fine. I could merge this but your code is becoming more
difficult to merge.
This is because I can't merge your latest commit, due to the presence of the unfinished "Ajaxify Table-> Browse->Multiple rows->Export" in your tree.
So I would have to cherry-pick just some commits but this is error-prone.
I'll try to finish the export option in tomorrow and so we can merge three changes together.
Regards, Thilanka.
Hi Marc,
Thilanka,
this works fine. I could merge this but your code is becoming more difficult to merge.
This is because I can't merge your latest commit, due to the presence of the unfinished "Ajaxify Table-> Browse->Multiple rows->Export" in your tree.
So I would have to cherry-pick just some commits but this is error-prone.
I think now we can merge this change since I removed the changes for
multi_row->export.
Regards, Thilanka.
Le 2011-07-03 04:48, Thilanka Kaushalya a écrit :
Hi Marc,
Thilanka,
this works fine. I could merge this but your code is becoming more difficult to merge.
This is because I can't merge your latest commit, due to the presence of the unfinished "Ajaxify Table-> Browse->Multiple rows->Export" in your tree.
So I would have to cherry-pick just some commits but this is error-prone.
I think now we can merge this change since I removed the changes for
multi_row->export.
Merged, thanks.
Le 2011-07-01 12:44, Thilanka Kaushalya a écrit :
Hi Marc,
I started working with ajaxify the Index->Edit option in Table->Structure. I added the following two action for tbl_structure.js file to handle the ajax.
- $("#table_index tbody tr td.edit_index.ajax").live('click') -
Correctly loads the "*index_frm*" to a dialog box 2. $("#index_frm.ajax input[name=do_save_data]").live('click') - which try to save the action.
But when I try to change the "*Index type*" it shows an js error in firebug. Then I checked it with non ajax event of index edit. In that case also it gives an error. It seems there is an error in the previously development which does not match the name of the option elements. Should I correct that or just consider on ajax event only.
Thilanka, I can also reproduce this bug, in current master and in the 3.4 branch. Please open an artifact in the bug tracker about this (and propose a patch if you have time).
-
Marc Delisle -
Thilanka Kaushalya