[Phpmyadmin-devel] getting help for fix[#3798]
I willing to work on this bug... https://sourceforge.net/p/phpmyadmin/bugs/3798/ As I commented on it.I found that delete button doesn't work either. as I quite new to code base... I want a help [0]Give me a idea about the files which this bug has [1]Any documentation that clearly describes the code base ps-I have attached a screen shot. thanks and regards -- Dulanja Wijethunga Faculty of Engineering, University of Peradeniya, Sri Lanka
Le 2013-02-09 02:10, Dulanja Wijethunga a écrit :
I willing to work on this bug... https://sourceforge.net/p/phpmyadmin/bugs/3798/
As I commented on it.I found that delete button doesn't work either. as I quite new to code base... I want a help
[0]Give me a idea about the files which this bug has [1]Any documentation that clearly describes the code base
There are various methods to help you find a bug. For example: - use Firefox with Firebug, and look at Firebug's Network panel when you see all requests, parameters and replies from the web server; there, you'll see which script is called - use NetBeans with PHP support, load phpMyAdmin into it, and follow execution in the source code Also, on http://www.phpmyadmin.net/home_page/devel.php there is a link to phpMyAdmin internals. -- Marc Delisle http://infomarc.info
On 2/9/13, Marc Delisle <marc@infomarc.info> wrote:
Le 2013-02-09 02:10, Dulanja Wijethunga a écrit :
I willing to work on this bug... https://sourceforge.net/p/phpmyadmin/bugs/3798/
I have done a pull request for it https://github.com/phpmyadmin/phpmyadmin/pull/156/files but here ,there are extra files which were created by NetBeans 1)Is there any way to remove them? 2)Did I correctly fix the bug? regards! -- Dulanja Wijethunga Faculty of Engineering, University of Peradeniya, Sri Lanka
On 02/09/2013 08:03 PM, Dulanja Wijethunga wrote:
On 2/9/13, Marc Delisle <marc@infomarc.info> wrote:
Le 2013-02-09 02:10, Dulanja Wijethunga a écrit :
I willing to work on this bug... https://sourceforge.net/p/phpmyadmin/bugs/3798/
I have done a pull request for it https://github.com/phpmyadmin/phpmyadmin/pull/156/files
but here ,there are extra files which were created by NetBeans 1)Is there any way to remove them?
Not committing them in the first place is a good idea.
2)Did I correctly fix the bug?
That's almost impossible to tell right now. Your commit generated 4089 additions and 4089 deletions, so I suspect that your text editor/ide uses CRLF line endings, but we use LF line endings in our repo. So you need to use the correct line endings so that only the changed lines show up in the commit. So, I'd say you should start over, it would be easier then fixing your pull request. Bye, Rouslan
On 02/09/2013 08:03 PM, Dulanja Wijethunga wrote:
I willing to work on this bug... https://sourceforge.net/p/phpmyadmin/bugs/3798/
I'm trying to fix this .. I have attached a screenshot of Libraries/Util.class.php I found that removing CHAR_LENGTH function helps to avoid the wrong WHERE clause in sql query such that I could delete and changed the selected raws. What is the purpose of using CHAR_LENGTH function in the Util.class.php? thanks and regards! -- Dulanja Wijethunga Faculty of Engineering, University of Peradeniya, Sri Lanka
On Sun, Feb 10, 2013 at 8:17 PM, Dulanja Wijethunga <dulanja33@gmail.com>wrote:
On 02/09/2013 08:03 PM, Dulanja Wijethunga wrote:
I willing to work on this bug... https://sourceforge.net/p/phpmyadmin/bugs/3798/
I'm trying to fix this .. I have attached a screenshot of Libraries/Util.class.php I found that removing CHAR_LENGTH function helps to avoid the wrong WHERE clause in sql query such that I could delete and changed the selected raws.
Well, that is evident from your pull request also, but as the comment on pull request 161 says, you have ignored the condition while removing CHAR_LENGTH. No need to attach a screenshot for the same thing.
What is the purpose of using CHAR_LENGTH function in the Util.class.php?
I have asked the author about it, at [0].
[0] https://github.com/phpmyadmin/phpmyadmin/commit/d9d92dda4670da467c718d630703...
thanks and regards!
-- Dulanja Wijethunga Faculty of Engineering, University of Peradeniya, Sri Lanka
------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Atul Pratap Singh http://blog.atulsisodia.in/
On Sun, Feb 10, 2013 at 10:17 PM, Atul Pratap Singh < atulpratapsingh05@gmail.com> wrote:
On Sun, Feb 10, 2013 at 8:17 PM, Dulanja Wijethunga <dulanja33@gmail.com>wrote:
On 02/09/2013 08:03 PM, Dulanja Wijethunga wrote:
I willing to work on this bug... https://sourceforge.net/p/phpmyadmin/bugs/3798/
I'm trying to fix this .. I have attached a screenshot of Libraries/Util.class.php I found that removing CHAR_LENGTH function helps to avoid the wrong WHERE clause in sql query such that I could delete and changed the selected raws.
Well, that is evident from your pull request also, but as the comment on pull request 161 says, you have ignored the condition while removing CHAR_LENGTH. No need to attach a screenshot for the same thing.
What is the purpose of using CHAR_LENGTH function in the Util.class.php?
I have asked the author about it, at [0].
[0] https://github.com/phpmyadmin/phpmyadmin/commit/d9d92dda4670da467c718d630703...
thanks and regards!
Hi, Indeed, this bug raised after 6 months :-O I added a comment at [0]
[0] : https://github.com/phpmyadmin/phpmyadmin/commit/d9d92dda4670da467c718d630703... Regards ! -- Chanaka Dharmarathna *Virtusa (Pvt) Ltd. | **Sri Lanka*
participants (5)
-
Atul Pratap Singh -
Chanaka Dharmarathna -
Dulanja Wijethunga -
Marc Delisle -
Rouslan Placella