On 02/09/2013 08:03 PM, Dulanja Wijethunga wrote: Not committing them in the first place is a good idea. That's almost impossible to tell right now. Your commit generated 4089 additions and 4089 deletions, so I suspect that your text editor/ide uses CRLF line endings, but we use LF line endings in our repo. So you need to use the correct line endings so that only the changed lines show up in the commit. So, I'd say you should start over, it would be easier then fixing your pull request. Bye, Rouslan

On Sun, Feb 10, 2013 at 8:17 PM, Dulanja Wijethunga <dulanja33(a)gmail.com>wrote;wrote: pull request 161 says, you have ignored the condition while removing CHAR_LENGTH. No need to attach a screenshot for the same thing. [0] https://github.com/phpmyadmin/phpmyadmin/commit/d9d92dda4670da467c718d63070… -- Atul Pratap Singh http://blog.atulsisodia.in/