[Phpmyadmin-devel] .gitignore /locale/ for external libraries
Hi, With commit 78b6f3d6 by Michal, /locale/ gets ignored in master. For the PHPExcel library this means the /locale/ directory is no longer under sourcecontrol. I don't think we use the translations for PHPExcel, and they probably can be removed (during the planned process of stripping the parts of that library we don't use), but maybe we should keep them for now? Or not, as it probably doesn't break exporting and it only affects master and should be solved by the release of 3.5 -- Kind regards,, Dieter Adriaenssens
Le 2011-06-04 08:19, Dieter Adriaenssens a écrit :
Hi,
With commit 78b6f3d6 by Michal, /locale/ gets ignored in master. For the PHPExcel library this means the /locale/ directory is no longer under sourcecontrol. I don't think we use the translations for PHPExcel, and they probably can be removed (during the planned process of stripping the parts of that library we don't use), but maybe we should keep them for now? Or not, as it probably doesn't break exporting and it only affects master and should be solved by the release of 3.5
Looking at the code even before this commit, I see no "locale" in phpMyAdmin's PHPExcel. -- Marc Delisle http://infomarc.info
2011/6/5 Marc Delisle <marc@infomarc.info>:
Le 2011-06-04 08:19, Dieter Adriaenssens a écrit :
Hi,
With commit 78b6f3d6 by Michal, /locale/ gets ignored in master. For the PHPExcel library this means the /locale/ directory is no longer under sourcecontrol. I don't think we use the translations for PHPExcel, and they probably can be removed (during the planned process of stripping the parts of that library we don't use), but maybe we should keep them for now? Or not, as it probably doesn't break exporting and it only affects master and should be solved by the release of 3.5
Looking at the code even before this commit, I see no "locale" in phpMyAdmin's PHPExcel.
Then it never got checked in when upgrading to the latest PHPExcel version (and was still hanging around in my local pma directory, being ignored by git). I understand why, now : before Michal's commit 'locale' was being ignored, and thus the locale directory of PHPExcel. Now '/locale/' is being ignored, which only applies to the locale directory in the root directory, and not anymore to the PHPExcel locale dir, which explains why git reports to add the PHPExcel locale directory. I will test if PHPExcel works without the locale dir, and if not, add it. But I guess it works without as we haven't had reports of Excel exports not working anymore (or did we?) Kind regards, Dieter
Le 2011-06-05 05:45, Dieter Adriaenssens a écrit :
2011/6/5 Marc Delisle <marc@infomarc.info>:
Le 2011-06-04 08:19, Dieter Adriaenssens a écrit :
Hi,
With commit 78b6f3d6 by Michal, /locale/ gets ignored in master. For the PHPExcel library this means the /locale/ directory is no longer under sourcecontrol. I don't think we use the translations for PHPExcel, and they probably can be removed (during the planned process of stripping the parts of that library we don't use), but maybe we should keep them for now? Or not, as it probably doesn't break exporting and it only affects master and should be solved by the release of 3.5
Looking at the code even before this commit, I see no "locale" in phpMyAdmin's PHPExcel.
Then it never got checked in when upgrading to the latest PHPExcel version (and was still hanging around in my local pma directory, being ignored by git).
I understand why, now : before Michal's commit 'locale' was being ignored, and thus the locale directory of PHPExcel. Now '/locale/' is being ignored, which only applies to the locale directory in the root directory, and not anymore to the PHPExcel locale dir, which explains why git reports to add the PHPExcel locale directory.
I will test if PHPExcel works without the locale dir, and if not, add it. But I guess it works without as we haven't had reports of Excel exports not working anymore (or did we?)
Kind regards,
Dieter
I don't remember such bug reports. -- Marc Delisle http://infomarc.info
2011/6/5 Marc Delisle <marc@infomarc.info>:
Le 2011-06-05 05:45, Dieter Adriaenssens a écrit :
2011/6/5 Marc Delisle <marc@infomarc.info>:
Le 2011-06-04 08:19, Dieter Adriaenssens a écrit :
Hi,
With commit 78b6f3d6 by Michal, /locale/ gets ignored in master. For the PHPExcel library this means the /locale/ directory is no longer under sourcecontrol. I don't think we use the translations for PHPExcel, and they probably can be removed (during the planned process of stripping the parts of that library we don't use), but maybe we should keep them for now? Or not, as it probably doesn't break exporting and it only affects master and should be solved by the release of 3.5
Looking at the code even before this commit, I see no "locale" in phpMyAdmin's PHPExcel.
Then it never got checked in when upgrading to the latest PHPExcel version (and was still hanging around in my local pma directory, being ignored by git).
I understand why, now : before Michal's commit 'locale' was being ignored, and thus the locale directory of PHPExcel. Now '/locale/' is being ignored, which only applies to the locale directory in the root directory, and not anymore to the PHPExcel locale dir, which explains why git reports to add the PHPExcel locale directory.
I will test if PHPExcel works without the locale dir, and if not, add it. But I guess it works without as we haven't had reports of Excel exports not working anymore (or did we?)
Kind regards,
Dieter
I don't remember such bug reports.
Basic export/import seems to work without the locale dir. :)
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Groetjes, Dieter Adriaenssens
Le 2011-06-05 06:24, Dieter Adriaenssens a écrit :
2011/6/5 Marc Delisle <marc@infomarc.info>:
Le 2011-06-05 05:45, Dieter Adriaenssens a écrit :
2011/6/5 Marc Delisle <marc@infomarc.info>:
Le 2011-06-04 08:19, Dieter Adriaenssens a écrit :
Hi,
With commit 78b6f3d6 by Michal, /locale/ gets ignored in master. For the PHPExcel library this means the /locale/ directory is no longer under sourcecontrol. I don't think we use the translations for PHPExcel, and they probably can be removed (during the planned process of stripping the parts of that library we don't use), but maybe we should keep them for now? Or not, as it probably doesn't break exporting and it only affects master and should be solved by the release of 3.5
Looking at the code even before this commit, I see no "locale" in phpMyAdmin's PHPExcel.
Then it never got checked in when upgrading to the latest PHPExcel version (and was still hanging around in my local pma directory, being ignored by git).
I understand why, now : before Michal's commit 'locale' was being ignored, and thus the locale directory of PHPExcel. Now '/locale/' is being ignored, which only applies to the locale directory in the root directory, and not anymore to the PHPExcel locale dir, which explains why git reports to add the PHPExcel locale directory.
I will test if PHPExcel works without the locale dir, and if not, add it. But I guess it works without as we haven't had reports of Excel exports not working anymore (or did we?)
Kind regards,
Dieter
I don't remember such bug reports.
Basic export/import seems to work without the locale dir. :)
With this directory present and switching phpMyAdmin to a language which is supported in PHPExcel, are the messages translated? -- Marc Delisle http://infomarc.info
2011/6/5 Marc Delisle <marc@infomarc.info>:
Le 2011-06-05 06:24, Dieter Adriaenssens a écrit :
2011/6/5 Marc Delisle <marc@infomarc.info>:
Le 2011-06-05 05:45, Dieter Adriaenssens a écrit :
2011/6/5 Marc Delisle <marc@infomarc.info>:
Le 2011-06-04 08:19, Dieter Adriaenssens a écrit :
Hi,
With commit 78b6f3d6 by Michal, /locale/ gets ignored in master. For the PHPExcel library this means the /locale/ directory is no longer under sourcecontrol. I don't think we use the translations for PHPExcel, and they probably can be removed (during the planned process of stripping the parts of that library we don't use), but maybe we should keep them for now? Or not, as it probably doesn't break exporting and it only affects master and should be solved by the release of 3.5
Looking at the code even before this commit, I see no "locale" in phpMyAdmin's PHPExcel.
Then it never got checked in when upgrading to the latest PHPExcel version (and was still hanging around in my local pma directory, being ignored by git).
I understand why, now : before Michal's commit 'locale' was being ignored, and thus the locale directory of PHPExcel. Now '/locale/' is being ignored, which only applies to the locale directory in the root directory, and not anymore to the PHPExcel locale dir, which explains why git reports to add the PHPExcel locale directory.
I will test if PHPExcel works without the locale dir, and if not, add it. But I guess it works without as we haven't had reports of Excel exports not working anymore (or did we?)
Kind regards,
Dieter
I don't remember such bug reports.
Basic export/import seems to work without the locale dir. :)
With this directory present and switching phpMyAdmin to a language which is supported in PHPExcel, are the messages translated?
Honestly, I don't remember ever seeing any PHPExcel mesages. I just looked inside a generated excel file and can't seem to find any messages there either. So I guess with what we're using of the PHPExcel library we're not using/getting any messages. Kind regards, Dieter
participants (2)
-
Dieter Adriaenssens -
Marc Delisle