3 Oct
2005
3 Oct
'05
6:32 p.m.
Hi,
i've done a little rewriting of all this qerywindow javascript stuff,
coming with this is
* XHTML comlinace at least in index.php and left.php
* more semantic XHTML
* moved all styling into css
* url param support for index.php (index.php?db=mysql)
* less JavaScript
* better support for non JS Browsers
* ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&g…
--
Sebastian Mendel
www.sebastianmendel.de www.warzonez.de www.tekkno4u.de www.nofetish.com
www.sf.net/projects/phpdatetime www.sf.net/projects/phptimesheet
3 Oct
3 Oct
9:09 p.m.
Sebastian Mendel wrote:
Hi,
i've done a little rewriting of all this qerywindow javascript stuff,
coming with this is
* XHTML comlinace at least in index.php and left.php
* more semantic XHTML
* moved all styling into css
* url param support for index.php (index.php?db=mysql)
* less JavaScript
* better support for non JS Browsers
* ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&g…
i would like to commit this into CVS, if no one is against.
Marc? Michal?
--
Sebastian Mendel
www.sebastianmendel.de
www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
10:26 p.m.
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
i would like to commit this into CVS, if no one is
against.
I just quickly looked at the patch, My comments follow. The all do not
address new code, however when the code is being touched, it could be
cleaned up :-). Those are just minor issues, generally I like it.
- do not hardcode color in global css
- do not change error reporting
- you can rely on fact that all cfg parameters are set, this includes
PmaAbsoluteUri
- I'm absolutely not sure about browser dependant css you removed from
theme
- did you intentionally remove +/- signs in front of expanded/non
expanded database in left frame?
- tables and databases are now printed same colour in left frame, I
think different colour was better
- frameset contains urls like left.php?&lang=cs-utf-8, there is
extra &
--
Michal Čihař | http://cihar.com
10:53 p.m.
Michal Čihař wrote:
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
i will take a look at this,
i would like to commit this into CVS, if no one
is against.
I just quickly looked at the patch, My comments follow. The all do not
address new code, however when the code is being touched, it could be
cleaned up :-). Those are just minor issues, generally I like it.
- do not hardcode color in global css - do not change error reporting
fixed lokaly, forgot to remove before creating the patch file
- you can rely on fact that all cfg parameters are
set, this includes
PmaAbsoluteUri
changed in index.php and left.php
- I'm absolutely not sure about browser dependant
css you removed from
theme
tested with IE 6, 5.5, 5, Opera, Firefox
and complies with my experience with CSS
- did you intentionally remove +/- signs in front of
expanded/non
expanded database in left frame?
only if only one db is available, so this db is allways expanded and
needs no +/-, or is this missing anywhere else?
- tables and databases are now printed same colour in
left frame, I
think different colour was better
i will take a look at this
- frameset contains urls like
left.php?&lang=cs-utf-8, there is
extra &
for sure? i cant reproduce
--
Sebastian Mendel
www.sebastianmendel.de
www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
11:11 p.m.
On Tue 4. 10. 2005 11:59, Sebastian Mendel wrote:
Maybe you miss $cfg['LeftFrameLight'] = FALSE; or I don't understand
your question.
Sure, just copy and paste from generated source ;-). It comes from
$url_query = implode( '&', $url_querys ) . '&'; if
$url_querys
is empty.
You also dropped support for LeftPointerEnable (I didn't notice it yet,
as I disabled it anyway :-))
--
Michal Čihař | http://cihar.com
Michal Čihař wrote:
Well there were some hacks for IE 4, however I don't know whether it is
still necessary to support this.
- I'm absolutely not sure about browser
dependant css you removed
from theme
tested with IE 6, 5.5, 5, Opera, Firefox
and complies with my experience with CSS - did you
intentionally remove +/- signs in front of expanded/non
expanded database in left frame?
only if only one db is available, so this db is allways expanded and
needs no +/-, or is this missing anywhere else? - frameset
contains urls like left.php?&lang=cs-utf-8, there is
extra &
for sure? i cant reproduce
11:25 p.m.
Michal Čihař wrote:
Maybe you miss $cfg['LeftFrameLight'] = FALSE; or I don't understand
your question.
i did not intentionally removed any +/-, only where only one db is
available, so this db is always expanded - just to clear out, send me a
screenshot
Sure, just copy and paste from generated source ;-). It comes from
$url_query = implode( '&', $url_querys ) . '&'; if
$url_querys
is empty.
oh, ok, fixed ;-)
On Tue 4. 10. 2005 11:59, Sebastian Mendel wrote:
IE 4 works 'well', except that you have an intended html unordered list
(as the unordered list layout cant be changed by CSS on IE 4)
Michal Čihař wrote:
Well there were some hacks for IE 4, however I don't know whether it is
still necessary to support this. - I'm absolutely not sure about browser
dependant css you removed
from theme
tested with IE 6, 5.5, 5, Opera, Firefox
and complies with my experience with CSS - did you intentionally remove +/- signs in front of
expanded/non
expanded database in left frame?
only if only one db is available, so this db is
allways expanded and
needs no +/-, or is this missing anywhere else? - frameset contains urls like
left.php?&lang=cs-utf-8, there is
extra &
for sure? i cant reproduce You also dropped support for LeftPointerEnable (I
didn't notice it yet,
as I disabled it anyway :-))
this JavaScript simulated hover effect? yes i dropped it
- i will add a css based hover effect
anyone against this?
--
Sebastian Mendel
www.sebastianmendel.de
www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
4 Oct
4 Oct
12:09 a.m.
On Tue 4. 10. 2005 12:30, Sebastian Mendel wrote:
Maybe you miss $cfg['LeftFrameLight'] = FALSE; or I don't
understand your question.
i did not intentionally removed any +/-, only where only one db is
available, so this db is always expanded - just to clear out, send me
a screenshot
Attached. I also see you changed separator behaviour as you do not
stript it, this should work as before.
Yes, I do not like it, do not add it to default themes ;-). Just remove
the config option and documentation for it.
--
Michal Čihař | http://cihar.com
- did you
intentionally remove +/- signs in front of expanded/non
expanded database in left frame?
only if only one db is available, so this db is allways expanded
and needs no +/-, or is this missing anywhere else? You also
dropped support for LeftPointerEnable (I didn't notice it
yet, as I disabled it anyway :-))
this JavaScript simulated hover effect? yes i dropped it
- i will add a css based hover effect
anyone against this? 
12:53 a.m.
Michal Čihař wrote:
On Tue 4. 10. 2005 12:30, Sebastian Mendel wrote:
i did not intentionally removed any +/-, only where only
one db is
available, so this db is always expanded - just to clear out, send me
a screenshot
Attached.
the icon has a size of 0.9em (90% of font size), as your font is very
small the icon is scaled down ... i will look into this
> - did you intentionally remove +/- signs in front
of expanded/non
> expanded database in left frame?
only if only one db is available, so this db is allways expanded
and needs no +/-, or is this missing anywhere else?
Maybe you miss
$cfg['LeftFrameLight'] = FALSE; or I don't
understand your question. I also see you changed separator behaviour as you do
not
stript it, this should work as before.
ok
--
Sebastian Mendel
www.sebastianmendel.de
www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
3 Oct
3 Oct
11:59 p.m.
Michal Čihař wrote:
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
also $GLOBALS['cfg']['Bookmark']['db'] ?
if ( ! empty( $GLOBALS['cfg']['Bookmark'] )
&& $GLOBALS['cfg']['Bookmark']['db']
&& $GLOBALS['cfg']['Bookmark']['table'] ) {
can become
if ( $GLOBALS['cfg']['Bookmark']['db']
&& $GLOBALS['cfg']['Bookmark']['table'] ) {
?
--
Sebastian Mendel
www.sebastianmendel.de
www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
i would like to commit this into CVS, if no one
is against.
I just quickly looked at the patch, My comments follow. The all do not
address new code, however when the code is being touched, it could be
cleaned up :-). Those are just minor issues, generally I like it.
- do not hardcode color in global css
- do not change error reporting
- you can rely on fact that all cfg parameters are set, this includes
PmaAbsoluteUri
4 Oct
4 Oct
12:16 a.m.
On Tue 4. 10. 2005 13:04, Sebastian Mendel wrote:
Michal Čihař wrote:
If there is server selected PMA_getBookmarksParam will fill it.
--
Michal Čihař | http://cihar.com
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
also $GLOBALS['cfg']['Bookmark']['db'] ? i would like to commit this into CVS, if no one
is against.
I just quickly looked at the patch, My comments follow. The all do
not address new code, however when the code is being touched, it
could be cleaned up :-). Those are just minor issues, generally I
like it.
- do not hardcode color in global css
- do not change error reporting
- you can rely on fact that all cfg parameters are set, this
includes PmaAbsoluteUri 
6:17 a.m.
Sebastian Mendel a écrit :
Sebastian Mendel wrote:
A few comments (as a user) under Firefox:
- In the left panel, I no longer see the number of rows for each table.
When hovering the small icon, I only see "Browse:".
- when creating/dropping a table, the left frame does not refresh
Marc
Hi,
i've done a little rewriting of all this qerywindow javascript stuff,
coming with this is
* XHTML comlinace at least in index.php and left.php
* more semantic XHTML
* moved all styling into css
* url param support for index.php (index.php?db=mysql)
* less JavaScript
* better support for non JS Browsers
* ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&g…
i would like to commit this into CVS, if no one is against.
Marc? Michal?
7:50 p.m.
Marc Delisle wrote:
Sebastian Mendel a écrit :
yes, i noticed this yesterday fixed locally ...
Sebastian Mendel wrote:
A few comments (as a user) under Firefox:
- In the left panel, I no longer see the number of rows for each table.
When hovering the small icon, I only see "Browse:". Hi,
i've done a little rewriting of all this qerywindow javascript stuff,
coming with this is
* XHTML comlinace at least in index.php and left.php
* more semantic XHTML
* moved all styling into css
* url param support for index.php (index.php?db=mysql)
* less JavaScript
* better support for non JS Browsers
* ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&g…
i would like to commit this into CVS, if no one is against.
Marc? Michal?
- when creating/dropping a table, the left frame does
not refresh
looking into this ...
--
Sebastian Mendel
www.sebastianmendel.de
www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
10 Oct
10 Oct
11:39 p.m.
Sebastian Mendel wrote:
Hi,
i've done a little rewriting of all this qerywindow javascript stuff,
coming with this is
* XHTML comlinace at least in index.php and left.php
* more semantic XHTML
* moved all styling into css
* url param support for index.php (index.php?db=mysql)
* less JavaScript
* better support for non JS Browsers
* ...
https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&g…
ok, i think i have adressed all issues mentioned here, i will check in
in now ...
--
Sebastian Mendel
www.sebastianmendel.de
www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
11 Oct
11 Oct
7:32 a.m.
Hi!
ok, i think i have adressed all issues mentioned here,
i will check in in now
...
The tabs still look broken like the screenshot I posted a week ago, with
misaligned borders on the "Search" tab and the CSS for one of the nested tables
("backup") of the HTML source I posted you some time ago is still formated
differently than the other tables?
(Just wanted to drop those two issues - if they're not related to what you
meant, please disregard this posting. The refresh of the left frame after
selecting a table is gone now, thanks a lot! :-)
Best regards,
Garvin
--
++ Garvin Hicking | Web-Entwickler [PHP] | www.garv.in | ICQ 21392242
++ Developer of | www.phpMyAdmin.net | www.s9y.org
++ Make me happy | http://wishes.garv.in
7:14 p.m.
Garvin Hicking wrote:
Hi!
The 'tabs' in the server/db/table navigation?
ok, i think i have adressed all issues mentioned
here, i will check in in now
...
The tabs still look broken like the screenshot I posted a week ago, with
misaligned borders on the "Search" tab and the CSS for one of the nested tables
("backup") of the HTML source I posted you some time ago is still formated
differently than the other tables?
'differently formated' means it have a different color? font size and
type should be the same.
(Just wanted to drop those two issues - if they're
not related to what you
meant, please disregard this posting. The refresh of the left frame after
selecting a table is gone now, thanks a lot! :-)
--
Sebastian Mendel
www.sebastianmendel.de
www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
6864
days inactive
6872
days old
14 comments
4 participants
participants (4)
-
Garvin Hicking -
Marc Delisle -
Michal Čihař -
Sebastian Mendel