Hi,
as with the new import can we remove references/links to 'ldi_*' ? and also remove the import from the SQL-tab and replace the old import in the querywindow with the new?
Hi
On Mon 26. 9. 2005 13:24, Sebastian Mendel wrote:
as with the new import can we remove references/links to 'ldi_*' ? and also remove the import from the SQL-tab and replace the old import in the querywindow with the new?
Well my plan for transition was to keep for some time both options in CVS. After that I want to:
- remove ldi* and all references - remove read_dump and all references - keep just textarea on SQL tab and post it to import.php
I'm not sure what about querywindow. It's too small to hold whole import, so probably there will stay SQL import only.
Michal Čihař wrote:
Hi
On Mon 26. 9. 2005 13:24, Sebastian Mendel wrote:
as with the new import can we remove references/links to 'ldi_*' ? and also remove the import from the SQL-tab and replace the old import in the querywindow with the new?
Well my plan for transition was to keep for some time both options in CVS. After that I want to:
- remove ldi* and all references
- remove read_dump and all references
- keep just textarea on SQL tab and post it to import.php
I'm not sure what about querywindow. It's too small to hold whole import, so probably there will stay SQL import only.
at the moment i am over this whole sql query stuff, made one single function for every place where sql query input is required (server, table and db sql-tab, querywindow)
btw. is it acceptable in case of QueryFrameJS disabled to switch to server/db/table sql tab when clicked SQL-Icon in queryframe?
Sebastian Mendel wrote:
Michal Čihař wrote:
I'm not sure what about querywindow. It's too small to hold whole import, so probably there will stay SQL import only.
btw. in my opinion, it makes no sense to display the/a import dialog in the querywindow ...
On Mon 26. 9. 2005 14:01, Sebastian Mendel wrote:
Sebastian Mendel wrote:
Michal Čihař wrote:
I'm not sure what about querywindow. It's too small to hold whole import, so probably there will stay SQL import only.
btw. in my opinion, it makes no sense to display the/a import dialog in the querywindow ...
You're right, just SQL + history might be enough.
Sebastian Mendel a écrit :
Sebastian Mendel wrote:
Michal Čihař wrote:
I'm not sure what about querywindow. It's too small to hold whole import, so probably there will stay SQL import only.
btw. in my opinion, it makes no sense to display the/a import dialog in the querywindow ...
I agree. This was placed there to have an Import dialog somewhere :)
Marc
Hi!
btw. in my opinion, it makes no sense to display the/a import dialog in the querywindow ...
I agree. This was placed there to have an Import dialog somewhere :)
I strongly disagree. I need and use the "Import" dialog nearly once a day and don't want to resort
On a totally un related sidenote: I just updated to the latest CVS, and my menu now looks very odd:
http://img235.imageshack.us/img235/4809/pmahead3sj.jpg
How come?
Regards, Garvin
Garvin Hicking wrote:
Hi!
btw. in my opinion, it makes no sense to display the/a import dialog in the querywindow ...
I agree. This was placed there to have an Import dialog somewhere :)
I strongly disagree. I need and use the "Import" dialog nearly once a day and don't want to resort
from the querywindow? what are the advantages?
On a totally un related sidenote: I just updated to the latest CVS, and my menu now looks very odd:
http://img235.imageshack.us/img235/4809/pmahead3sj.jpg
How come?
what looks odd with this?
Hi Sebastian!
I strongly disagree. I need and use the "Import" dialog nearly once a day and don't want to resort
from the querywindow? what are the advantages?
Yes, the advantage is that I have that window always open. Sometimes my main phpmyadmin windows displays a PDF or a Dump without the SQL tab. I would need additional clicks to get to the import screen, which I wouldn't find nice.
At least 2 of my co-workers also have their windows open all the time and use that for SQL related tasks...
http://img235.imageshack.us/img235/4809/pmahead3sj.jpg How come?
what looks odd with this?
Look at "Abfrageeditor". It looks garbaged.
Also the thick border under the items has not been there before.
Also look at the 1px spacing between the items and the line.
I have not modified my template/design, of course. :)
Regards, Garvin
Garvin Hicking wrote:
Hi Sebastian!
I strongly disagree. I need and use the "Import" dialog nearly once a day and don't want to resort
from the querywindow? what are the advantages?
Yes, the advantage is that I have that window always open. Sometimes my main phpmyadmin windows displays a PDF or a Dump without the SQL tab. I would need additional clicks to get to the import screen, which I wouldn't find nice.
but only for sql files? or CSV too?
At least 2 of my co-workers also have their windows open all the time and use that for SQL related tasks...
http://img235.imageshack.us/img235/4809/pmahead3sj.jpg How come?
what looks odd with this?
Look at "Abfrageeditor". It looks garbaged.
Also the thick border under the items has not been there before.
Also look at the 1px spacing between the items and the line.
I have not modified my template/design, of course. :)
yes, this is a minor fault!
im working on this ... if i have the time, but even with this its better than before (in a table) cause now it is wrapped if the window is too small, you dont have to scroll verticaly (naja seitwärts halt, weißt schon)
Hi!
Yes, the advantage is that I have that window always open. Sometimes my main phpmyadmin windows displays a PDF or a Dump without the SQL tab. I would need additional clicks to get to the import screen, which I wouldn't find nice.
but only for sql files? or CSV too?
Only for SQL files, yes. Did I misunderstand something and are you talking about moving the "upload SQL functionality" to the SQL tab? That would be fine for me; just don't remove the .SQL upload file possibility from the querywindow, please. :)
Look at "Abfrageeditor". It looks garbaged.
[...]
yes, this is a minor fault!
Compared to the look of previous versions I think this looks really odd; it really needs to be adressed before a release is made. :)
Best regards, Garvin
Hi
On Mon 26. 9. 2005 17:47, Garvin Hicking wrote:
Only for SQL files, yes. Did I misunderstand something and are you talking about moving the "upload SQL functionality" to the SQL tab? That would be fine for me; just don't remove the .SQL upload file possibility from the querywindow, please.
Yes it was originally about dropping import from query window. There is definitely not place for complete import dialog, but SQL import can stay there.
Compared to the look of previous versions I think this looks really odd; it really needs to be adressed before a release is made. :)
Doesn't 2.6.4 look same? :-)
BTW: Why do you set Reply-To on messages to mailing list?
Hi Michal!
Yes it was originally about dropping import from query window. There is definitely not place for complete import dialog, but SQL import can stay there.
Okay; I agree that CSV import isn't really necessary there :)
Compared to the look of previous versions I think this looks really odd; it really needs to be adressed before a release is made. :)
Doesn't 2.6.4 look same? :-)
I must admit I've never had the time to try 2.6.4 - my last CVS checkout was about 1.5 months old.
BTW: Why do you set Reply-To on messages to mailing list?
I just hit "Reply All" :)
Regards, Garvin
On Mon 26. 9. 2005 13:53, Sebastian Mendel wrote:
at the moment i am over this whole sql query stuff, made one single function for every place where sql query input is required (server, table and db sql-tab, querywindow)
Okay I won't touch it now, but I'll wait till you're ready with this and change new function afterwards.
Michal Čihař a écrit :
Hi
On Mon 26. 9. 2005 13:24, Sebastian Mendel wrote:
as with the new import can we remove references/links to 'ldi_*' ? and also remove the import from the SQL-tab and replace the old import in the querywindow with the new?
Well my plan for transition was to keep for some time both options in CVS. After that I want to:
- remove ldi* and all references
Is it still your plan to add LOAD DATA INFILE support in an import plugin?
- remove read_dump and all references
- keep just textarea on SQL tab and post it to import.php
On the SQL tab, do we need to replace the "Location of the textfile" dialog by a link to the Import tab? Same principle than the "Insert data from a text file" that we can see in the SQL tab?
I'm not sure what about querywindow. It's too small to hold whole import, so probably there will stay SQL import only.
On Mon 26. 9. 2005 14:25, Marc Delisle wrote:
Michal Čihař a écrit :
- remove ldi* and all references
Is it still your plan to add LOAD DATA INFILE support in an import plugin?
Yes, I still plan to do so, it doesn't require much work, I just need to start work on it :-).
- remove read_dump and all references
- keep just textarea on SQL tab and post it to import.php
On the SQL tab, do we need to replace the "Location of the textfile" dialog by a link to the Import tab? Same principle than the "Insert data from a text file" that we can see in the SQL tab?
Why? There is import tab available everywhere.
Michal Čihař a écrit :
On Mon 26. 9. 2005 14:25, Marc Delisle wrote:
Michal Čihař a écrit :
- remove ldi* and all references
Is it still your plan to add LOAD DATA INFILE support in an import plugin?
Yes, I still plan to do so, it doesn't require much work, I just need to start work on it :-).
- remove read_dump and all references
- keep just textarea on SQL tab and post it to import.php
On the SQL tab, do we need to replace the "Location of the textfile" dialog by a link to the Import tab? Same principle than the "Insert data from a text file" that we can see in the SQL tab?
Why? There is import tab available everywhere.
Ok to remove, with some publicity in the release notes. Anyway, the SQL tab will get a new dialog "Go and CREATE VIEW from this SQL query".
Marc
On Mon 26. 9. 2005 14:25, Marc Delisle wrote:
Is it still your plan to add LOAD DATA INFILE support in an import plugin?
It's finally done ;-).
-
Garvin Hicking -
Marc Delisle -
Michal Čihař -
Sebastian Mendel