[Phpmyadmin-devel] htmlspecialchars for gettext output?
Hi, I feel that http://wiki.phpmyadmin.net/pma/Gettext_for_developers should mention something about whether it is useful/needed to run the output of __('Default') through htmlspecialchars. To the best of my knowledge this is not needed, and just adds overhead. But a quick grep in the code pointed me to 23 lines doing this. Please correct me if I'm wrong here...Michal? -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions
Hi Dne Fri, 05 Aug 2011 09:57:21 +0200 Herman van Rink <rink@initfour.nl> napsal(a):
I feel that http://wiki.phpmyadmin.net/pma/Gettext_for_developers should mention something about whether it is useful/needed to run the output of __('Default') through htmlspecialchars.
To the best of my knowledge this is not needed, and just adds overhead. But a quick grep in the code pointed me to 23 lines doing this.
Please correct me if I'm wrong here...Michal?
You're right, it should not be needed. I will fix that. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (2)
-
Herman van Rink -
Michal Čihař