Re: [Phpmyadmin-devel] Re: globals
Hi I guess this should go to the list :-) On Thu, 22 Dec 2005 08:16:41 +0100 Sebastian Mendel <lists@sebastianmendel.de> wrote:
Michal Čihař schrieb:
I don't see much benefit of this. This would mean to split files into smaller ones, what means more maintenance. For most things splitting will be tricky or will end in main category.
with templates PMA will not include the text itself, but its name
<?php ... $strings['CouldNotLoadExtension'] = null; $template->append_by_ref( 'errors', $strings['CouldNotLoadExtension'] ); ...
... // load strings from DB $sql = 'SELECT `id`, `string` FROM `cz` WHERE `id` IN (\'' . implode(array_keys($strings)) . '\')'; $strings = PMA_DBI_fetch_result($sql, 'id', 'string'); ...
... $template->display(); ... ?>
Yes, templates would be great, but I still do not see advantage of db stored strings ;-). -- Michal Čihař | http://cihar.com
Michal Čihař schrieb:
Hi
I guess this should go to the list :-)
On Thu, 22 Dec 2005 08:16:41 +0100 Sebastian Mendel <lists@sebastianmendel.de> wrote:
Michal Čihař schrieb:
I don't see much benefit of this. This would mean to split files into smaller ones, what means more maintenance. For most things splitting will be tricky or will end in main category. with templates PMA will not include the text itself, but its name
<?php ... $strings['CouldNotLoadExtension'] = null; $template->append_by_ref( 'errors', $strings['CouldNotLoadExtension'] ); ...
... // load strings from DB $sql = 'SELECT `id`, `string` FROM `cz` WHERE `id` IN (\'' . implode(array_keys($strings)) . '\')'; $strings = PMA_DBI_fetch_result($sql, 'id', 'string'); ...
... $template->display(); ... ?>
Yes, templates would be great, but I still do not see advantage of db stored strings ;-).
- strings will be fetched at and of script (after all other tasks finished) -> saves memory for other tasks - only really needed strings will be fetched - loading strings take time and memory - less strings less time and memory, and i don't think that PMA will uses less strings in future ... ;-) -- Sebastian Mendel www.sebastianmendel.de www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
Hi!
Yes, templates would be great, but I still do not see advantage of db stored strings ;-).
- strings will be fetched at and of script (after all other tasks finished
It should be thought of that upgrading will be harder, because phpMyAdmin first needs to insert all new/updated strings into the database. This will require a PMA updating facility, which connects properly to the database. That in turn means, the user either has to specify the password on upgrade, or the password needs to be stored in clear text on-disc. I actually think this large overhead doesn't balance the positive effects of a DB-stored language interface...? Regards, Garvin -- ++ Garvin Hicking | Web-Entwickler [PHP] | www.garv.in | ICQ 21392242 ++ Developer of | www.phpMyAdmin.net | www.s9y.org ++ Make me happy | http://wishes.garv.in
Garvin Hicking a écrit :
Hi!
Yes, templates would be great, but I still do not see advantage of db stored strings ;-).
- strings will be fetched at and of script (after all other tasks finished
It should be thought of that upgrading will be harder, because phpMyAdmin first needs to insert all new/updated strings into the database. This will require a PMA updating facility, which connects properly to the database. That in turn means, the user either has to specify the password on upgrade, or the password needs to be stored in clear text on-disc.
I actually think this large overhead doesn't balance the positive effects of a DB-stored language interface...?
Regards, Garvin
I don't like either the overhead of having to maintain a db for the strings, first for the users/installers of PMA, second for the development team. We have more urgent things to do IMO. Marc
Hi On Tue, 10 Jan 2006 08:22:24 -0500 Marc Delisle <Marc.Delisle@cegepsherbrooke.qc.ca> wrote:
I don't like either the overhead of having to maintain a db for the strings, first for the users/installers of PMA, second for the development team. We have more urgent things to do IMO.
I absolutely agree. -- Michal Čihař | http://cihar.com
participants (4)
-
Garvin Hicking -
Marc Delisle -
Michal Čihař -
Sebastian Mendel