Le 2011-03-18 15:47, Dieter Adriaenssens a écrit :

2011/3/18 Marc Delisle <marc@infomarc.info>:

...

Hi,

Please try this patch (on master): https://sourceforge.net/tracker/?func=detail&aid=3223137&group_id=23067&atid...

Comments are welcome.

Hi,

I like option 2, but the space between the <<, < buttons and 'Page Number:' is bigger than between 'Page Number:' and the >, >> buttons.

Should be fixed now with navigation3.diff; first pull current master then apply. Tests should be done with and without the ShowAll button activated. -- Marc Delisle http://infomarc.info

Le 2011-03-19 08:57, Dieter Adriaenssens a écrit :

2011/3/19 Marc Delisle <marc@infomarc.info>:

...

Le 2011-03-18 15:47, Dieter Adriaenssens a écrit :

...

2011/3/18 Marc Delisle <marc@infomarc.info>:

...

Hi,

Please try this patch (on master): https://sourceforge.net/tracker/?func=detail&aid=3223137&group_id=23067&atid...

Comments are welcome.

Hi,

I like option 2, but the space between the <<, < buttons and 'Page Number:' is bigger than between 'Page Number:' and the >, >> buttons.

Should be fixed now with navigation3.diff; first pull current master then apply.

Tests should be done with and without the ShowAll button activated.

* After clicking the ShowAll button, there is no way of disabling it, because the button disappears. Reloading the page doesn't help.

Clicking the Show button works.

* I think the ShowAll button would fit better after the > and >> buttons.

It was there previously but I got a suggestion, that the > and >> buttons should be at the far right side, to visually represent moving towards the end.

* Did you do the spacing between the buttons with spaces?

No, it comes from the theme.

Greets,

Dieter

...

-- Marc Delisle http://infomarc.info

------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

-- Marc Delisle http://infomarc.info

Le 2011-03-19 13:15, Dieter Adriaenssens a écrit :

2011/3/19 Marc Delisle <marc@infomarc.info>:

...

Le 2011-03-19 08:57, Dieter Adriaenssens a écrit :

...

2011/3/19 Marc Delisle <marc@infomarc.info>:

...

Le 2011-03-18 15:47, Dieter Adriaenssens a écrit :

...

2011/3/18 Marc Delisle <marc@infomarc.info>:

...

Hi,

Please try this patch (on master): https://sourceforge.net/tracker/?func=detail&aid=3223137&group_id=23067&atid...

Comments are welcome.

Hi,

I like option 2, but the space between the <<, < buttons and 'Page Number:' is bigger than between 'Page Number:' and the >, >> buttons.

Should be fixed now with navigation3.diff; first pull current master then apply.

Tests should be done with and without the ShowAll button activated.

* After clicking the ShowAll button, there is no way of disabling it, because the button disappears. Reloading the page doesn't help.

Clicking the Show button works.

Yes, I tried it, and it works. But it doesn't seem too intuitive to me.

The behavior has been like this for some years; it could be improved in 3.5 because I guess we'll need another message and 3.4 is message frozen.

...

...

* I think the ShowAll button would fit better after the > and >> buttons.

It was there previously but I got a suggestion, that the > and >> buttons should be at the far right side, to visually represent moving towards the end.

...

* Did you do the spacing between the buttons with spaces?

No, it comes from the theme.

OK, looks good.

I'll merge to master and if others have comments we'll see the outcome. -- Marc Delisle http://infomarc.info