30 Jul
2013
30 Jul
'13
5:40 a.m.
Hi
I've added error reporting server to Jenkins, but I wonder what coding
style it should use - the CakePHP one (as it is CakePHP based) or
phpMyAdmin one (as it is part of phpMyAdmin)?
Currently it does not really match either of them:
https://ci.phpmyadmin.net/job/phpMyAdmin-error-reporting-server/
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
30 Jul
30 Jul
6:31 a.m.
I was not exactly following any coding guidelines other than my own.
However most of the warnings are because I use spaces and the
convention is to use tabs. I can write a vim regex to change the
files.
I believe that the CakePHP checkstyle should be used since while this
is part of the phpmyadmin family of webapps we should respect the
guidelines of the used framework so that we are not fighting an uphill
battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Finally to correct those checkstyle warnings I will have to do
multiple pull requests so I was wondering who has commit access to the
repo so that he may accept my pull requests so that I can see my
changes updated in jenkins
On Tue, Jul 30, 2013 at 10:40 AM, Michal Čihař <michal(a)cihar.com> wrote:
Hi
I've added error reporting server to Jenkins, but I wonder what coding
style it should use - the CakePHP one (as it is CakePHP based) or
phpMyAdmin one (as it is part of phpMyAdmin)?
Currently it does not really match either of them:
https://ci.phpmyadmin.net/job/phpMyAdmin-error-reporting-server/
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent
caught up. So what steps can you take to put your SQL databases under
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.cl…
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
--
Mohamed Ashraf
6:37 a.m.
Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200
Mohamed Ashraf <mohamed.ashraf.213(a)gmail.com> napsal(a):
I was not exactly following any coding guidelines
other than my own.
However most of the warnings are because I use spaces and the
convention is to use tabs. I can write a vim regex to change the
files.
I believe that the CakePHP checkstyle should be used since while this
is part of the phpmyadmin family of webapps we should respect the
guidelines of the used framework so that we are not fighting an uphill
battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
6:39 a.m.
Dne Tue, 30 Jul 2013 11:37:51 +0200
Michal Čihař <michal(a)cihar.com> napsal(a):
Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200
Mohamed Ashraf <mohamed.ashraf.213(a)gmail.com> napsal(a):
... you can actually see or change this in build.xml
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
I was not exactly following any coding guidelines
other than my own.
However most of the warnings are because I use spaces and the
convention is to use tabs. I can write a vim regex to change the
files.
I believe that the CakePHP checkstyle should be used since while this
is part of the phpmyadmin family of webapps we should respect the
guidelines of the used framework so that we are not fighting an uphill
battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style.
6:47 a.m.
On Tue, Jul 30, 2013 at 11:39 AM, Michal Čihař <michal(a)cihar.com> wrote:
Dne Tue, 30 Jul 2013 11:37:51 +0200
Michal Čihař <michal(a)cihar.com> napsal(a):
who has commit access to the repo other than you? I was wondering if
you could add one or both my mentors on this list so that they can
accept my pull requests.
--
Mohamed Ashraf
Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200
Mohamed Ashraf <mohamed.ashraf.213(a)gmail.com> napsal(a):
... you can actually see or change this in build.xml I was not exactly following any coding guidelines
other than my own.
However most of the warnings are because I use spaces and the
convention is to use tabs. I can write a vim regex to change the
files.
I believe that the CakePHP checkstyle should be used since while this
is part of the phpmyadmin family of webapps we should respect the
guidelines of the used framework so that we are not fighting an uphill
battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style.
6:55 a.m.
Hi
Dne Tue, 30 Jul 2013 11:47:57 +0200
Mohamed Ashraf <mohamed.ashraf.213(a)gmail.com> napsal(a):
On Tue, Jul 30, 2013 at 11:39 AM, Michal Čihař
<michal(a)cihar.com> wrote:
Any phpMyAdmin developer should have access, so they should be able to
do that (in case it does not work, I've done something wrong and please
let me know).
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
Dne Tue, 30 Jul 2013 11:37:51 +0200
Michal Čihař <michal(a)cihar.com> napsal(a):
who has commit access to the repo other than you? I was wondering if
you could add one or both my mentors on this list so that they can
accept my pull requests. Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200
Mohamed Ashraf <mohamed.ashraf.213(a)gmail.com> napsal(a):
... you can actually see or change this in build.xml I was not exactly following any coding guidelines
other than my own.
However most of the warnings are because I use spaces and the
convention is to use tabs. I can write a vim regex to change the
files.
I believe that the CakePHP checkstyle should be used since while this
is part of the phpmyadmin family of webapps we should respect the
guidelines of the used framework so that we are not fighting an uphill
battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style. 
1:44 p.m.
On 07/30/2013 10:55 AM, Michal Čihař wrote:
Hi
Dne Tue, 30 Jul 2013 11:47:57 +0200
Mohamed Ashraf <mohamed.ashraf.213(a)gmail.com> napsal(a):
Sounds about right :)
Bye,
Rouslan
On Tue, Jul 30, 2013 at 11:39 AM, Michal Čihař
<michal(a)cihar.com> wrote:
Any phpMyAdmin developer should have access, so they should be able to
do that (in case it does not work, I've done something wrong and please
let me know). Dne Tue, 30 Jul 2013 11:37:51 +0200
Michal Čihař <michal(a)cihar.com> napsal(a):
who has commit access to the repo other than you? I was wondering if
you could add one or both my mentors on this list so that they can
accept my pull requests. Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200
Mohamed Ashraf <mohamed.ashraf.213(a)gmail.com> napsal(a):
> I was not exactly following any coding guidelines other than my own.
> However most of the warnings are because I use spaces and the
> convention is to use tabs. I can write a vim regex to change the
> files.
>
> I believe that the CakePHP checkstyle should be used since while this
> is part of the phpmyadmin family of webapps we should respect the
> guidelines of the used framework so that we are not fighting an uphill
> battle with our own framework over code guidelines.
>
> Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style.
... you can actually see or change this in build.xml
4058
days inactive
4058
days old
6 comments
3 participants
participants (3)
-
Michal Čihař -
Mohamed Ashraf -
Rouslan Placella