Hi
I've added error reporting server to Jenkins, but I wonder what coding style it should use - the CakePHP one (as it is CakePHP based) or phpMyAdmin one (as it is part of phpMyAdmin)?
Currently it does not really match either of them:
https://ci.phpmyadmin.net/job/phpMyAdmin-error-reporting-server/
I was not exactly following any coding guidelines other than my own. However most of the warnings are because I use spaces and the convention is to use tabs. I can write a vim regex to change the files.
I believe that the CakePHP checkstyle should be used since while this is part of the phpmyadmin family of webapps we should respect the guidelines of the used framework so that we are not fighting an uphill battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Finally to correct those checkstyle warnings I will have to do multiple pull requests so I was wondering who has commit access to the repo so that he may accept my pull requests so that I can see my changes updated in jenkins
On Tue, Jul 30, 2013 at 10:40 AM, Michal Čihař michal@cihar.com wrote:
Hi
I've added error reporting server to Jenkins, but I wonder what coding style it should use - the CakePHP one (as it is CakePHP based) or phpMyAdmin one (as it is part of phpMyAdmin)?
Currently it does not really match either of them:
https://ci.phpmyadmin.net/job/phpMyAdmin-error-reporting-server/
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clk... _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200 Mohamed Ashraf mohamed.ashraf.213@gmail.com napsal(a):
I was not exactly following any coding guidelines other than my own. However most of the warnings are because I use spaces and the convention is to use tabs. I can write a vim regex to change the files.
I believe that the CakePHP checkstyle should be used since while this is part of the phpmyadmin family of webapps we should respect the guidelines of the used framework so that we are not fighting an uphill battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style.
Dne Tue, 30 Jul 2013 11:37:51 +0200 Michal Čihař michal@cihar.com napsal(a):
Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200 Mohamed Ashraf mohamed.ashraf.213@gmail.com napsal(a):
I was not exactly following any coding guidelines other than my own. However most of the warnings are because I use spaces and the convention is to use tabs. I can write a vim regex to change the files.
I believe that the CakePHP checkstyle should be used since while this is part of the phpmyadmin family of webapps we should respect the guidelines of the used framework so that we are not fighting an uphill battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style.
... you can actually see or change this in build.xml
On Tue, Jul 30, 2013 at 11:39 AM, Michal Čihař michal@cihar.com wrote:
Dne Tue, 30 Jul 2013 11:37:51 +0200 Michal Čihař michal@cihar.com napsal(a):
Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200 Mohamed Ashraf mohamed.ashraf.213@gmail.com napsal(a):
I was not exactly following any coding guidelines other than my own. However most of the warnings are because I use spaces and the convention is to use tabs. I can write a vim regex to change the files.
I believe that the CakePHP checkstyle should be used since while this is part of the phpmyadmin family of webapps we should respect the guidelines of the used framework so that we are not fighting an uphill battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style.
... you can actually see or change this in build.xml
who has commit access to the repo other than you? I was wondering if you could add one or both my mentors on this list so that they can accept my pull requests.
Hi
Dne Tue, 30 Jul 2013 11:47:57 +0200 Mohamed Ashraf mohamed.ashraf.213@gmail.com napsal(a):
On Tue, Jul 30, 2013 at 11:39 AM, Michal Čihař michal@cihar.com wrote:
Dne Tue, 30 Jul 2013 11:37:51 +0200 Michal Čihař michal@cihar.com napsal(a):
Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200 Mohamed Ashraf mohamed.ashraf.213@gmail.com napsal(a):
I was not exactly following any coding guidelines other than my own. However most of the warnings are because I use spaces and the convention is to use tabs. I can write a vim regex to change the files.
I believe that the CakePHP checkstyle should be used since while this is part of the phpmyadmin family of webapps we should respect the guidelines of the used framework so that we are not fighting an uphill battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style.
... you can actually see or change this in build.xml
who has commit access to the repo other than you? I was wondering if you could add one or both my mentors on this list so that they can accept my pull requests.
Any phpMyAdmin developer should have access, so they should be able to do that (in case it does not work, I've done something wrong and please let me know).
On 07/30/2013 10:55 AM, Michal Čihař wrote:
Hi
Dne Tue, 30 Jul 2013 11:47:57 +0200 Mohamed Ashraf mohamed.ashraf.213@gmail.com napsal(a):
On Tue, Jul 30, 2013 at 11:39 AM, Michal Čihař michal@cihar.com wrote:
Dne Tue, 30 Jul 2013 11:37:51 +0200 Michal Čihař michal@cihar.com napsal(a):
Hi
Dne Tue, 30 Jul 2013 11:31:15 +0200 Mohamed Ashraf mohamed.ashraf.213@gmail.com napsal(a):
I was not exactly following any coding guidelines other than my own. However most of the warnings are because I use spaces and the convention is to use tabs. I can write a vim regex to change the files.
I believe that the CakePHP checkstyle should be used since while this is part of the phpmyadmin family of webapps we should respect the guidelines of the used framework so that we are not fighting an uphill battle with our own framework over code guidelines.
Also what checkstyle guidelines are you using currently phpmyadmin or cakephp.
Currently it's using CakePHP style.
... you can actually see or change this in build.xml
who has commit access to the repo other than you? I was wondering if you could add one or both my mentors on this list so that they can accept my pull requests.
Any phpMyAdmin developer should have access, so they should be able to do that (in case it does not work, I've done something wrong and please let me know).
Sounds about right :)
Bye, Rouslan
-
Michal Čihař -
Mohamed Ashraf -
Rouslan Placella