Notice in ./main.php#171 Undefined variable: charset
Notice in ./main.php#172 Undefined variable: charset
Rouslan Placella a écrit :
On Fri, 2011-06-03 at 08:22 -0400, Marc Delisle wrote:
Notice in ./main.php#171 Undefined variable: charset
Notice in ./main.php#172 Undefined variable: charset
Was this message meant to be sent to Piotr only?
No :)
Hi
Dne Fri, 03 Jun 2011 13:54:21 +0100 Rouslan Placella rouslan@placella.com napsal(a):
On Fri, 2011-06-03 at 08:22 -0400, Marc Delisle wrote:
Notice in ./main.php#171 Undefined variable: charset
Notice in ./main.php#172 Undefined variable: charset
Was this message meant to be sent to Piotr only?
Probably to me rather :-). Fixed in git.
Michal Čihař a écrit :
Hi
Dne Fri, 03 Jun 2011 13:54:21 +0100 Rouslan Placella rouslan@placella.com napsal(a):
On Fri, 2011-06-03 at 08:22 -0400, Marc Delisle wrote:
Notice in ./main.php#171 Undefined variable: charset
Notice in ./main.php#172 Undefined variable: charset
Was this message meant to be sent to Piotr only?
Probably to me rather :-). Fixed in git.
Yes; so the trend is to hardcode 'utf-8' instead of this old variable?
Hi
Dne Fri, 03 Jun 2011 09:41:49 -0400 Marc Delisle marc@infomarc.info napsal(a):
Michal Čihař a écrit :
Hi
Dne Fri, 03 Jun 2011 13:54:21 +0100 Rouslan Placella rouslan@placella.com napsal(a):
On Fri, 2011-06-03 at 08:22 -0400, Marc Delisle wrote:
Notice in ./main.php#171 Undefined variable: charset
Notice in ./main.php#172 Undefined variable: charset
Was this message meant to be sent to Piotr only?
Probably to me rather :-). Fixed in git.
Yes; so the trend is to hardcode 'utf-8' instead of this old variable?
Well it was anyway sort of hardcoded in most places for long time (translations, MySQL connection). This was relict from time when we offered all translations in several encodings. So I don't see need to have variable always holding 'utf-8' :-).
Michal Čihař a écrit :
Hi
Dne Fri, 03 Jun 2011 09:41:49 -0400 Marc Delisle marc@infomarc.info napsal(a):
Michal Čihař a écrit :
Hi
Dne Fri, 03 Jun 2011 13:54:21 +0100 Rouslan Placella rouslan@placella.com napsal(a):
On Fri, 2011-06-03 at 08:22 -0400, Marc Delisle wrote:
Notice in ./main.php#171 Undefined variable: charset
Notice in ./main.php#172 Undefined variable: charset
Was this message meant to be sent to Piotr only?
Probably to me rather :-). Fixed in git.
Yes; so the trend is to hardcode 'utf-8' instead of this old variable?
Well it was anyway sort of hardcoded in most places for long time (translations, MySQL connection). This was relict from time when we offered all translations in several encodings. So I don't see need to have variable always holding 'utf-8' :-).
I was thinking about having a constant. Not sure that we'll ever need to change this, however.
Hi
Dne Fri, 03 Jun 2011 09:48:07 -0400 Marc Delisle marc@infomarc.info napsal(a):
I was thinking about having a constant. Not sure that we'll ever need to change this, however.
If there ever will be a need, grepping for utf-8 is quite easy (as opposed to $GLOBALS['charset'] and sometimes global and sometimes local $charset :-).
2011/6/3 Michal Čihař michal@cihar.com:
Hi
Dne Fri, 03 Jun 2011 09:48:07 -0400 Marc Delisle marc@infomarc.info napsal(a):
I was thinking about having a constant. Not sure that we'll ever need to change this, however.
If there ever will be a need, grepping for utf-8 is quite easy (as opposed to $GLOBALS['charset'] and sometimes global and sometimes local $charset :-).
A constant would be CHARSET (or PMA_CHARSET), no need to put it in a global. ;)
Kind regards,
Dieter
-
Dieter Adriaenssens -
Marc Delisle -
Michal Čihař -
Rouslan Placella