Hi Piotr,
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
2011/5/31 Dieter Adriaenssens dieter.adriaenssens@gmail.com:
Hi Piotr,
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Ok, changed to `Server'.
2011/5/31 Piotr Przybylski piotr.prz@gmail.com:
2011/5/31 Dieter Adriaenssens dieter.adriaenssens@gmail.com:
Hi Piotr,
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Ok, changed to `Server'.
Looks good.
I noticed that the '?' icon next to 'Server connection collation' links to the MySQL documentation. This should point to the Drizzle documenation, to avoid confusion. But I guess there are a whole lot more links to MySQL documentation that should point to Drizzle documentation. Did you put it in your planning to change the documentation links?
Kind regards,
Dieter
-- Piotr Przybylski
Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2011/6/2 Dieter Adriaenssens dieter.adriaenssens@gmail.com:
2011/5/31 Piotr Przybylski piotr.prz@gmail.com:
2011/5/31 Dieter Adriaenssens dieter.adriaenssens@gmail.com:
Hi Piotr,
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Ok, changed to `Server'.
Looks good.
I noticed that the '?' icon next to 'Server connection collation' links to the MySQL documentation. This should point to the Drizzle documenation, to avoid confusion. But I guess there are a whole lot more links to MySQL documentation that should point to Drizzle documentation. Did you put it in your planning to change the documentation links?
No, it's something that should be done at the end of GSoS, provided that Drizzle documentation becomes usable at that point. Right now it's far from complete and contains some obsolete information. I saw on their mailing list that there are plans to improve it, we can only hope it happens soon enough.
Hi
Dne Tue, 31 May 2011 19:08:12 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Also please consider that we can be connected to MariaDB server, so the naming should either include it as well or be server neutral.
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Tue, 31 May 2011 19:08:12 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Also please consider that we can be connected to MariaDB server, so the naming should either include it as well or be server neutral.
Then we have two options for I the conditional MySQL/Drizzle header: 1) change it to 'Database server', add some information on server type in frame 2) add another case: MariaDB
Both solutions require some form of detecting whether we are working with plain MySQL or with MariaDB.
Hi
Dne Thu, 2 Jun 2011 15:30:48 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Tue, 31 May 2011 19:08:12 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Also please consider that we can be connected to MariaDB server, so the naming should either include it as well or be server neutral.
Then we have two options for I the conditional MySQL/Drizzle header:
- change it to 'Database server', add some information on server type in frame
I think this is better option, adding server type next to server version (anyway MySQL version 2011.03.13 sounds crazy).
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Thu, 2 Jun 2011 15:30:48 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Tue, 31 May 2011 19:08:12 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Also please consider that we can be connected to MariaDB server, so the naming should either include it as well or be server neutral.
Then we have two options for I the conditional MySQL/Drizzle header:
- change it to 'Database server', add some information on server type in frame
I think this is better option, adding server type next to server version (anyway MySQL version 2011.03.13 sounds crazy).
I included MariaDB in texts, you can see this change on demo server [1].
[1] http://demo.phpmyadmin.net/gsoc-piotr/
2011/6/2 Piotr Przybylski piotr.prz@gmail.com:
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Thu, 2 Jun 2011 15:30:48 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Tue, 31 May 2011 19:08:12 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Also please consider that we can be connected to MariaDB server, so the naming should either include it as well or be server neutral.
Then we have two options for I the conditional MySQL/Drizzle header:
- change it to 'Database server', add some information on server type in frame
I think this is better option, adding server type next to server version (anyway MySQL version 2011.03.13 sounds crazy).
I included MariaDB in texts, you can see this change on demo server [1].
You implemented option 2. ;)
I think it's better to have 'Database server' as header and then a 'Server type :' field with the kind of server. This is more consistent with the 'Web server' section below.
Kind regards,
Dieter
[1] http://demo.phpmyadmin.net/gsoc-piotr/
-- Piotr Przybylski
Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
W dniu 3 czerwca 2011 11:25 użytkownik Dieter Adriaenssens dieter.adriaenssens@gmail.com napisał:
2011/6/2 Piotr Przybylski piotr.prz@gmail.com:
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Thu, 2 Jun 2011 15:30:48 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Tue, 31 May 2011 19:08:12 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Also please consider that we can be connected to MariaDB server, so the naming should either include it as well or be server neutral.
Then we have two options for I the conditional MySQL/Drizzle header:
- change it to 'Database server', add some information on server type in frame
I think this is better option, adding server type next to server version (anyway MySQL version 2011.03.13 sounds crazy).
I included MariaDB in texts, you can see this change on demo server [1].
You implemented option 2. ;)
I think it's better to have 'Database server' as header and then a 'Server type :' field with the kind of server. This is more consistent with the 'Web server' section below.
Done
-
Dieter Adriaenssens -
Michal Čihař -
Piotr Przybylski