[Phpmyadmin-devel] move getStringWidth to common library
Hi, After refactoring the getStringWidth() method in the PMA_SVG, I found out this method exists in the PMA_EPS class as well and is identical. I suggest to move this method to a library file, both classes can statically call this method from there. (The method does not use any internal variables of the class so this is possible). Objections? -- Kind regards, Dieter Adriaenssens
Dieter Adriaenssens a écrit :
Hi,
After refactoring the getStringWidth() method in the PMA_SVG, I found out this method exists in the PMA_EPS class as well and is identical.
I suggest to move this method to a library file, both classes can statically call this method from there. (The method does not use any internal variables of the class so this is possible).
Objections?
Good idea. -- Marc Delisle http://infomarc.info
2013/9/27 Marc Delisle <marc@infomarc.info>:
Dieter Adriaenssens a écrit :
Hi,
After refactoring the getStringWidth() method in the PMA_SVG, I found out this method exists in the PMA_EPS class as well and is identical.
I suggest to move this method to a library file, both classes can statically call this method from there. (The method does not use any internal variables of the class so this is possible).
Objections?
Good idea.
Done in pull request : https://github.com/phpmyadmin/phpmyadmin/pull/719 Please review. Kind regards, Dieter
participants (2)
-
Dieter Adriaenssens -
Marc Delisle