[Phpmyadmin-devel] Plugins and OOP

Hi everyone, I have implemented a good deal of the object oriented plugins system. All of the plugins can be found in the /libraries/plugins/ folder in my git repo [1]. There are two important things that are missing right now: - The update() methods in the Observer pattern. - Serious testing. I think that my code is safe to be merged now. There are probably still a few bugs left, but more people having them will pop them out faster. I hope there are not so many, though. And I also believe that new development can be done over my classes without problems. What do you think? Also, I was thinking that, maybe, Yasitha, is there any way you can work with me and integrate some tests for the import, export, transformations and auth plugins with your GSoC project? And, of course, any suggestions are welcome. [1] https://github.com/alexukf/phpmyadmin/tree/plugins-and-OOP -- Alex

Hi Dne Sat, 23 Jun 2012 01:11:45 +0300 Alex Marin <alex.ukf@gmail.com> napsal(a):
I have implemented a good deal of the object oriented plugins system. All of the plugins can be found in the /libraries/plugins/ folder in my git repo [1]. There are two important things that are missing right now: - The update() methods in the Observer pattern. - Serious testing.
I think that my code is safe to be merged now. There are probably still a few bugs left, but more people having them will pop them out faster. I hope there are not so many, though. And I also believe that new development can be done over my classes without problems. What do you think?
Actually I was thinking about merging it, but it does not merge without conflicts. Can you please look at it? -- Michal Čihař | http://cihar.com | http://blog.cihar.com

Hi Michal, On Mon, Jun 25, 2012 at 12:07 PM, Michal Čihař <michal@cihar.com> wrote:
Actually I was thinking about merging it, but it does not merge without conflicts. Can you please look at it?
I have merged the current master into my branch, and it should be safe now. -- Alex

Hi Dne Thu, 28 Jun 2012 07:21:21 +0300 Alex Marin <alex.ukf@gmail.com> napsal(a):
Hi Michal,
On Mon, Jun 25, 2012 at 12:07 PM, Michal Čihař <michal@cihar.com> wrote:
Actually I was thinking about merging it, but it does not merge without conflicts. Can you please look at it?
I have merged the current master into my branch, and it should be safe now.
Okay, let's break master :-). Your code has been just merged. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

On Thu, Jun 28, 2012 at 8:56 AM, Michal Čihař <michal@cihar.com> wrote:
Okay, let's break master :-). Your code has been just merged.
Nuclear launch detected [1] :) [1] http://desmond.imageshack.us/Himg138/scaled.php?server=138&filename=osca2mk2... -- Alex
participants (2)
-
Alex Marin
-
Michal Čihař