[Phpmyadmin-devel] Recent tables list doesn't honor current server
Hi, I just noticed - when I change servers on demo server (eg. MySQL -> MariaDB) and select a recent table that's only in MySQL, I am redirected to table list with no database selected and no tables, and then to proper database list. It should change servers and show this table, or not show any tables from other servers (work per server). -- Regards, Piotr Przybylski
On 17 Jun 2011, at 02:22, Piotr Przybylski <piotr.prz@gmail.com> wrote:
Hi,
I just noticed - when I change servers on demo server (eg. MySQL -> MariaDB) and select a recent table that's only in MySQL, I am redirected to table list with no database selected and no tables, and then to proper database list. It should change servers and show this table, or not show any tables from other servers (work per server).
Hi Piotr, You are right. I will work on this. Also, I've just checked, some other features, for example tracking feature, also doesn't honor current server. If user have same db and table name in different server, tracking will considered both as one db and table. Is this behavior expected? -- Aris Feryanto
Hi Dne Fri, 17 Jun 2011 08:10:03 +0700 Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
Also, I've just checked, some other features, for example tracking feature, also doesn't honor current server. If user have same db and table name in different server, tracking will considered both as one db and table. Is this behavior expected?
As tracking is configured per server, this is clearly a bug. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
2011/6/17 Michal Čihař <michal@cihar.com>:
Hi
Dne Fri, 17 Jun 2011 08:10:03 +0700 Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
Also, I've just checked, some other features, for example tracking feature, also doesn't honor current server. If user have same db and table name in different server, tracking will considered both as one db and table. Is this behavior expected?
As tracking is configured per server, this is clearly a bug.
I wonder how this should be fixed - by storing server id from config (and risking difficult to detect conflicts when config is changed), or by stating that tracking and recent tables need to have different table for each server (and making installation more difficult). -- Piotr Przybylski
2011/6/17 Piotr Przybylski <piotr.prz@gmail.com>:
2011/6/17 Michal Čihař <michal@cihar.com>:
Hi
Dne Fri, 17 Jun 2011 08:10:03 +0700 Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
Also, I've just checked, some other features, for example tracking feature, also doesn't honor current server. If user have same db and table name in different server, tracking will considered both as one db and table. Is this behavior expected?
As tracking is configured per server, this is clearly a bug.
I wonder how this should be fixed - by storing server id from config (and risking difficult to detect conflicts when config is changed), or by stating that tracking and recent tables need to have different table for each server (and making installation more difficult).
hostname/connection string?
-- Piotr Przybylski
------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Groetjes, Dieter Adriaenssens
W dniu 18 czerwca 2011 13:31 użytkownik Dieter Adriaenssens <dieter.adriaenssens@gmail.com> napisał:
2011/6/17 Piotr Przybylski <piotr.prz@gmail.com>:
2011/6/17 Michal Čihař <michal@cihar.com>:
Hi
Dne Fri, 17 Jun 2011 08:10:03 +0700 Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
Also, I've just checked, some other features, for example tracking feature, also doesn't honor current server. If user have same db and table name in different server, tracking will considered both as one db and table. Is this behavior expected?
As tracking is configured per server, this is clearly a bug.
I wonder how this should be fixed - by storing server id from config (and risking difficult to detect conflicts when config is changed), or by stating that tracking and recent tables need to have different table for each server (and making installation more difficult).
hostname/connection string?
Yes, connection string would work. -- Piotr Przybylski
----- Original Message -----
From: Piotr Przybylski <piotr.prz@gmail.com>
W dniu 18 czerwca 2011 13:31 użytkownik Dieter Adriaenssens <dieter.adriaenssens@gmail.com> napisał:
2011/6/17 Piotr Przybylski <piotr.prz@gmail.com>:
2011/6/17 Michal Čihař <michal@cihar.com>:
Hi
Dne Fri, 17 Jun 2011 08:10:03 +0700 Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
Also, I've just checked, some other features, for example tracking feature, also doesn't honor current server. If user have same db and table name in different server, tracking will considered both as one db and table. Is this behavior expected?
As tracking is configured per server, this is clearly a bug.
I wonder how this should be fixed - by storing server id from config (and risking difficult to detect conflicts when config is changed), or by stating that tracking and recent tables need to have different table for each server (and making installation more difficult).
hostname/connection string?
Yes, connection string would work.
Yes, I think hostname/connection string is the best choice. I'll try to apply this for recent tables first. -- Aris Feryanto
Hi, ----- Original Message -----
From: Piotr Przybylski <piotr.prz@gmail.com>
W dniu 18 czerwca 2011 13:31 użytkownik Dieter Adriaenssens <dieter.adriaenssens@gmail.com> napisał:
2011/6/17 Piotr Przybylski <piotr.prz@gmail.com>:
2011/6/17 Michal Čihař <michal@cihar.com>:
Hi
Dne Fri, 17 Jun 2011 08:10:03 +0700 Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
Also, I've just checked, some other features, for example tracking feature, also doesn't honor current server. If user have same db and table name in different server, tracking will considered both as one db and table. Is this behavior expected?
As tracking is configured per server, this is clearly a bug.
Silly me. Sorry for wrong report above. I was not clear about this before. In my test for tracking feature, I used same cloned server in my localhost. So, there is no bug for tracking.
I wonder how this should be fixed - by storing server id from config (and risking difficult to detect conflicts when config is changed), or by stating that tracking and recent tables need to have different table for each server (and making installation more difficult).
hostname/connection string?
Yes, connection string would work.
I've fixed this in my git (commit 6e65d3d7fc04653be59e133acfe5f10f5eb6cbc5). Marc, could you please merge this in official master branch? Thanks. -- Aris Feryanto
Aris Feryanto a écrit :
Hi,
----- Original Message -----
From: Piotr Przybylski <piotr.prz@gmail.com>
W dniu 18 czerwca 2011 13:31 użytkownik Dieter Adriaenssens <dieter.adriaenssens@gmail.com> napisał:
2011/6/17 Piotr Przybylski <piotr.prz@gmail.com>:
2011/6/17 Michal Čihař <michal@cihar.com>:
Hi
Dne Fri, 17 Jun 2011 08:10:03 +0700 Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
Also, I've just checked, some other features, for example tracking feature, also doesn't honor current server. If user have same db and table name in different server, tracking will considered both as one db and table. Is this behavior expected? As tracking is configured per server, this is clearly a bug.
Silly me. Sorry for wrong report above. I was not clear about this before. In my test for tracking feature, I used same cloned server in my localhost. So, there is no bug for tracking.
I wonder how this should be fixed - by storing server id from config (and risking difficult to detect conflicts when config is changed), or by stating that tracking and recent tables need to have different table for each server (and making installation more difficult). hostname/connection string?
Yes, connection string would work.
I've fixed this in my git (commit 6e65d3d7fc04653be59e133acfe5f10f5eb6cbc5). Marc, could you please merge this in official master branch? Thanks.
Aris, I merged commit ede177c577668a712e0d89a8c895c1d0c200f42f because there seemed to have more recent fixes in your repo. I hope this is fine. -- Marc Delisle http://infomarc.info
On 21 Jun 2011, at 19:16, Marc Delisle <marc@infomarc.info> wrote:
Aris Feryanto a écrit :
Hi,
----- Original Message -----
From: Piotr Przybylski <piotr.prz@gmail.com>
W dniu 18 czerwca 2011 13:31 użytkownik Dieter Adriaenssens <dieter.adriaenssens@gmail.com> napisał:
2011/6/17 Piotr Przybylski <piotr.prz@gmail.com>:
2011/6/17 Michal Čihař <michal@cihar.com>:
Hi
Dne Fri, 17 Jun 2011 08:10:03 +0700 Aris Feryanto <aris_feryanto@yahoo.com> napsal(a):
> Also, I've just checked, some other features, for example tracking feature, also doesn't honor current server. If user have same db and table name in different server, tracking will considered both as one db and table. Is this behavior expected? As tracking is configured per server, this is clearly a bug.
Silly me. Sorry for wrong report above. I was not clear about this before. In my test for tracking feature, I used same cloned server in my localhost. So, there is no bug for tracking.
I wonder how this should be fixed - by storing server id from config (and risking difficult to detect conflicts when config is changed), or by stating that tracking and recent tables need to have different table for each server (and making installation more difficult). hostname/connection string?
Yes, connection string would work.
I've fixed this in my git (commit 6e65d3d7fc04653be59e133acfe5f10f5eb6cbc5). Marc, could you please merge this in official master branch? Thanks.
Aris, I merged commit ede177c577668a712e0d89a8c895c1d0c200f42f because there seemed to have more recent fixes in your repo. I hope this is fine.
Thanks, Marc. Yes, that commit is the most recent fix. I haven't mailed about that because I want to test it in the demo server first. I've just tested and it works well, so it's okay to be merged. -- Aris Feryanto
participants (5)
-
Aris Feryanto -
Dieter Adriaenssens -
Marc Delisle -
Michal Čihař -
Piotr Przybylski