[Phpmyadmin-devel] QueryFrame -> QueryWindow
Hi, i would like to replace $cfg QueryFrame und QueryFrameJS by QueryWindow - allways display SQL icon in left frame QueryWindow = true - always opens the QueryWindow (from left frame and from 'edit sql' in sql tab) QueryWindow = false or not js capable browser - always opens sql tab QueryWindow = 'left' or 'onlyleft' or ? - from query icon in left frame opens QueryWindow - from 'edit sql' in sql tab open query in sql tab with last default beeing default -- Sebastian Mendel www.sebastianmendel.de www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
Sebastian Mendel a écrit :
Hi,
i would like to replace $cfg QueryFrame und QueryFrameJS by QueryWindow
- allways display SQL icon in left frame
OK for me.
QueryWindow = true
- always opens the QueryWindow (from left frame and from 'edit sql' in sql tab)
QueryWindow = false or not js capable browser
- always opens sql tab
QueryWindow = 'left' or 'onlyleft' or ?
- from query icon in left frame opens QueryWindow - from 'edit sql' in sql tab open query in sql tab
with last default beeing default
I think that when js-capable, this icon should always open a distinct window, so no need for true/false. So the choices could be onlyleft: querywindow opens only when clicking the icon in left panel all: querywindow opens when clicking the icon in left panel or any SQL tab P.S. Please have a look at the bug tracker, about "query window functionality". Marc
Marc Delisle wrote: > Sebastian Mendel a écrit : >> Hi, >> >> i would like to replace $cfg QueryFrame und QueryFrameJS by QueryWindow >> >> - allways display SQL icon in left frame >> >> >> QueryWindow = true = 'all' >> - always opens the QueryWindow (from left frame and from 'edit sql' >> in sql tab) - additional 'edit here' link open querybox in sql tab >> QueryWindow = false or not js capable browser = 'never' >> - always opens sql tab >> >> >> QueryWindow = 'left' or 'onlyleft' or ? = 'onlyleft' - querywindow opens only when clicking the icon in left panel - additonally 'edit in querywindow' opens in querywindow ??? >> with last default beeing default > > I think that when js-capable, this icon should always open a distinct > window, so no need for true/false. So the choices could be but not every user having a js capable browser likes the querywindow ... > P.S. Please have a look at the bug tracker, about "query window > functionality". yes, i have this in mind ... -- Sebastian Mendel www.sebastianmendel.de www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
Sebastian Mendel a écrit :
Marc Delisle wrote:
Sebastian Mendel a écrit :
Hi,
i would like to replace $cfg QueryFrame und QueryFrameJS by QueryWindow
- allways display SQL icon in left frame
QueryWindow = true
= 'all'
- always opens the QueryWindow (from left frame and from 'edit sql' in sql tab)
- additional 'edit here' link open querybox in sql tab
QueryWindow = false or not js capable browser
= 'never'
- always opens sql tab
QueryWindow = 'left' or 'onlyleft' or ?
= 'onlyleft'
- querywindow opens only when clicking the icon in left panel - additonally 'edit in querywindow' opens in querywindow ???
with last default beeing default
I think that when js-capable, this icon should always open a distinct window, so no need for true/false. So the choices could be
but not every user having a js capable browser likes the querywindow ...
I understand. Please note that I react to this question as a maintainer of a multi-user installation. Of the hundreds of users executing from the same directory, some will like a distinct query window, some won't, so I cannot please everyone. This is clearly a case where db-based user preferences would be useful. Anyway, we can offer this choice of options: - never - onlyleft - all But now, which one will be the default? :) I would say "all". Note that if a sysadmin uses "never", maybe he won't please all his community of users... This is why I wanted to avoid this choice. A user who does not like the distinct query window would click the SQL tab instead. Marc
Hi On Mon 17. 10. 2005 13:59, Sebastian Mendel wrote:
i would like to replace $cfg QueryFrame und QueryFrameJS by QueryWindow
- allways display SQL icon in left frame
and make it allways open SQL window if possible (javascript enabled).
QueryWindow = true
- always opens the QueryWindow (from left frame and from 'edit sql' in sql tab)
QueryWindow = false or not js capable browser
- always opens sql tab
QueryWindow = 'left' or 'onlyleft' or ?
- from query icon in left frame opens QueryWindow - from 'edit sql' in sql tab open query in sql tab
with last default beeing default
And add EditInWindow (or something like this) that will modify edit link behaviour. -- Michal Čihař | http://cihar.com
participants (3)
-
Marc Delisle -
Michal Čihař -
Sebastian Mendel