[Phpmyadmin-devel] Regarding Bug #4302
Hi, Refreshing the Table Export page causes this bug. After looking at the code I got that the bug is due to the missing of this parameter '$_REQUEST['single_table']' in the display_export.inc.php The only way to fix it is (as I suppose) to append the single_table='true' in the url when the users first come to the Table Export page. my doubts are : 1. Does it even counted as a bug ? (in case if we don't expect the user to refresh the page) 2. Is editing the URL ok ? or if you have some other solution in your mind please do tell. Thanks. Regards, Umair Khan
Le 2014-02-28 09:42, Omer Jer a écrit :
Hi, Refreshing the Table Export page causes this bug. After looking at the code I got that the bug is due to the missing of this parameter '$_REQUEST['single_table']' in the display_export.inc.php
The only way to fix it is (as I suppose) to append the single_table='true' in the url when the users first come to the Table Export page.
But single_table is already set to true on the table Export menu link.
my doubts are : 1. Does it even counted as a bug ? (in case if we don't expect the user to refresh the page)
Yes it counts as a minor bug
2. Is editing the URL ok ? or if you have some other solution in your mind please do tell.
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
Hi, 2014-03-01 12:49 GMT+01:00 Marc Delisle <marc@infomarc.info>:
Le 2014-02-28 09:42, Omer Jer a écrit :
Hi, Refreshing the Table Export page causes this bug. After looking at the code I got that the bug is due to the missing of this parameter '$_REQUEST['single_table']' in the display_export.inc.php
The only way to fix it is (as I suppose) to append the single_table='true' in the url when the users first come to the Table Export page.
But single_table is already set to true on the table Export menu link.
But the fact is that he seems to be right... After refreshing the page, the single_table input is no longer in the form... His fix is working for me.
my doubts are : 1. Does it even counted as a bug ? (in case if we don't expect the user to refresh the page)
Yes it counts as a minor bug
2. Is editing the URL ok ? or if you have some other solution in your mind please do tell.
Hugues.
Le 2014-03-01 07:01, Hugues Peccatte a écrit :
Hi,
2014-03-01 12:49 GMT+01:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>>:
Le 2014-02-28 09:42, Omer Jer a écrit : > Hi, > Refreshing the Table Export page causes this bug. > After looking at the code I got that the bug is due to the missing of > this parameter '$_REQUEST['single_table']' in the display_export.inc.php > > The only way to fix it is (as I suppose) to append the > single_table='true' in the url when the users first come to the Table > Export page.
But single_table is already set to true on the table Export menu link.
But the fact is that he seems to be right… After refreshing the page, the single_table input is no longer in the form… His fix is working for me.
Thanks. Feel free to merge it then.
> my doubts are : > 1. Does it even counted as a bug ? (in case if we don't expect the user > to refresh the page)
Yes it counts as a minor bug
> 2. Is editing the URL ok ? or if you have some other solution in your > mind please do tell.
Hugues.
------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
2014-03-01 13:03 GMT+01:00 Marc Delisle <marc@infomarc.info>:
Le 2014-03-01 07:01, Hugues Peccatte a écrit :
Hi,
2014-03-01 12:49 GMT+01:00 Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>>:
Le 2014-02-28 09:42, Omer Jer a écrit : > Hi, > Refreshing the Table Export page causes this bug. > After looking at the code I got that the bug is due to the missing of > this parameter '$_REQUEST['single_table']' in the display_export.inc.php > > The only way to fix it is (as I suppose) to append the > single_table='true' in the url when the users first come to the Table > Export page.
But single_table is already set to true on the table Export menu link.
But the fact is that he seems to be right... After refreshing the page, the single_table input is no longer in the form... His fix is working for me.
Thanks. Feel free to merge it then.
There is one thing that I can't evaluate. That's the impact on the whole project because the fix is in a common function... And I don't know how to be sure about this...
> my doubts are : > 1. Does it even counted as a bug ? (in case if we don't expect the user > to refresh the page)
Yes it counts as a minor bug
> 2. Is editing the URL ok ? or if you have some other solution in
your
> mind please do tell.
Hugues.
On 3/1/14, Hugues Peccatte <hugues.peccatte@gmail.com> wrote:
Hi,
2014-03-01 12:49 GMT+01:00 Marc Delisle <marc@infomarc.info>:
Le 2014-02-28 09:42, Omer Jer a écrit :
Hi, Refreshing the Table Export page causes this bug. After looking at the code I got that the bug is due to the missing of this parameter '$_REQUEST['single_table']' in the display_export.inc.php
The only way to fix it is (as I suppose) to append the single_table='true' in the url when the users first come to the Table Export page.
But single_table is already set to true on the table Export menu link.
But the fact is that he seems to be right... After refreshing the page, the single_table input is no longer in the form... His fix is working for me.
It is a class of bugs, whenever a parameter is omitted from being added to selflink in microhistory, and we refresh. I commented on a related fix by J.M. at [0] Alternative solution to what is mentioned in the comment: we could consider adding an if condition for each possible param after looking for the param names in [1] (look for ['args']['....']), as is already done for 'viewing_mode' in [0]. [0] https://github.com/phpmyadmin/phpmyadmin/compare/dfd6881929...49d60e0dd5 [1] https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/Menu.class.ph... Thanks & Regards -- Atul Pratap Singh http://blog.atulsisodia.in/
On 3/2/14, Atul Pratap Singh <atulpratapsingh05@gmail.com> wrote:
On 3/1/14, Hugues Peccatte <hugues.peccatte@gmail.com> wrote:
Hi,
2014-03-01 12:49 GMT+01:00 Marc Delisle <marc@infomarc.info>:
Le 2014-02-28 09:42, Omer Jer a écrit :
Hi, Refreshing the Table Export page causes this bug. After looking at the code I got that the bug is due to the missing of this parameter '$_REQUEST['single_table']' in the display_export.inc.php
The only way to fix it is (as I suppose) to append the single_table='true' in the url when the users first come to the Table Export page.
But single_table is already set to true on the table Export menu link.
But the fact is that he seems to be right... After refreshing the page, the single_table input is no longer in the form... His fix is working for me.
It is a class of bugs, whenever a parameter is omitted from being added to selflink in microhistory, and we refresh. I commented on a related fix by J.M. at [0]
Alternative solution to what is mentioned in the comment: we could consider adding an if condition for each possible param after looking for the param names in [1] (look for ['args']['....']), as is already done for 'viewing_mode' in [0].
Done in https://github.com/phpmyadmin/phpmyadmin/commit/15539d4d7df53ef8546497e05805... Regards -- Atul Pratap Singh http://blog.atulsisodia.in/
participants (4)
-
Atul Pratap Singh -
Hugues Peccatte -
Marc Delisle -
Omer Jer