20 Jul
2011
20 Jul
'11
4:25 p.m.
Michal,
the idea of CSS overrides, as discussed on this list, was to avoid a
problem with future upgrades of jQuery UI inside phpMyAdmin.
--
Marc Delisle
http://infomarc.info
21 Jul
21 Jul
10:19 a.m.
Hi
Dne Wed, 20 Jul 2011 09:25:25 -0400
Marc Delisle <marc(a)infomarc.info> napsal(a):
the idea of CSS overrides, as discussed on this list,
was to avoid a
problem with future upgrades of jQuery UI inside phpMyAdmin.
The cost for that being extra request on every page. It would make more
sense to add anything what needs to be overridden into regular CSS if
we really want to avoid changes in jQuery CSS. Maybe even jQuery CSS
should not be part of theme and theme should only override things it
wants different from the defaults?
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
11:08 a.m.
On Thu, Jul 21, 2011 at 10:19 AM, Michal Čihař <michal(a)cihar.com> wrote:
Hi
Dne Wed, 20 Jul 2011 09:25:25 -0400
Marc Delisle <marc(a)infomarc.info> napsal(a):
I fully agree with that. Sounds actually like a good idea to put the
jQuery UI CSS Overrides into theme_right.css.php.
Alternatively, the css could still be a seperate file, but included
server side by theme_right.css.php.
the idea of CSS overrides, as discussed on this
list, was to avoid a
problem with future upgrades of jQuery UI inside phpMyAdmin.
The cost for that being extra request on every page. It would make more
sense to add anything what needs to be overridden into regular CSS if
we really want to avoid changes in jQuery CSS. Maybe even jQuery CSS
should not be part of theme and theme should only override things it
wants different from the defaults?
I would suggest to still leave it theme specific. Since you can build
together jquery ui themes on http://jqueryui.com/themeroller/, a
person building a new theme might want to completely change the style
of jquery ui css and he can do so easily since there is (currently) no
overrides.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------
5 Ways to Improve & Secure Unified Communications
Unified Communications promises greater efficiencies for business. UC can
improve internal communications as well as offer faster, more efficient ways
to interact with customers and streamline customer service. Learn more!
http://www.accelacomm.com/jaw/sfnl/114/51426253/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2:24 p.m.
Hi
Dne Thu, 21 Jul 2011 11:08:00 +0300
Tyron Madlener <tyronx(a)gmail.com> napsal(a):
On Thu, Jul 21, 2011 at 10:19 AM, Michal Čihař
<michal(a)cihar.com> wrote:
And at least you can configure font size there, so only our custom
modification would be timepicker thing, which should probably really go
to theme_right, I will move it there.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi
Dne Wed, 20 Jul 2011 09:25:25 -0400
Marc Delisle <marc(a)infomarc.info> napsal(a):
I fully agree with that. Sounds actually like a good idea to put the
jQuery UI CSS Overrides into theme_right.css.php.
Alternatively, the css could still be a seperate file, but included
server side by theme_right.css.php.
the idea of CSS overrides, as discussed on this
list, was to avoid a
problem with future upgrades of jQuery UI inside phpMyAdmin.
The cost for that being extra request on every page. It would make more
sense to add anything what needs to be overridden into regular CSS if
we really want to avoid changes in jQuery CSS. Maybe even jQuery CSS
should not be part of theme and theme should only override things it
wants different from the defaults?
I would suggest to still leave it theme specific. Since you can build
together jquery ui themes on http://jqueryui.com/themeroller/, a
person building a new theme might want to completely change the style
of jquery ui css and he can do so easily since there is (currently) no
overrides.
3:03 p.m.
I keep pressing the wrong reply button >.<
On Thu, Jul 21, 2011 at 2:24 PM, Michal Čihař <michal(a)cihar.com> wrote:
Hi
Dne Thu, 21 Jul 2011 11:08:00 +0300
Tyron Madlener <tyronx(a)gmail.com> napsal(a):
Actually we have a bunch of changes but they are not in the overrides
file, they are in the original theme file:
http://repo.or.cz/w/phpmyadmin/tyronm.git/history/HEAD:/themes/pmahomme/jqu…
And the timepicker z-index thing in return is not required anymore. It
was an attempted fix for timepicker appearing behind dialogs by Aris,
but it doesn't work e.g. on multiple dialogs. I have fixed that with
commit 67ec8263dbfd9f39c25bec5350f4618f5c14e001 which should be merged
to master already. Aris and me have discussed it on this mailing list
just a few days ago.
On Thu, Jul 21, 2011 at 10:19 AM, Michal Čihař
<michal(a)cihar.com> wrote:
And at least you can configure font size there, so only our custom
modification would be timepicker thing, which should probably really go
to theme_right, I will move it there.
Hi
Dne Wed, 20 Jul 2011 09:25:25 -0400
Marc Delisle <marc(a)infomarc.info> napsal(a):
I fully agree with that. Sounds actually like a good idea to put the
jQuery UI CSS Overrides into theme_right.css.php.
Alternatively, the css could still be a seperate file, but included
server side by theme_right.css.php.
the idea of CSS overrides, as discussed on this
list, was to avoid a
problem with future upgrades of jQuery UI inside phpMyAdmin.
The cost for that being extra request on every page. It would make more
sense to add anything what needs to be overridden into regular CSS if
we really want to avoid changes in jQuery CSS. Maybe even jQuery CSS
should not be part of theme and theme should only override things it
wants different from the defaults?
I would suggest to still leave it theme specific. Since you can build
together jquery ui themes on http://jqueryui.com/themeroller/, a
person building a new theme might want to completely change the style
of jquery ui css and he can do so easily since there is (currently) no
overrides. --
Michal Čihař | http://cihar.com | http://blog.cihar.com
4806
days inactive
4807
days old
4 comments
3 participants
participants (3)
-
Marc Delisle -
Michal Čihař -
Tyron Madlener