I have attached some screenshots [0] of the current implementation of the error report dialog. when an error occurs a small notification appears at the bottom asking the user if he wants to submit an error report. if he does the modal dialog is opened showing him the info that would be sent and asking him for any additional info he might have.
what do you think?
Hi
Dne Tue, 18 Jun 2013 15:22:06 +0200 Mohamed Ashraf mohamed.ashraf.213@gmail.com napsal(a):
I have attached some screenshots [0] of the current implementation of the error report dialog. when an error occurs a small notification appears at the bottom asking the user if he wants to submit an error report. if he does the modal dialog is opened showing him the info that would be sent and asking him for any additional info he might have.
Looks good, maybe it would be better to ask user to describe when this error did happen instead of generic call for extra info?
On Tuesday, June 18, 2013 at 3:47 PM, Michal Čihař wrote:
Hi
Dne Tue, 18 Jun 2013 15:22:06 +0200 Mohamed Ashraf mohamed.ashraf.213@gmail.com napsal(a):
I have attached some screenshots [0] of the current implementation of the error report dialog. when an error occurs a small notification appears at the bottom asking the user if he wants to submit an error report. if he does the modal dialog is opened showing him the info that would be sent and asking him for any additional info he might have.
Looks good, maybe it would be better to ask user to describe when this error did happen instead of generic call for extra info?
The strings are easily changed no problem.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2013/6/18 Mohamed Ashraf mohamed.ashraf.213@gmail.com:
I have attached some screenshots [0] of the current implementation of the error report dialog. when an error occurs a small notification appears at the bottom asking the user if he wants to submit an error report. if he does the modal dialog is opened showing him the info that would be sent and asking him for any additional info he might have.
what do you think?
Looks good.
Only remark is to display the dialog only in the main page, to make it visually compliant with the Warning message.
[0] http://imgur.com/a/IJ7iW/all
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Kind regards,
Dieter Adriaenssens
On Tuesday, June 18, 2013 at 3:59 PM, Dieter Adriaenssens wrote:
2013/6/18 Mohamed Ashraf mohamed.ashraf.213@gmail.com:
I have attached some screenshots [0] of the current implementation of the error report dialog. when an error occurs a small notification appears at the bottom asking the user if he wants to submit an error report. if he does the modal dialog is opened showing him the info that would be sent and asking him for any additional info he might have.
what do you think?
Looks good.
Only remark is to display the dialog only in the main page, to make it visually compliant with the Warning message.
The warning message and the dialog are displayed in the current page regardless of what it is. The screenshots were taken from different pages.
[0] http://imgur.com/a/IJ7iW/all
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Kind regards,
Dieter Adriaenssens
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2013/6/18 Mohamed Ashraf mohamed.ashraf.213@gmail.com:
On Tuesday, June 18, 2013 at 3:59 PM, Dieter Adriaenssens wrote:
2013/6/18 Mohamed Ashraf mohamed.ashraf.213@gmail.com:
I have attached some screenshots [0] of the current implementation of the error report dialog. when an error occurs a small notification appears at the bottom asking the user if he wants to submit an error report. if he does the modal dialog is opened showing him the info that would be sent and asking him for any additional info he might have.
what do you think?
Looks good.
Only remark is to display the dialog only in the main page, to make it visually compliant with the Warning message.
The warning message and the dialog are displayed in the current page regardless of what it is. The screenshots were taken from different pages.
Yes I agree, but I meant, main panel/section. The message should/can be displayed on any page in phpMyAdmin when an JS error occurs. But the message should not overlap the navigation panel.
[0] http://imgur.com/a/IJ7iW/all
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Kind regards,
Dieter Adriaenssens
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Kind regards,
Dieter Adriaenssens
On Tuesday, June 18, 2013 at 4:45 PM, Dieter Adriaenssens wrote:
2013/6/18 Mohamed Ashraf mohamed.ashraf.213@gmail.com:
On Tuesday, June 18, 2013 at 3:59 PM, Dieter Adriaenssens wrote:
2013/6/18 Mohamed Ashraf mohamed.ashraf.213@gmail.com:
I have attached some screenshots [0] of the current implementation of the error report dialog. when an error occurs a small notification appears at the bottom asking the user if he wants to submit an error report. if he does the modal dialog is opened showing him the info that would be sent and asking him for any additional info he might have.
what do you think?
Looks good.
Only remark is to display the dialog only in the main page, to make it visually compliant with the Warning message.
The warning message and the dialog are displayed in the current page regardless of what it is. The screenshots were taken from different pages.
Yes I agree, but I meant, main panel/section. The message should/can be displayed on any page in phpMyAdmin when an JS error occurs. But the message should not overlap the navigation panel.
Ah ok. I just wanted it to be noticed since most likely the page would be in an unusable state after uncaught exception occurs. I will keep the notification from overlapping the navigation panel
[0] http://imgur.com/a/IJ7iW/all
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Kind regards,
Dieter Adriaenssens
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Kind regards,
Dieter Adriaenssens
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel