[Phpmyadmin-devel] Syntax highlighted SQL editor
Hi all as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it. The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-). [1]:http://codemirror.net/ -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Thu, Jun 2, 2011 at 6:45 PM, Michal Čihař <michal@cihar.com> wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
Hi Michal,
This is a great feature that was missing in PMA and glad it has finally been added. It would be even better if we can extend this someday to highlight/underline syntax errors, as we normally get in IDEs. However the editor does not seem to add vertical scrollbars when a lengthy SQL is entered. The SQL falls out of the editor window. Tested with both FF and Chrome. -- Thanks and Regards, Madhura Jayaratne
Hi Dne Thu, 2 Jun 2011 19:26:57 +0530 Madhura Jayaratne <madhura.cj@gmail.com> napsal(a):
This is a great feature that was missing in PMA and glad it has finally been added. It would be even better if we can extend this someday to highlight/underline syntax errors, as we normally get in IDEs.
Yes it is possible with CodeMirror, however we need to get the data to display first :-).
However the editor does not seem to add vertical scrollbars when a lengthy SQL is entered. The SQL falls out of the editor window. Tested with both FF and Chrome.
I've already fixed it in Git, please update :-) (and possibly clear browser cache). -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Thu, Jun 2, 2011 at 3:15 PM, Michal Čihař <michal@cihar.com> wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
Thats nice, is the autocomplete feature disabled? And what does the Clear Button do? It seems to have no effect for me. Also I think the line number could be omitted.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Dne Thu, 2 Jun 2011 16:06:34 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
On Thu, Jun 2, 2011 at 3:15 PM, Michal Čihař <michal@cihar.com> wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
Thats nice, is the autocomplete feature disabled?
Autocompletion needs to be implemented separately.
And what does the Clear Button do? It seems to have no effect for me.
It should work as before - clear the text.
Also I think the line number could be omitted.
I find it useful when I get some error message, though it would be better to directly highlight problematic line. Again something what needs to be implemented. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi Dne Thu, 2 Jun 2011 16:13:21 +0200 Michal Čihař <michal@cihar.com> napsal(a):
Dne Thu, 2 Jun 2011 16:06:34 +0200 Tyron Madlener <tyronx@gmail.com> napsal(a):
And what does the Clear Button do? It seems to have no effect for me.
It should work as before - clear the text.
Ah okay, it is broken for non table based SQL boxes, will fix that. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Thu, 2011-06-02 at 15:15 +0200, Michal Čihař wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
There is a JS problem with codemirror. The error console in my browser says: "textarea is undefined" and many JS features in PMA stop working if you are not on the SQL tab. Rouslan
Rouslan Placella a écrit :
On Thu, 2011-06-02 at 15:15 +0200, Michal Čihař wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
There is a JS problem with codemirror. The error console in my browser says: "textarea is undefined" and many JS features in PMA stop working if you are not on the SQL tab.
Rouslan
I have the same error in FF 4.0.1 / Windows XP. -- Marc Delisle http://infomarc.info
Hi Dne Thu, 02 Jun 2011 15:49:58 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
There is a JS problem with codemirror. The error console in my browser says: "textarea is undefined" and many JS features in PMA stop working if you are not on the SQL tab.
Fixed in git. Thanks for reporting, strange that I did not notice it. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Thu, 2011-06-02 at 15:15 +0200, Michal Čihař wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
The "CALL" keyword, for executing stored procedures, is missing. Rouslan
Hi Dne Mon, 06 Jun 2011 13:49:38 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
On Thu, 2011-06-02 at 15:15 +0200, Michal Čihař wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
The "CALL" keyword, for executing stored procedures, is missing.
Hmm, looks like I've picked up the wrong list from the parser. Should be fixed in git. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Mon, 2011-06-06 at 15:02 +0200, Michal Čihař wrote:
Hi
Dne Mon, 06 Jun 2011 13:49:38 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
On Thu, 2011-06-02 at 15:15 +0200, Michal Čihař wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
The "CALL" keyword, for executing stored procedures, is missing.
Hmm, looks like I've picked up the wrong list from the parser. Should be fixed in git.
Strangely now it looks like "CALL" and "INOUT" are available in codemirror, but are missing in PMA's pretty printer. Rouslan
Hi Dne Tue, 07 Jun 2011 15:42:27 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
Strangely now it looks like "CALL" and "INOUT" are available in codemirror, but are missing in PMA's pretty printer.
Honestly I'm quite lost in two list of reserved words in the parser and don't know to which one these should be added. I've updated CodeMirror to official list of reserved words from MySQL docs, but not sure how to do this properly with our parser. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Thu, Jun 2, 2011 at 4:15 PM, Michal Čihař <michal@cihar.com> wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
I really like codemirror but it's current version currently has a huge drawback: no line wrapping. When a user copy&paste a long query into the the editor it becomes an unnerving hassle to edit the query. Like in my example: http://www.tyron.at/tmp/codemirror_linewrap.png It results in the codemirror extending extending really far horizontally and you get 2 scrollbars. And whenever you type something the scrollbars shift to the left again, somehow. Maybe there's some plugin available we could use to remedy that.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Mon, 2011-07-25 at 22:47 +0300, Tyron Madlener wrote:
On Thu, Jun 2, 2011 at 4:15 PM, Michal Čihař <michal@cihar.com> wrote:
Hi all
as of now, the master branch contains CodeMirror 2 [1] editor which is being used for SQL editing. Please test and report any failures with it.
The MySQL mode was written by me and keywords list is based on our SQL parser, so if something is missing there, most likely our SQL parser misses it as well :-).
I really like codemirror but it's current version currently has a huge drawback: no line wrapping.
When a user copy&paste a long query into the the editor it becomes an unnerving hassle to edit the query. Like in my example: http://www.tyron.at/tmp/codemirror_linewrap.png
It results in the codemirror extending extending really far horizontally and you get 2 scrollbars. And whenever you type something the scrollbars shift to the left again, somehow.
Maybe there's some plugin available we could use to remedy that.
Codemirror also doesn't work properly in RTL mode as far as I can tell. Rouslan
Hi Dne Mon, 25 Jul 2011 22:47:38 +0300 Tyron Madlener <tyronx@gmail.com> napsal(a):
I really like codemirror but it's current version currently has a huge drawback: no line wrapping.
When a user copy&paste a long query into the the editor it becomes an unnerving hassle to edit the query. Like in my example: http://www.tyron.at/tmp/codemirror_linewrap.png
It results in the codemirror extending extending really far horizontally and you get 2 scrollbars. And whenever you type something the scrollbars shift to the left again, somehow.
Maybe there's some plugin available we could use to remedy that.
Unfortunately CodeMirror does not (and probably will not) support wrapping: http://codemirror.net/internals.html#summary So we either accept it as it is or will look for other editor. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (5)
-
Madhura Jayaratne -
Marc Delisle -
Michal Čihař -
Rouslan Placella -
Tyron Madlener