[Phpmyadmin-devel] 'connect' in sql?
Hi, in common.lib.php::PMA_mysqlDie() // if the config password is wrong, or the MySQL server does not // respond, do not show the query that would reveal the // username/password if (!empty($the_query) && !strstr($the_query, 'connect')) { ??? what is 'connect' for??? in 'ancient times' ... was it neccessary to use a sql command to connect ??? -- Sebastian Mendel www.sebastianmendel.de
Hi On Thu, 22 Feb 2007 15:03:38 +0100 Sebastian Mendel <lists@sebastianmendel.de> wrote:
in common.lib.php::PMA_mysqlDie()
// if the config password is wrong, or the MySQL server does not // respond, do not show the query that would reveal the // username/password if (!empty($the_query) && !strstr($the_query, 'connect')) {
???
what is 'connect' for???
in 'ancient times' ... was it neccessary to use a sql command to connect ???
Maybe there was sometimes used PMA_mysqlDie('connect')? I think I saw this construct somewhere. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Sebastian Mendel a écrit :
Hi,
in common.lib.php::PMA_mysqlDie()
// if the config password is wrong, or the MySQL server does not // respond, do not show the query that would reveal the // username/password if (!empty($the_query) && !strstr($the_query, 'connect')) {
???
what is 'connect' for???
in 'ancient times' ... was it neccessary to use a sql command to connect ???
I think that this is a bug and is intented to catch a string like "Can't connect to MySQL server", but it should have checked $error_message and not $the_query for this. Anyway, the current logic that traps connection errors (for example libraries/auth/config.auth.lib.php in PMA_auth_fails() ) works correctly. Marc
participants (3)
-
Marc Delisle -
Michal Čihař -
Sebastian Mendel