Hi, I am refactoring sql.php and I want to rename the $_POST['fields'][...] variables such that they better reflect their intended use. I was trying to find out the origin of these variables and I was not successful. I would appreciate if someone can help me to find the source and the rationale of these variables.
Regards Supun
Supun Nakandala a écrit :
Hi, I am refactoring sql.php and I want to rename the $_POST['fields'][...] variables such that they better reflect their intended use. I was trying to find out the origin of these variables and I was not successful. I would appreciate if someone can help me to find the source and the rationale of these variables.
Hi Supun, do you know the "git blame" command? This will show you the commit and author by line of code.
Marc Delisle a écrit :
Supun Nakandala a écrit :
Hi, I am refactoring sql.php and I want to rename the $_POST['fields'][...] variables such that they better reflect their intended use. I was trying to find out the origin of these variables and I was not successful. I would appreciate if someone can help me to find the source and the rationale of these variables.
Hi Supun, do you know the "git blame" command? This will show you the commit and author by line of code.
Also, github, via the Files tab, permits you to pick one file and enter the Blame view for it.
On Wed, Jun 12, 2013 at 8:56 PM, Marc Delisle marc@infomarc.info wrote:
Marc Delisle a écrit :
Supun Nakandala a écrit :
Hi, I am refactoring sql.php and I want to rename the $_POST['fields'][...] variables such that they better reflect their intended use. I was
trying to
find out the origin of these variables and I was not successful. I would appreciate if someone can help me to find the source and the rationale
of
these variables.
Hi Supun, do you know the "git blame" command? This will show you the commit and author by line of code.
Also, github, via the Files tab, permits you to pick one file and enter the Blame view for it.
Now I am getting familiar with that feature.
Thanks
-- Marc Delisle http://infomarc.info
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Wed, Jun 12, 2013 at 9:05 PM, Supun Nakandala supun.nakandala@gmail.comwrote:
On Wed, Jun 12, 2013 at 8:56 PM, Marc Delisle marc@infomarc.info wrote:
Marc Delisle a écrit :
Supun Nakandala a écrit :
Hi, I am refactoring sql.php and I want to rename the $_POST['fields'][...] variables such that they better reflect their intended use. I was
trying to
find out the origin of these variables and I was not successful. I
would
appreciate if someone can help me to find the source and the rationale
of
these variables.
Hi Supun, do you know the "git blame" command? This will show you the commit and author by line of code.
Also, github, via the Files tab, permits you to pick one file and enter the Blame view for it.
Now I am getting familiar with that feature.
Thanks
-- Marc Delisle http://infomarc.info
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Thank you Supun Nakandala Dept. Computer Science and Engineering University of Moratuwa
Hi Marc, According to what I understood git blame allows me to find the respective contributor for each line of code. But what I am interested about is to find the place in code where these $_POST['fields'][...] variables are set. How can I find that ?. Please correct me if I am wrong.
Supun Nakandala a écrit :
On Wed, Jun 12, 2013 at 9:05 PM, Supun Nakandala supun.nakandala@gmail.comwrote:
On Wed, Jun 12, 2013 at 8:56 PM, Marc Delisle marc@infomarc.info wrote:
Marc Delisle a écrit :
Supun Nakandala a écrit :
Hi, I am refactoring sql.php and I want to rename the $_POST['fields'][...] variables such that they better reflect their intended use. I was
trying to
find out the origin of these variables and I was not successful. I
would
appreciate if someone can help me to find the source and the rationale
of
these variables.
Hi Supun, do you know the "git blame" command? This will show you the commit and author by line of code.
Also, github, via the Files tab, permits you to pick one file and enter the Blame view for it.
Now I am getting familiar with that feature.
Thanks
-- Marc Delisle http://infomarc.info
Hi Marc, According to what I understood git blame allows me to find the respective contributor for each line of code. But what I am interested about is to find the place in code where these $_POST['fields'][...] variables are set. How can I find that ?. Please correct me if I am wrong.
This is more tricky. I basically see two ways:
1. Looking for a string in your editor when you know the file, or looking via "git grep" when you don't know which file
2. Using an IDE like NetBeans where you can track the execution path at the PHP level and set watchpoints (but I'm not sure about watching $_POST variables)
In this case, since it comes from a POST, most likely it's located in a form so you can start by searching for forms in sql.php.
On Wed, Jun 12, 2013 at 10:01 PM, Marc Delisle marc@infomarc.info wrote:
Supun Nakandala a écrit :
On Wed, Jun 12, 2013 at 9:05 PM, Supun Nakandala supun.nakandala@gmail.comwrote:
On Wed, Jun 12, 2013 at 8:56 PM, Marc Delisle marc@infomarc.info
wrote:
Marc Delisle a écrit :
Supun Nakandala a écrit :
Hi, I am refactoring sql.php and I want to rename the
$_POST['fields'][...]
variables such that they better reflect their intended use. I was
trying to
find out the origin of these variables and I was not successful. I
would
appreciate if someone can help me to find the source and the
rationale
of
these variables.
Hi Supun, do you know the "git blame" command? This will show you the commit and author by line of code.
Also, github, via the Files tab, permits you to pick one file and enter the Blame view for it.
Now I am getting familiar with that feature.
Thanks
-- Marc Delisle http://infomarc.info
Hi Marc, According to what I understood git blame allows me to find the respective contributor for each line of code. But what I am interested about is to find the place in code where these $_POST['fields'][...] variables are
set.
How can I find that ?. Please correct me if I am wrong.
This is more tricky. I basically see two ways:
- Looking for a string in your editor when you know the file, or
looking via "git grep" when you don't know which file
- Using an IDE like NetBeans where you can track the execution path at
the PHP level and set watchpoints (but I'm not sure about watching $_POST variables)
In this case, since it comes from a POST, most likely it's located in a form so you can start by searching for forms in sql.php.
I'll try them.
-- Marc Delisle http://infomarc.info
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi all,
On the UT pull request, https://github.com/phpmyadmin/phpmyadmin/pull/419
I found that the source code https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/schema/Dia_Re...
the "exit" statement will make the UT exit unexpectedly, can we remove "exit" ? thanks
the same question exsited on all sub-classes of schema: libraries/schema/Dia_Relation_Schema.class.php libraries/schema/Eps_Relation_Schema.class.php libraries/schema/Pdf_Relation_Schema.class.php libraries/schema/Svg_Relation_Schema.class.php
-------------- adam
Hi
Dne Wed, 12 Jun 2013 23:51:30 +0800 adam adamgsoc2013@gmail.com napsal(a):
On the UT pull request, https://github.com/phpmyadmin/phpmyadmin/pull/419
I found that the source code https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/schema/Dia_Re...
the "exit" statement will make the UT exit unexpectedly, can we remove "exit" ?
Most likely the exit is there for a reason, have you tested whether the code still works when removing the exit?
-
adam -
Marc Delisle -
Michal Čihař -
Supun Nakandala