[Phpmyadmin-devel] DB Operations - Resolution problem
Hi all, Rouslan, in his comment on tracker item [1] pointed out that with the new layout in DB Operations page, the page looks weird in both Firefox and Opera. He is using the screen resolution of 1280 x 1024. I would like to know whether the new layout looks okay/weird in other resolutions as well. I initially checked with 1366 x 768 and the page looks okay with that resolution. -- Thanks and Regards, Madhura Jayaratne [1] https://sourceforge.net/tracker/index.php?func=detail&aid=3292121&group_id=2...
2011/5/1 Madhura Jayaratne <madhura.cj@gmail.com>:
Hi all, Rouslan, in his comment on tracker item [1] pointed out that with the new layout in DB Operations page, the page looks weird in both Firefox and Opera. He is using the screen resolution of 1280 x 1024. I would like to know whether the new layout looks okay/weird in other resolutions as well. I initially checked with 1366 x 768 and the page looks okay with that resolution.
Make your window narrower and you will see this effect. For database operations tab this limit seems to be 944 pixels in width (page body, not browser window), and for table operations 837 pixels (give or take a few px). We can ignore this problem, or assume people use modern browsers and add CSS media queries for targeting small screen widths. -- Piotr Przybylski
Hi, I tried it on my 1280x800 screen and it gave me results like Rouslan's screenshot. Only after reducing the font size, I can see the operation tab neatly. (FF 3.6.16, ubuntu) -- Aris Feryanto On 2 Mei 2011, at 01:10, Piotr Przybylski <piotr.prz@gmail.com> wrote:
2011/5/1 Madhura Jayaratne <madhura.cj@gmail.com>:
Hi all, Rouslan, in his comment on tracker item [1] pointed out that with the new layout in DB Operations page, the page looks weird in both Firefox and Opera. He is using the screen resolution of 1280 x 1024. I would like to know whether the new layout looks okay/weird in other resolutions as well. I initially checked with 1366 x 768 and the page looks okay with that resolution.
Make your window narrower and you will see this effect. For database operations tab this limit seems to be 944 pixels in width (page body, not browser window), and for table operations 837 pixels (give or take a few px).
We can ignore this problem, or assume people use modern browsers and add CSS media queries for targeting small screen widths.
-- Piotr Przybylski
On Sun, 2011-05-01 at 20:10 +0200, Piotr Przybylski wrote:
2011/5/1 Madhura Jayaratne <madhura.cj@gmail.com>:
Hi all, Rouslan, in his comment on tracker item [1] pointed out that with the new layout in DB Operations page, the page looks weird in both Firefox and Opera. He is using the screen resolution of 1280 x 1024. I would like to know whether the new layout looks okay/weird in other resolutions as well. I initially checked with 1366 x 768 and the page looks okay with that resolution.
Make your window narrower and you will see this effect. For database operations tab this limit seems to be 944 pixels in width (page body, not browser window), and for table operations 837 pixels (give or take a few px).
We can ignore this problem, or assume people use modern browsers and add CSS media queries for targeting small screen widths.
No need to ignore it IMO, as this is very easily fixable. Please find a patch with a proposed solution attached to this email. Rouslan
On Mon, May 2, 2011 at 12:16 AM, Rouslan Placella <rouslan@placella.com>wrote:
On Sun, 2011-05-01 at 20:10 +0200, Piotr Przybylski wrote:
2011/5/1 Madhura Jayaratne <madhura.cj@gmail.com>:
Hi all, Rouslan, in his comment on tracker item [1] pointed out that with the new layout in DB Operations page, the page looks weird in both Firefox and Opera. He is using the screen resolution of 1280 x 1024. I would like to know whether the new layout looks okay/weird in other resolutions as well. I initially checked with 1366 x 768 and the page looks okay with that resolution.
Make your window narrower and you will see this effect. For database operations tab this limit seems to be 944 pixels in width (page body, not browser window), and for table operations 837 pixels (give or take a few px).
We can ignore this problem, or assume people use modern browsers and add CSS media queries for targeting small screen widths.
No need to ignore it IMO, as this is very easily fixable. Please find a patch with a proposed solution attached to this email.
Rouslan
Rouslan, Create table section is used in DB structure page as well and I don't think it looks nice there with the changes in your patch. -- Thanks and Regards, Madhura Jayaratne
Create table section is used in DB structure page as well and I don't think it looks nice there with the changes in your patch.
-- Thanks and Regards,
Madhura Jayaratne
You're right, I missed that. Well, the clearfloat DIV could be selectively applied only to the db_operations page then. I've attached another patch, though I'm not sure if I used the best method for figuring out which page one is on, but it works. Rouslan
Le 2011-05-01 15:51, Rouslan Placella a écrit :
Create table section is used in DB structure page as well and I don't think it looks nice there with the changes in your patch.
-- Thanks and Regards,
Madhura Jayaratne
You're right, I missed that. Well, the clearfloat DIV could be selectively applied only to the db_operations page then.
I've attached another patch, though I'm not sure if I used the best method for figuring out which page one is on, but it works.
Rouslan
Hi Rouslan, please use the patch tracker, to avoid unintentional forgetting of patches. -- Marc Delisle http://infomarc.info
On Mon, 2011-05-02 at 05:55 -0400, Marc Delisle wrote:
Le 2011-05-01 15:51, Rouslan Placella a écrit :
Create table section is used in DB structure page as well and I don't think it looks nice there with the changes in your patch.
-- Thanks and Regards,
Madhura Jayaratne
You're right, I missed that. Well, the clearfloat DIV could be selectively applied only to the db_operations page then.
I've attached another patch, though I'm not sure if I used the best method for figuring out which page one is on, but it works.
Rouslan
Hi Rouslan, please use the patch tracker, to avoid unintentional forgetting of patches.
Ok, sorry about that, won't happen again. Rouslan
On Mon, May 2, 2011 at 1:21 AM, Rouslan Placella <rouslan@placella.com>wrote:
Create table section is used in DB structure page as well and I don't think it looks nice there with the changes in your patch.
-- Thanks and Regards,
Madhura Jayaratne
You're right, I missed that. Well, the clearfloat DIV could be selectively applied only to the db_operations page then.
I've attached another patch, though I'm not sure if I used the best method for figuring out which page one is on, but it works.
Rouslan
I fixed the issue in a little bit different way. Please see Commit:f25945b8bee7b5025abe4e4e054cf6732dcca6ec -- Thanks and Regards, Madhura Jayaratne
participants (5)
-
Aris Feryanto -
Madhura Jayaratne -
Marc Delisle -
Piotr Przybylski -
Rouslan Placella