[Phpmyadmin-devel] problem with column dragging
Tyron, could you have a look at your commit a5df22ced5067260b5edbb3d95b83cc8050d21a9 ? In my tests, this commit breaks column dragging. For example, in sakila.actor, try to drag actor_id to the rightmost position. -- Marc Delisle http://infomarc.info
On Tue, Jul 19, 2011 at 7:50 PM, Marc Delisle <marc@infomarc.info> wrote:
Tyron, could you have a look at your commit a5df22ced5067260b5edbb3d95b83cc8050d21a9 ?
In my tests, this commit breaks column dragging. For example, in sakila.actor, try to drag actor_id to the rightmost position.
There was suddenly the makegrid() event attached twice in sql.js, though I've no idea how it happened. After removing that, I compared sql.js with a version before my commit. Everything else seems to be fine. So commit 97b1375605f241481a953e2c78eb42d43f84fa9d pushed to my repo removes that duplicate code, which in return fixes the column dragging.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Magic Quadrant for Content-Aware Data Loss Prevention Research study explores the data loss prevention market. Includes in-depth analysis on the changes within the DLP market, and the criteria used to evaluate the strengths and weaknesses of these DLP solutions. http://www.accelacomm.com/jaw/sfnl/114/51385063/ _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-19 14:55, Tyron Madlener a écrit :
On Tue, Jul 19, 2011 at 7:50 PM, Marc Delisle<marc@infomarc.info> wrote:
Tyron, could you have a look at your commit a5df22ced5067260b5edbb3d95b83cc8050d21a9 ?
In my tests, this commit breaks column dragging. For example, in sakila.actor, try to drag actor_id to the rightmost position.
There was suddenly the makegrid() event attached twice in sql.js, though I've no idea how it happened. After removing that, I compared sql.js with a version before my commit. Everything else seems to be fine.
So commit 97b1375605f241481a953e2c78eb42d43f84fa9d pushed to my repo removes that duplicate code, which in return fixes the column dragging.
Fix confirmed and merged to origin/master, thanks. -- Marc Delisle http://infomarc.info
participants (2)
-
Marc Delisle -
Tyron Madlener