[Phpmyadmin-devel] Prototype of new navigation
Hi there, I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea. I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks. Rouslan [1]: http://demo.phpmyadmin.net/gsoc-rouslan/
Rouslan Placella a écrit :
Hi there,
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
Rouslan
Rouslan, impressive! I'm trying to run it on my machine but I cannot find this code in git://repo.or.cz/phpmyadmin/roccivic.git. Suggestions: - show which db is active (because you may open more than one) - the tree should not close after a table copy from Operations -- Marc Delisle http://infomarc.info
On Sat, 2011-08-20 at 09:49 -0400, Marc Delisle wrote:
Rouslan Placella a écrit :
Hi there,
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
Rouslan
Rouslan, impressive! I'm trying to run it on my machine but I cannot find this code in git://repo.or.cz/phpmyadmin/roccivic.git.
The code is in the 'rte' branch [1], but please keep in mind that it's far from being ready, as I was rushing the development because I wanted to have something almost-usable for the GSoC deadline. In fact, it needs a lot of refactoring, cleaning, commenting, optimising, the addition of missing features and some bugfixes. [1]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte
Suggestions: - show which db is active (because you may open more than one) Noted, thanks.
- the tree should not close after a table copy from Operations Yeah, I need something better than refreshing the whole navigation upon operations such as "new db", "new table", "copy", "rename", etc....
Rouslan
Rouslan Placella a écrit :
On Sat, 2011-08-20 at 09:49 -0400, Marc Delisle wrote:
Rouslan Placella a écrit :
Hi there,
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
Rouslan
[1]: http://demo.phpmyadmin.net/gsoc-rouslan/ Rouslan, impressive! I'm trying to run it on my machine but I cannot find this code in git://repo.or.cz/phpmyadmin/roccivic.git.
The code is in the 'rte' branch [1], but please keep in mind that it's far from being ready, as I was rushing the development because I wanted to have something almost-usable for the GSoC deadline. In fact, it needs a lot of refactoring, cleaning, commenting, optimising, the addition of missing features and some bugfixes.
Nonetheless it's a good start.
[1]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte
Ok; please avoid PHP short tags (found one in libraries/navigation/Node.class.php).
Suggestions: - show which db is active (because you may open more than one) Noted, thanks.
- the tree should not close after a table copy from Operations Yeah, I need something better than refreshing the whole navigation upon operations such as "new db", "new table", "copy", "rename", etc....
Rouslan
With $cfg['MaxDbList'] set to a low value, pages higher than number one are empty. -- Marc Delisle http://infomarc.info
On Sat, 2011-08-20 at 10:53 -0400, Marc Delisle wrote:
Rouslan Placella a écrit :
On Sat, 2011-08-20 at 09:49 -0400, Marc Delisle wrote:
Rouslan Placella a écrit :
Hi there,
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
Rouslan
[1]: http://demo.phpmyadmin.net/gsoc-rouslan/ Rouslan, impressive! I'm trying to run it on my machine but I cannot find this code in git://repo.or.cz/phpmyadmin/roccivic.git.
The code is in the 'rte' branch [1], but please keep in mind that it's far from being ready, as I was rushing the development because I wanted to have something almost-usable for the GSoC deadline. In fact, it needs a lot of refactoring, cleaning, commenting, optimising, the addition of missing features and some bugfixes.
Nonetheless it's a good start.
[1]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte
Ok; please avoid PHP short tags (found one in libraries/navigation/Node.class.php).
Fixed in my local repo, thanks.
Suggestions: - show which db is active (because you may open more than one) Noted, thanks.
- the tree should not close after a table copy from Operations Yeah, I need something better than refreshing the whole navigation upon operations such as "new db", "new table", "copy", "rename", etc....
Rouslan
With $cfg['MaxDbList'] set to a low value, pages higher than number one are empty.
I also noticed this on the demo server, but can't reproduce it locally. I think I'll ask Michal for some extra access to the demo server in order to sort this out. Rouslan
Hi Dne Sat, 20 Aug 2011 16:31:29 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
I also noticed this on the demo server, but can't reproduce it locally. I think I'll ask Michal for some extra access to the demo server in order to sort this out.
Probably caused by missing server parameter in requests, so you try to load consequent databases from other server. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
On 20 Agu 2011, at 22:33, Rouslan Placella <rouslan@placella.com> wrote:
On Sat, 2011-08-20 at 09:49 -0400, Marc Delisle wrote:
Rouslan Placella a écrit :
Hi there,
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
Rouslan
Rouslan, impressive! I'm trying to run it on my machine but I cannot find this code in git://repo.or.cz/phpmyadmin/roccivic.git.
The code is in the 'rte' branch [1], but please keep in mind that it's far from being ready, as I was rushing the development because I wanted to have something almost-usable for the GSoC deadline. In fact, it needs a lot of refactoring, cleaning, commenting, optimising, the addition of missing features and some bugfixes.
[1]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte
Suggestions: - show which db is active (because you may open more than one) Noted, thanks.
- the tree should not close after a table copy from Operations Yeah, I need something better than refreshing the whole navigation upon operations such as "new db", "new table", "copy", "rename", etc....
The new navigation looks great! Just an opinion. When expanding a database node, I found that it is easier if we can see the list of tables and views directly under the database node (in the same level with Functions, Triggers, etc.), so we don't need one more ajax request (either by clicking on "Tables" node or automatically expanded when only "Tables" node exist under the databse). Anyone have the same thought? -- Aris Feryanto
Aris Feryanto a écrit :
On 20 Agu 2011, at 22:33, Rouslan Placella <rouslan@placella.com> wrote:
On Sat, 2011-08-20 at 09:49 -0400, Marc Delisle wrote:
Rouslan Placella a écrit :
Hi there,
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
Rouslan
[1]: http://demo.phpmyadmin.net/gsoc-rouslan/ Rouslan, impressive! I'm trying to run it on my machine but I cannot find this code in git://repo.or.cz/phpmyadmin/roccivic.git. The code is in the 'rte' branch [1], but please keep in mind that it's far from being ready, as I was rushing the development because I wanted to have something almost-usable for the GSoC deadline. In fact, it needs a lot of refactoring, cleaning, commenting, optimising, the addition of missing features and some bugfixes.
[1]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte
Suggestions: - show which db is active (because you may open more than one) Noted, thanks.
- the tree should not close after a table copy from Operations Yeah, I need something better than refreshing the whole navigation upon operations such as "new db", "new table", "copy", "rename", etc....
The new navigation looks great!
Just an opinion. When expanding a database node, I found that it is easier if we can see the list of tables and views directly under the database node (in the same level with Functions, Triggers, etc.), so we don't need one more ajax request (either by clicking on "Tables" node or automatically expanded when only "Tables" node exist under the databse). Anyone have the same thought?
I think it's cleaner to regroup all tables under a "Tables" heading like they are now, but automatic expansion of this Tables node would be an improvement, because of its popularity. -- Marc Delisle http://infomarc.info
On Sat, 2011-08-20 at 23:29 +0800, Aris Feryanto wrote:
On 20 Agu 2011, at 22:33, Rouslan Placella <rouslan@placella.com> wrote:
On Sat, 2011-08-20 at 09:49 -0400, Marc Delisle wrote:
Rouslan Placella a écrit :
Hi there,
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
Rouslan
Rouslan, impressive! I'm trying to run it on my machine but I cannot find this code in git://repo.or.cz/phpmyadmin/roccivic.git.
The code is in the 'rte' branch [1], but please keep in mind that it's far from being ready, as I was rushing the development because I wanted to have something almost-usable for the GSoC deadline. In fact, it needs a lot of refactoring, cleaning, commenting, optimising, the addition of missing features and some bugfixes.
[1]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte
Suggestions: - show which db is active (because you may open more than one) Noted, thanks.
- the tree should not close after a table copy from Operations Yeah, I need something better than refreshing the whole navigation upon operations such as "new db", "new table", "copy", "rename", etc....
The new navigation looks great!
Just an opinion. When expanding a database node, I found that it is easier if we can see the list of tables and views directly under the database node (in the same level with Functions, Triggers, etc.), so we don't need one more ajax request (either by clicking on "Tables" node or automatically expanded when only "Tables" node exist under the databse). Anyone have the same thought?
I your concern is just the extra ajax request when only tables are available for a particular db, then you shouldn't worry about that very much as I have intentions of optimising that part of the code so that the already expanded list of tables is sent in a single ajax request. But if your concern is aesthetic, then, errrrr, I don't know. Personally, I prefer the items to be grouped by type. Let's see if anyone else has an opinion on the matter. Rouslan
On Sat, Aug 20, 2011 at 3:16 PM, Rouslan Placella <rouslan@placella.com> wrote:
Hi there,
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
Rouslan
Yes, very nice. Much better than the old navigation. My suggestions: - The dotted lines are rather annoying than helpful. I think people can navigate through the databases very well without those guides. - Visual glitch: Hovering your mouse over the icons makes a black underscore appear right to it. - Not quite sure how helpful it is to "expand tables" to edit it's single columns. Maybe it should rather display the data sorted by that column or so? - Trying to expand a empty database should (imo) remove the contract/expand icon after it's being identified as empty. - Would be really helpful to have a "expand all" & "contract all" icon
Just an opinion. When expanding a database node, I found that it is easier if we can see the list of tables and views directly >under the database node (in the same level with Functions, Triggers, etc.), so we don't need one more ajax request (either >by clicking on "Tables" node or automatically expanded when only "Tables" node exist under the databse). Anyone have the >same thought?
You have a good point there. Maybe let the user choose between these modes as configuration setting? Having the entries grouped certainly makes things look cleaner, and I can imagine that would be very helpful for db servers with lots of dbs and tables, but rather and inconvenience when having only a little dbs with little tables.
------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Rouslan Dne Sat, 20 Aug 2011 13:16:50 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
I think it looks great. Few comments: - I'd expect "Tables", "Procedures", "Colums" etc. to be links to appropriate page in right frame (db_structure, db_routines, tbl_structure in these particular cases). - As already Tyron said, I thing dotted lines are not needed. - When there are more than one servers configured, servers might be included in the tree as well. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
On Mon, 2011-08-22 at 09:26 +0200, Michal Čihař wrote:
Hi Rouslan
Dne Sat, 20 Aug 2011 13:16:50 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
I've been working on a rewrite of the navigation frame and I've pushed a prototype to my remote repo and it's available for preview on my demo server [1]. It's still quite far from being finished, there are several unimplemented features and bugs, but you will get a general idea.
I would appreciate if you take the time to have a look at it and give me some feedback regarding this. Thanks.
I think it looks great.
Few comments:
- I'd expect "Tables", "Procedures", "Colums" etc. to be links to appropriate page in right frame (db_structure, db_routines, tbl_structure in these particular cases).
OK, I'll add those
- As already Tyron said, I thing dotted lines are not needed.
I personally find them to be useful, but sure they can be removed.
- When there are more than one servers configured, servers might be included in the tree as well.
Putting servers in the navigation tree would only work seamlessly for "config" auth, for "cookie" and "http" auths the user would be dropped back to the login page. That's why I didn't put them there. And besides I think that it would be quite a bit of extra work to put the servers in the tree, would you say that it could be worth the effort? Rouslan
Hi Dne Mon, 22 Aug 2011 10:23:05 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
On Mon, 2011-08-22 at 09:26 +0200, Michal Čihař wrote:
- As already Tyron said, I thing dotted lines are not needed.
I personally find them to be useful, but sure they can be removed.
What do other think about this topic?
- When there are more than one servers configured, servers might be included in the tree as well.
Putting servers in the navigation tree would only work seamlessly for "config" auth, for "cookie" and "http" auths the user would be dropped back to the login page. That's why I didn't put them there. And besides I think that it would be quite a bit of extra work to put the servers in the tree, would you say that it could be worth the effort?
Indeed it would bring challenges with authentication. I'm not sure if it's worth of the effort, there are probably not that many users using more than one server... -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
2011/8/22 Michal Čihař <michal@cihar.com>:
Hi
Dne Mon, 22 Aug 2011 10:23:05 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
On Mon, 2011-08-22 at 09:26 +0200, Michal Čihař wrote:
- As already Tyron said, I thing dotted lines are not needed.
I personally find them to be useful, but sure they can be removed.
What do other think about this topic?
The two dotted lines seem strange. It can do without them, or at least with one less. Kind regards, Dieter
2011/8/22 Dieter Adriaenssens <dieter.adriaenssens@gmail.com>:
2011/8/22 Michal Čihař <michal@cihar.com>:
Hi
Dne Mon, 22 Aug 2011 10:23:05 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
On Mon, 2011-08-22 at 09:26 +0200, Michal Čihař wrote:
- As already Tyron said, I thing dotted lines are not needed.
I personally find them to be useful, but sure they can be removed.
What do other think about this topic?
The two dotted lines seem strange. It can do without them, or at least with one less.
Never mind about the two-line remark, I didn't notice at first there was more than one branch opened. Dotted lines can be skipped, IMO.
Kind regards,
Dieter
-- Groetjes, Dieter Adriaenssens
Le 2011-08-22 05:48, Michal Čihař a écrit :
Hi
Dne Mon, 22 Aug 2011 10:23:05 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
On Mon, 2011-08-22 at 09:26 +0200, Michal Čihař wrote:
- As already Tyron said, I thing dotted lines are not needed.
I personally find them to be useful, but sure they can be removed.
What do other think about this topic?
I don't need the dotted lines but I don't find them annoying; they help delineating sections. Maybe what looks strange is that the dotted line does not connect to the + or - icon. -- Marc Delisle http://infomarc.info
2011/8/22 Marc Delisle <marc@infomarc.info>:
Le 2011-08-22 05:48, Michal Čihař a écrit :
Hi
Dne Mon, 22 Aug 2011 10:23:05 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
On Mon, 2011-08-22 at 09:26 +0200, Michal Čihař wrote:
- As already Tyron said, I thing dotted lines are not needed.
I personally find them to be useful, but sure they can be removed.
What do other think about this topic?
I don't need the dotted lines but I don't find them annoying; they help delineating sections.
Maybe what looks strange is that the dotted line does not connect to the + or - icon.
Maybe they should look like dotted lines in phpPgAdmin? -- Piotr Przybylski
Piotr Przybylski a écrit :
2011/8/22 Marc Delisle <marc@infomarc.info>:
Le 2011-08-22 05:48, Michal Čihař a écrit :
Hi
Dne Mon, 22 Aug 2011 10:23:05 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
On Mon, 2011-08-22 at 09:26 +0200, Michal Čihař wrote:
- As already Tyron said, I thing dotted lines are not needed. I personally find them to be useful, but sure they can be removed. What do other think about this topic? I don't need the dotted lines but I don't find them annoying; they help delineating sections.
Maybe what looks strange is that the dotted line does not connect to the + or - icon.
Maybe they should look like dotted lines in phpPgAdmin?
Yes, these dotted lines connect to the icon that is used to open/close a section. -- Marc Delisle http://infomarc.info
Le 2011-08-22 07:07, Marc Delisle a écrit :
Le 2011-08-22 05:48, Michal Čihař a écrit :
Hi
Dne Mon, 22 Aug 2011 10:23:05 +0100 Rouslan Placella <rouslan@placella.com> napsal(a):
On Mon, 2011-08-22 at 09:26 +0200, Michal Čihař wrote:
- As already Tyron said, I thing dotted lines are not needed.
I personally find them to be useful, but sure they can be removed.
What do other think about this topic?
I don't need the dotted lines but I don't find them annoying; they help delineating sections.
Maybe what looks strange is that the dotted line does not connect to the + or - icon.
I meant "the + icon" only. -- Marc Delisle http://infomarc.info
participants (7)
-
Aris Feryanto -
Dieter Adriaenssens -
Marc Delisle -
Michal Čihař -
Piotr Przybylski -
Rouslan Placella -
Tyron Madlener