Hello,
I prepared this patch https://github.com/phpmyadmin/phpmyadmin/pull/290
with the JS fix(that i applied for Firefox) it works correctly both in Firefox and chrome. Updation and insertion both work fine.
But for an unknown reason it fails one of the tests.
It says "Failed asserting that two arrays are equal" . I don't get it, just added an extra string in that array of functions(Types.class.php).
It seems to me that the old array was expected but since i changed it, its creating some kind of problem. I don't know, i never had such situation, so i'm pretty helpless in this case.
I'd be grateful, if i can have some points or hints on how to correct it.
Thanks Ayush.
Hi,
On Tuesday, 30 April 2013 at 2:25 PM, ayush choubey wrote:
Hello,
I prepared this patch https://github.com/phpmyadmin/phpmyadmin/pull/290
with the JS fix(that i applied for Firefox) it works correctly both in Firefox and chrome. Updation and insertion both work fine.
But for an unknown reason it fails one of the tests.
It says "Failed asserting that two arrays are equal" . I don't get it, just added an extra string in that array of functions(Types.class.php).
The unit test corresponding to this function is failing. If you go to test/classes/PMA_Types_MySQL_test.php and look for the method providerFortTestGetFunctionsClass(), it defines various input and output cases. Since you changed the output array corresponding to input 'CHAR', the test case is still trying to match it with the old output array. Please add AES_ENCRYPT, in the output array for 'CHAR' in the test case as well and the build should be just fine.
It seems to me that the old array was expected but since i changed it, its creating some kind of problem. I don't know, i never had such situation, so i'm pretty helpless in this case.
I'd be grateful, if i can have some points or hints on how to correct it.
Thanks Ayush.
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1
Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net (mailto:Phpmyadmin-devel@lists.sourceforge.net) https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Ayush Chaudhary
Hi,
I have updated my proposal based on you guys' comments. Can you have a qucik review, and give me more guide? thanks
https://google-melange.appspot.com/gsoc/proposal/review/google/gsoc2013/adam...
In the coming days, I would like to send more patchs about Automated Testing. thanks
Adam
Hi all,
I updated my proposal about server view refactor. Can someone spend some time to review it and give me some advices? thanks http://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/xmujay/27...
I also sent three pull requests about server view refactor. thanks
xmujay (Bin Zu)