Congratulations Michal for this excellent script. I have a few comments:
- In the Servers section, could we have just one dropdown of servers, then the 2 buttons Delete and Edit next to the dropdown?
- In the doc, should we give the UNIX commands for proper permission and ownership of the config directory? We are already doing it in the doc for another subject.
- PMA's behavior (with default configuration) has always been to try to connect to a localhost server with root and no password (to match default MySQL installation), but now I suggest that PMA goes into setup mode if no config.inc.php is found.
- Maybe in the Servers section or in the "Configure Server" dialog a "Add default MySQL server" button or something like that.
- Maybe in the Configuration section, display Save and Load in grey when they are not available, with a link to the doc explaining why.
Marc
Hi
Thanks a lot for feedback!
On Thu, 08 Dec 2005 12:27:52 -0500 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
Congratulations Michal for this excellent script. I have a few comments:
- In the Servers section, could we have just one dropdown of servers,
then the 2 buttons Delete and Edit next to the dropdown?
It is planned, however this way was simpler to implement ;-).
- In the doc, should we give the UNIX commands for proper permission and
ownership of the config directory? We are already doing it in the doc for another subject.
I'm adding it right now :-).
- PMA's behavior (with default configuration) has always been to try to
connect to a localhost server with root and no password (to match default MySQL installation), but now I suggest that PMA goes into setup mode if no config.inc.php is found.
There are still situations where it will work without any setup. So going directly to setup will just break those situations. We could direct to setup when connecting to root@localhost without password fails.
- Maybe in the Servers section or in the "Configure Server" dialog a
"Add default MySQL server" button or something like that.
When you add first server it is default server, for rest I start with empty and default to cookie auth.
- Maybe in the Configuration section, display Save and Load in grey when
they are not available, with a link to the doc explaining why.
Big red message when entering setup is not enough?
Michal Čihař a écrit :
Hi
Thanks a lot for feedback!
On Thu, 08 Dec 2005 12:27:52 -0500 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
Congratulations Michal for this excellent script. I have a few comments:
- In the Servers section, could we have just one dropdown of servers,
then the 2 buttons Delete and Edit next to the dropdown?
It is planned, however this way was simpler to implement ;-).
No problem!
- In the doc, should we give the UNIX commands for proper permission and
ownership of the config directory? We are already doing it in the doc for another subject.
I'm adding it right now :-).
- PMA's behavior (with default configuration) has always been to try to
connect to a localhost server with root and no password (to match default MySQL installation), but now I suggest that PMA goes into setup mode if no config.inc.php is found.
There are still situations where it will work without any setup. So going directly to setup will just break those situations. We could direct to setup when connecting to root@localhost without password fails.
Good point.
- Maybe in the Servers section or in the "Configure Server" dialog a
"Add default MySQL server" button or something like that.
When you add first server it is default server, for rest I start with empty and default to cookie auth.
- Maybe in the Configuration section, display Save and Load in grey when
they are not available, with a link to the doc explaining why.
Big red message when entering setup is not enough?
Yes, if title changed to "Can't load or save configuration", to match the buttons.
Marc
Marc Delisle a écrit :
Congratulations Michal for this excellent script. I have a few comments:
- In the Servers section, could we have just one dropdown of servers,
then the 2 buttons Delete and Edit next to the dropdown?
- In the doc, should we give the UNIX commands for proper permission and
ownership of the config directory? We are already doing it in the doc for another subject.
- PMA's behavior (with default configuration) has always been to try to
connect to a localhost server with root and no password (to match default MySQL installation), but now I suggest that PMA goes into setup mode if no config.inc.php is found.
- Maybe in the Servers section or in the "Configure Server" dialog a
"Add default MySQL server" button or something like that.
- Maybe in the Configuration section, display Save and Load in grey when
they are not available, with a link to the doc explaining why.
Another point that bothers me: if an admin, instead of moving config.inc.php to parent directory, copies it, any of his users will be able to load the working copy of config.inc.php. I suggest some warning on the main page. I have even seen some products that refuse to work if the config (or install) directory is still there.
Marc
Hi
On Thu, 08 Dec 2005 13:08:34 -0500 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
Another point that bothers me: if an admin, instead of moving config.inc.php to parent directory, copies it, any of his users will be able to load the working copy of config.inc.php. I suggest some warning on the main page. I have even seen some products that refuse to work if the config (or install) directory is still there.
I have changed phpMyAdmin to be one of those products :-).