[Phpmyadmin-devel] Dead code in master
Hi all, I think that the code at [0] is dead and should be removed. The first reason is that the checked variables were probably removed together with grab globals and secondly, there is no 'submitcomment' parameter in a tbl_operations form anyway. Bye, Rouslan [0]: https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/tbl_info.inc....
Le 2012-08-09 04:50, Rouslan Placella a écrit :
Hi all,
I think that the code at [0] is dead and should be removed. The first reason is that the checked variables were probably removed together with grab globals and secondly, there is no 'submitcomment' parameter in a tbl_operations form anyway.
Hi Rouslan, Agreed. -- Marc Delisle http://infomarc.info
On 09/08/2012 12:46, Marc Delisle wrote:
Le 2012-08-09 04:50, Rouslan Placella a écrit :
Hi all,
I think that the code at [0] is dead and should be removed. The first reason is that the checked variables were probably removed together with grab globals and secondly, there is no 'submitcomment' parameter in a tbl_operations form anyway.
Hi Rouslan, Agreed.
Hi Marc, I've dropped the relevant code in upstream master. And I see no loss of functionality (described in the comment which was part of the dead code). Bye, Rouslan
participants (2)
-
Marc Delisle -
Rouslan Placella