6 Jul
2018
6 Jul
'18
10:01 a.m.
Hi,
Me and Devan were discussing about the current pr 'gsoc' which I have made
for the modular javascript code but the pr has lots of unused files which I
have created for making sure that existing code is not breaking and
contains lot of commented out code.
So we have decided to create a new branch in main repo of phpMyAdmin and
multiple pr's from gsoc branch with small changes which can be reviewed and
then merged into the newly created branch and we'll then keep merging this
new branch into master after review and testing.
So I am closing this gsoc pr and will make multiple small pr's from this
branch by cherry-picking the commits.
Any suggestions regarding this would be welcome.
Regards
Piyush Vijay
11 Jul
11 Jul
12:37 a.m.
Hi.
I think that's a good idea. This will greatly facilitate the review of pull
requests and the development of the GSoC project.
I created a new branch called gsoc-js-refactoring [1] and changed the base
branch of the first PR to that branch [2].
[1] https://github.com/phpmyadmin/phpmyadmin/tree/gsoc-js-refactoring
[2] https://github.com/phpmyadmin/phpmyadmin/pull/14464
Regards,
Maurício
On Fri, Jul 6, 2018 at 11:01 AM Piyush Vijay <piyushvijay.1997(a)gmail.com>
wrote:
Hi,
Me and Devan were discussing about the current pr 'gsoc' which I have made
for the modular javascript code but the pr has lots of unused files which I
have created for making sure that existing code is not breaking and
contains lot of commented out code.
So we have decided to create a new branch in main repo of phpMyAdmin and
multiple pr's from gsoc branch with small changes which can be reviewed and
then merged into the newly created branch and we'll then keep merging this
new branch into master after review and testing.
So I am closing this gsoc pr and will make multiple small pr's from this
branch by cherry-picking the commits.
Any suggestions regarding this would be welcome.
Regards
Piyush Vijay
1:09 p.m.
Thanks Mauricio for creating the new branch.
Regards,
Piyush
[image: Mailtrack]
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality6&>
Sender
notified by
Mailtrack
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality6&>
11/07/18,
22:38:47
On 11 July 2018 at 10:07, Maurício Meneghini Fauth <mauriciofauth(a)gmail.com>
wrote:
Hi.
I think that's a good idea. This will greatly facilitate the review of
pull requests and the development of the GSoC project.
I created a new branch called gsoc-js-refactoring [1] and changed the base
branch of the first PR to that branch [2].
[1] https://github.com/phpmyadmin/phpmyadmin/tree/gsoc-js-refactoring
[2] https://github.com/phpmyadmin/phpmyadmin/pull/14464
Regards,
Maurício
On Fri, Jul 6, 2018 at 11:01 AM Piyush Vijay <piyushvijay.1997(a)gmail.com>
wrote:
Hi,
Me and Devan were discussing about the current pr 'gsoc' which I have
made for the modular javascript code but the pr has lots of unused files
which I have created for making sure that existing code is not breaking and
contains lot of commented out code.
So we have decided to create a new branch in main repo of phpMyAdmin and
multiple pr's from gsoc branch with small changes which can be reviewed and
then merged into the newly created branch and we'll then keep merging this
new branch into master after review and testing.
So I am closing this gsoc pr and will make multiple small pr's from this
branch by cherry-picking the commits.
Any suggestions regarding this would be welcome.
Regards
Piyush Vijay
2207
days inactive
2212
days old
2 comments
2 participants
participants (2)
-
Maurício Meneghini Fauth -
Piyush Vijay