Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: efac710526c3aacb4730566c73ced03a8695b77c https://github.com/phpmyadmin/phpmyadmin/commit/efac710526c3aacb4730566c73ce... Author: Michal Čihař michal@cihar.com Date: 2016-06-16 (Thu, 16 Jun 2016)
Changed paths: M libraries/Message.php
Log Message: ----------- The Html methods accept strings only
Signed-off-by: Michal Čihař michal@cihar.com
Commit: a87c1644356dd33f2642893a863b009e2ebea361 https://github.com/phpmyadmin/phpmyadmin/commit/a87c1644356dd33f2642893a863b... Author: Michal Čihař michal@cihar.com Date: 2016-06-16 (Thu, 16 Jun 2016)
Changed paths: M view_operations.php
Log Message: ----------- Actually get warning messages to display
Signed-off-by: Michal Čihař michal@cihar.com
Commit: a7cd19355474c1a9ea7609c90fdc5d44173b49a1 https://github.com/phpmyadmin/phpmyadmin/commit/a7cd19355474c1a9ea7609c90fdc... Author: Michal Čihař michal@cihar.com Date: 2016-06-16 (Thu, 16 Jun 2016)
Changed paths: M libraries/Message.php M libraries/insert_edit.lib.php M tbl_operations.php M tbl_replace.php M test/classes/MessageTest.php M view_operations.php
Log Message: ----------- Make it clear whether addMessages expects string or Message object
With this, it's way easier to anaylize code for potential problems with escaping.
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 19f76066f2aa0385dd3438f186063ad99e7c8c4a https://github.com/phpmyadmin/phpmyadmin/commit/19f76066f2aa0385dd3438f18606... Author: Michal Čihař michal@cihar.com Date: 2016-06-16 (Thu, 16 Jun 2016)
Changed paths: M libraries/DisplayResults.php M libraries/Message.php M libraries/Util.php M libraries/central_columns.lib.php M libraries/display_export.lib.php M libraries/sql.lib.php M test/bootstrap-dist.php M test/classes/MessageTest.php
Log Message: ----------- Separate adding string and Message objects to Message
This way we can rely on type checking and avoid potential problems with escaping.
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 54a76de3d83f9ee39e554c818e3584c3a3a8cf5e https://github.com/phpmyadmin/phpmyadmin/commit/54a76de3d83f9ee39e554c818e35... Author: Michal Čihař michal@cihar.com Date: 2016-06-16 (Thu, 16 Jun 2016)
Changed paths: M import.php M libraries/Message.php M libraries/rte/rte_events.lib.php M libraries/rte/rte_routines.lib.php M libraries/rte/rte_triggers.lib.php M test/classes/MessageTest.php
Log Message: ----------- 'Replace addString calls with correct method based on content
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 9869a95641bfd630562749bfebf98fecaf8d60b8 https://github.com/phpmyadmin/phpmyadmin/commit/9869a95641bfd630562749bfebf9... Author: Michal Čihař michal@cihar.com Date: 2016-06-16 (Thu, 16 Jun 2016)
Changed paths: M import.php M libraries/DisplayResults.php M libraries/Message.php M libraries/Util.php M libraries/central_columns.lib.php M libraries/display_export.lib.php M libraries/rte/rte_events.lib.php M libraries/rte/rte_routines.lib.php M libraries/rte/rte_triggers.lib.php M libraries/sql.lib.php M test/classes/MessageTest.php
Log Message: ----------- Simplify Message adding methods
The methods are now called based on added type:
- addHtml adds HTML code as is - addText adds text after escaping it - addMessage adds Message instance
Signed-off-by: Michal Čihař michal@cihar.com
Compare: https://github.com/phpmyadmin/phpmyadmin/compare/c6a6bbfb2f6f...9869a95641bf