Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: b8c4ca9cddf287f07aff303748a04cfaa5ace1c7 https://github.com/phpmyadmin/phpmyadmin/commit/b8c4ca9cddf287f07aff303748a0... Author: Michal Čihař michal@cihar.com Date: 2017-05-15 (Mon, 15 May 2017)
Changed paths: M test/classes/AdvisorTest.php
Log Message: ----------- Add tests for advisor functions
We need to ensure these work correctly when refactoring the code.
Issue #6363
Signed-off-by: Michal Čihař michal@cihar.com
Commit: f13476f454a774677f8719c2641802512cab047d https://github.com/phpmyadmin/phpmyadmin/commit/f13476f454a774677f8719c26418... Author: Michal Čihař michal@cihar.com Date: 2017-05-15 (Mon, 15 May 2017)
Changed paths: M composer.json M libraries/Advisor.php M test/classes/AdvisorTest.php
Log Message: ----------- Replace eval() by Symfony\ExpressionLanguage
This is already used by motranslator, so it doed not bring extra dependency and we get rid of the eval() call.
Fixes #6363
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 1c70ed49cb7712e148c144b2664ee87983514843 https://github.com/phpmyadmin/phpmyadmin/commit/1c70ed49cb7712e148c144b2664e... Author: Michal Čihař michal@cihar.com Date: 2017-05-15 (Mon, 15 May 2017)
Changed paths: M libraries/Advisor.php R libraries/advisor.lib.php M test/classes/AdvisorTest.php
Log Message: ----------- Move advisor helpers to the Advisor class
They no longer need to pollute global namespace as they are used only in context of ExpressionLanguage.
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 93d1924179abc489244c29c209d46983bc475b40 https://github.com/phpmyadmin/phpmyadmin/commit/93d1924179abc489244c29c209d4... Author: Michal Čihař michal@cihar.com Date: 2017-05-15 (Mon, 15 May 2017)
Changed paths: M libraries/Advisor.php M test/classes/AdvisorTest.php
Log Message: ----------- Fix name of Advisor::byTime
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 262e22613c4abb2c2596e9a89113dd256562ab26 https://github.com/phpmyadmin/phpmyadmin/commit/262e22613c4abb2c2596e9a89113... Author: Michal Čihař michal@cihar.com Date: 2017-05-16 (Tue, 16 May 2017)
Changed paths: M test/classes/AdvisorTest.php
Log Message: ----------- Complete test coverage for ADVISOR_bytime
Signed-off-by: Michal Čihař michal@cihar.com
Commit: b8087ce80dd70f8ad86d3a9df99f1eb0fc84de41 https://github.com/phpmyadmin/phpmyadmin/commit/b8087ce80dd70f8ad86d3a9df99f... Author: Michal Čihař michal@cihar.com Date: 2017-05-16 (Tue, 16 May 2017)
Changed paths: M test/classes/AdvisorTest.php
Log Message: ----------- Add more complex advisor test
Signed-off-by: Michal Čihař michal@cihar.com
Commit: e788bc2299ec6923e3cd649cd98066ad0e0f1159 https://github.com/phpmyadmin/phpmyadmin/commit/e788bc2299ec6923e3cd649cd980... Author: Michal Čihař michal@cihar.com Date: 2017-05-16 (Tue, 16 May 2017)
Changed paths: M composer.json M libraries/Advisor.php R libraries/advisor.lib.php M test/classes/AdvisorTest.php
Log Message: ----------- Merge pull request #13260 from nijel/advisor-eval
Replace eval() in Advisor by Symfony\ExpressionLanguage
Compare: https://github.com/phpmyadmin/phpmyadmin/compare/ae5ca6e756f4...e788bc2299ec