Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 56c1c9fc5ca035f289b32856a751a69f0b9f97dd https://github.com/phpmyadmin/phpmyadmin/commit/56c1c9fc5ca035f289b32856a751... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/classes/Plugins/Auth/AuthenticationConfig.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php
Log Message: ----------- Share base code for AuthenticationPlugin::authSetUser
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 13d2ff1f5b98db2924e6518a90078416604ad8c8 https://github.com/phpmyadmin/phpmyadmin/commit/13d2ff1f5b98db2924e6518a9007... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/classes/Plugins/Auth/AuthenticationConfig.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/AuthenticationPlugin.php M test/classes/Plugins/Auth/AuthenticationConfigTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php
Log Message: ----------- Consistely use no return value for AuthenticationPlugin::authFails
It really does not return in the end, so make the docs consistent with the code.
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 026d7221781e23480aaa364389e6ec16db4ae9fb https://github.com/phpmyadmin/phpmyadmin/commit/026d7221781e23480aaa364389e6... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/classes/Plugins/Auth/AuthenticationConfig.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/common.inc.php M test/classes/Plugins/Auth/AuthenticationConfigTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php
Log Message: ----------- Rationalize AuthenticationPlugin API
Make the API more consistent, remove not needed auth prefix and stop talking about advanced authentication which has been there about 10 years ago.
API changed:
- authCheck is now readCredentials - authSetUser is now storeCredentials - auth is now showLoginForm - authFails is now showFailure - storeUserCredentials is now rememberCredentials
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 9bc5bfd74cfe4ba386331e9c9d79aec637a00104 https://github.com/phpmyadmin/phpmyadmin/commit/9bc5bfd74cfe4ba386331e9c9d79... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/common.inc.php
Log Message: ----------- Move authentication logic to AuthenticationPlugin
Issue #11731
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 2327dbf3c3c109b907ea478be098c77e80e1bf0b https://github.com/phpmyadmin/phpmyadmin/commit/2327dbf3c3c109b907ea478be098... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/common.inc.php
Log Message: ----------- Move allow/deny rules check to AuthenticationPlugin
Issue #11731
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 62535ea5b982e3175a03cdd6a51d640f5b46abf7 https://github.com/phpmyadmin/phpmyadmin/commit/62535ea5b982e3175a03cdd6a51d... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/classes/Plugins/Auth/AuthenticationConfig.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/common.inc.php M test/classes/Plugins/Auth/AuthenticationConfigTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php
Log Message: ----------- Pass failure reason to showFailure
This way we can avoid relying on global variables to check it.
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 8e8f4bd3bb25279f788d32413212bb3892b2a919 https://github.com/phpmyadmin/phpmyadmin/commit/8e8f4bd3bb25279f788d32413212... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/classes/Plugins/Auth/AuthenticationConfig.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php M test/classes/Plugins/Auth/AuthenticationConfigTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php
Log Message: ----------- Avoid using PHP_AUTH_USER and PHP_AUTH_PW globals for auth
Use object attributes to store the actual credentials and avoid messing up with global variables.
Signed-off-by: Michal Čihař michal@cihar.com
Commit: c1375f4e84f01c9f087e029e4fd15d2b214c8a00 https://github.com/phpmyadmin/phpmyadmin/commit/c1375f4e84f01c9f087e029e4fd1... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/common.inc.php
Log Message: ----------- Remove not needed access through globals
Signed-off-by: Michal Čihař michal@cihar.com
Commit: e020dbfe16bb272a9de312a1b45cdc23bbebeb83 https://github.com/phpmyadmin/phpmyadmin/commit/e020dbfe16bb272a9de312a1b45c... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M test/classes/Plugins/Auth/AuthenticationCookieTest.php
Log Message: ----------- Add test for AuthenticationPlugin::authenticate
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 3f8e1f19e053401f90c0b474845024fa5f91c879 https://github.com/phpmyadmin/phpmyadmin/commit/3f8e1f19e053401f90c0b4748450... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M test/classes/Plugins/Auth/AuthenticationCookieTest.php
Log Message: ----------- Add tests for AuthenticationPlugin::checkRules
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 6cb2963dcf6b40e21d3416ced2f419cfd3e988c7 https://github.com/phpmyadmin/phpmyadmin/commit/6cb2963dcf6b40e21d3416ced2f4... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/classes/Plugins/Auth/AuthenticationCookie.php
Log Message: ----------- Fix createIV documentation
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 6619fe9196be13bb09accc5cf858b0e5f02eb763 https://github.com/phpmyadmin/phpmyadmin/commit/6619fe9196be13bb09accc5cf858... Author: Michal Čihař michal@cihar.com Date: 2017-10-20 (Fri, 20 Oct 2017)
Changed paths: M libraries/classes/Plugins/Auth/AuthenticationCookie.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php
Log Message: ----------- Check return value from cookieDecrypt
This can return false and we should fail early once this happens.
Signed-off-by: Michal Čihař michal@cihar.com
Commit: 41c55cc42ff71c55bb3198f4ab7c14951e5dc1b1 https://github.com/phpmyadmin/phpmyadmin/commit/41c55cc42ff71c55bb3198f4ab7c... Author: Michal Čihař michal@cihar.com Date: 2017-10-23 (Mon, 23 Oct 2017)
Changed paths: M libraries/classes/Plugins/Auth/AuthenticationConfig.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/Auth/AuthenticationHttp.php M libraries/classes/Plugins/Auth/AuthenticationSignon.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/common.inc.php M test/classes/Plugins/Auth/AuthenticationConfigTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Auth/AuthenticationSignonTest.php
Log Message: ----------- Merge pull request #13764 from nijel/auth
Authentication API cleanup
Compare: https://github.com/phpmyadmin/phpmyadmin/compare/10e27f6d726c...41c55cc42ff7