[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 8d9589: Make PHPUnit's assertions stricter

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 8d95891a1963999c878d9c551d9978f810bae22c https://github.com/phpmyadmin/phpmyadmin/commit/8d95891a1963999c878d9c551d9… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2024-02-15 (Thu, 02 February 2024) -03:00 Changed paths: M phpstan-baseline.neon M psalm-baseline.xml M tests/classes/Advisory/AdvisorTest.php M tests/classes/BrowseForeignersTest.php M tests/classes/Charsets/CollationTest.php M tests/classes/Command/TwigLintCommandTest.php M tests/classes/Config/ConfigFileTest.php M tests/classes/Config/DescriptionTest.php M tests/classes/Config/FormDisplayTemplateTest.php M tests/classes/Config/FormDisplayTest.php M tests/classes/Config/FormTest.php M tests/classes/Config/Forms/FormListTest.php M tests/classes/Config/PageSettingsTest.php M tests/classes/Config/ServerConfigChecksTest.php M tests/classes/ConfigStorage/RelationParametersTest.php M tests/classes/ConfigStorage/RelationTest.php M tests/classes/ConfigTest.php M tests/classes/ConsoleTest.php M tests/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M tests/classes/Controllers/Database/Structure/RealRowCountControllerTest.php M tests/classes/Controllers/Database/StructureControllerTest.php M tests/classes/Controllers/Export/Template/CreateControllerTest.php M tests/classes/Controllers/Export/Template/LoadControllerTest.php M tests/classes/Controllers/GisDataEditorControllerTest.php M tests/classes/Controllers/JavaScriptMessagesControllerTest.php M tests/classes/Controllers/Operations/TableControllerTest.php M tests/classes/Controllers/Server/Privileges/AccountLockControllerTest.php M tests/classes/Controllers/Server/Privileges/AccountUnlockControllerTest.php M tests/classes/Controllers/Server/Status/Monitor/GeneralLogControllerTest.php M tests/classes/Controllers/Server/Status/Monitor/LogVarsControllerTest.php M tests/classes/Controllers/Server/Status/Monitor/QueryAnalyzerControllerTest.php M tests/classes/Controllers/Server/Status/Monitor/SlowLogControllerTest.php M tests/classes/Controllers/Server/VariablesControllerTest.php M tests/classes/Controllers/Table/ChangeControllerTest.php M tests/classes/Controllers/Table/FindReplaceControllerTest.php M tests/classes/Controllers/Table/RelationControllerTest.php M tests/classes/Controllers/Table/ReplaceControllerTest.php M tests/classes/Controllers/Table/SearchControllerTest.php M tests/classes/Controllers/Triggers/IndexControllerTest.php M tests/classes/CoreTest.php M tests/classes/CreateAddFieldTest.php M tests/classes/Crypto/CryptoTest.php M tests/classes/Database/CentralColumnsTest.php M tests/classes/Database/Designer/CommonTest.php M tests/classes/Database/DesignerTest.php M tests/classes/Database/EventsTest.php M tests/classes/Database/RoutinesTest.php M tests/classes/Database/SearchTest.php M tests/classes/DatabaseInterfaceTest.php M tests/classes/Dbal/DbiDummyTest.php M tests/classes/Dbal/DbiMysqliTest.php M tests/classes/Display/ResultsTest.php M tests/classes/EncodingTest.php M tests/classes/Engines/BdbTest.php M tests/classes/Engines/BinlogTest.php M tests/classes/Engines/InnodbTest.php M tests/classes/Engines/MemoryTest.php M tests/classes/Engines/MrgMyisamTest.php M tests/classes/Engines/MyisamTest.php M tests/classes/Engines/NdbclusterTest.php M tests/classes/Engines/PbxtTest.php M tests/classes/Engines/PerformanceSchemaTest.php M tests/classes/Error/ErrorHandlerTest.php M tests/classes/Error/ErrorReportTest.php M tests/classes/Error/ErrorTest.php M tests/classes/Export/ExportTest.php M tests/classes/FileListingTest.php M tests/classes/FileTest.php M tests/classes/FlashMessagesTest.php M tests/classes/FontTest.php M tests/classes/FooterTest.php M tests/classes/Gis/Ds/PolygonTest.php M tests/classes/Gis/GisGeometryCollectionTest.php M tests/classes/Gis/GisGeometryTest.php M tests/classes/Gis/GisLineStringTest.php M tests/classes/Gis/GisMultiLineStringTest.php M tests/classes/Gis/GisMultiPointTest.php M tests/classes/Gis/GisMultiPolygonTest.php M tests/classes/Gis/GisPointTest.php M tests/classes/Gis/GisPolygonTest.php M tests/classes/Gis/GisVisualizationTest.php M tests/classes/GitTest.php M tests/classes/HeaderTest.php M tests/classes/Html/GeneratorTest.php M tests/classes/Html/MySQLDocumentationTest.php M tests/classes/Http/Middleware/TokenRequestParamCheckingTest.php M tests/classes/Identifiers/DatabaseNameTest.php M tests/classes/Identifiers/TableNameTest.php M tests/classes/Identifiers/TriggerNameTest.php M tests/classes/Import/ImportTest.php M tests/classes/Import/SimulateDmlTest.php M tests/classes/IndexColumnTest.php M tests/classes/IndexTest.php M tests/classes/InsertEditTest.php M tests/classes/IpAllowDenyTest.php M tests/classes/LanguageTest.php M tests/classes/LinterTest.php M tests/classes/ListDatabaseTest.php M tests/classes/LoggingTest.php M tests/classes/MessageTest.php M tests/classes/MimeTest.php M tests/classes/Navigation/Nodes/NodeDatabaseTest.php M tests/classes/Navigation/Nodes/NodeEventContainerTest.php M tests/classes/Navigation/Nodes/NodeEventTest.php M tests/classes/Navigation/Nodes/NodeFunctionContainerTest.php M tests/classes/Navigation/Nodes/NodeFunctionTest.php M tests/classes/Navigation/Nodes/NodeIndexContainerTest.php M tests/classes/Navigation/Nodes/NodeIndexTest.php M tests/classes/Navigation/Nodes/NodeProcedureContainerTest.php M tests/classes/Navigation/Nodes/NodeProcedureTest.php M tests/classes/Navigation/Nodes/NodeTableContainerTest.php M tests/classes/Navigation/Nodes/NodeTableTest.php M tests/classes/Navigation/Nodes/NodeTest.php M tests/classes/Navigation/Nodes/NodeTriggerContainerTest.php M tests/classes/Navigation/Nodes/NodeTriggerTest.php M tests/classes/Navigation/Nodes/NodeViewContainerTest.php M tests/classes/Navigation/Nodes/NodeViewTest.php M tests/classes/NormalizationTest.php M tests/classes/OperationsTest.php M tests/classes/Partitioning/PartitionTest.php M tests/classes/Partitioning/SubPartitionTest.php M tests/classes/Partitioning/TablePartitionDefinitionTest.php M tests/classes/Plugins/Auth/AuthenticationCookieTest.php M tests/classes/Plugins/Auth/AuthenticationHttpTest.php M tests/classes/Plugins/Auth/AuthenticationSignonTest.php M tests/classes/Plugins/Export/ExportCodegenTest.php M tests/classes/Plugins/Export/ExportCsvTest.php M tests/classes/Plugins/Export/ExportExcelTest.php M tests/classes/Plugins/Export/ExportHtmlwordTest.php M tests/classes/Plugins/Export/ExportJsonTest.php M tests/classes/Plugins/Export/ExportLatexTest.php M tests/classes/Plugins/Export/ExportMediawikiTest.php M tests/classes/Plugins/Export/ExportOdsTest.php M tests/classes/Plugins/Export/ExportOdtTest.php M tests/classes/Plugins/Export/ExportPdfTest.php M tests/classes/Plugins/Export/ExportPhparrayTest.php M tests/classes/Plugins/Export/ExportSqlTest.php M tests/classes/Plugins/Export/ExportTexytextTest.php M tests/classes/Plugins/Export/ExportXmlTest.php M tests/classes/Plugins/Export/ExportYamlTest.php M tests/classes/Plugins/Export/Helpers/TablePropertyTest.php M tests/classes/Plugins/Import/ImportCsvTest.php M tests/classes/Plugins/Import/ImportLdiTest.php M tests/classes/Plugins/Import/ImportMediawikiTest.php M tests/classes/Plugins/Import/ImportOdsTest.php M tests/classes/Plugins/Import/ImportShpTest.php M tests/classes/Plugins/Import/ImportXmlTest.php M tests/classes/Plugins/Schema/DiaRelationSchemaTest.php M tests/classes/Plugins/Schema/EpsRelationSchemaTest.php M tests/classes/Plugins/Schema/ExportRelationSchemaTest.php M tests/classes/Plugins/Schema/PdfRelationSchemaTest.php M tests/classes/Plugins/Schema/SvgRelationSchemaTest.php M tests/classes/Plugins/Transformations/TransformationPluginsTest.php M tests/classes/Plugins/TwoFactor/WebAuthnTest.php M tests/classes/PluginsTest.php M tests/classes/Properties/Options/Groups/OptionsPropertyMainGroupTest.php M tests/classes/Properties/Options/Groups/OptionsPropertyRootGroupTest.php M tests/classes/Properties/Options/Groups/OptionsPropertySubgroupTest.php M tests/classes/Properties/Options/Items/PropertyItemsTest.php M tests/classes/Properties/Options/OptionsPropertyGroupTest.php M tests/classes/Properties/Options/OptionsPropertyItemTest.php M tests/classes/Properties/Options/OptionsPropertyOneItemTest.php M tests/classes/Properties/Plugins/ExportPluginPropertiesTest.php M tests/classes/Properties/Plugins/ImportPluginPropertiesTest.php M tests/classes/Properties/Plugins/PluginPropertyItemTest.php M tests/classes/Properties/PropertyItemTest.php M tests/classes/Query/GeneratorTest.php M tests/classes/Routing/RoutingTest.php M tests/classes/SanitizeTest.php M tests/classes/ScriptsTest.php M tests/classes/Server/PluginsTest.php M tests/classes/Server/PrivilegesTest.php M tests/classes/Server/SysInfo/SysInfoTest.php M tests/classes/Setup/ConfigGeneratorTest.php M tests/classes/Setup/IndexTest.php M tests/classes/ShowGrantsTest.php M tests/classes/SqlTest.php M tests/classes/StorageEngineTest.php M tests/classes/SystemDatabaseTest.php M tests/classes/Table/IndexesTest.php M tests/classes/Table/SearchTest.php M tests/classes/Table/TableTest.php M tests/classes/TemplateTest.php M tests/classes/Theme/ThemeManagerTest.php M tests/classes/Theme/ThemeTest.php M tests/classes/Tracking/TrackerTest.php M tests/classes/Tracking/TrackingCheckerTest.php M tests/classes/Tracking/TrackingTest.php M tests/classes/TransformationsTest.php M tests/classes/Triggers/TriggersTest.php M tests/classes/TwoFactorTest.php M tests/classes/TypesByDatabaseVersionTest.php M tests/classes/TypesTest.php M tests/classes/UniqueConditionTest.php M tests/classes/UrlTest.php M tests/classes/UserPreferencesTest.php M tests/classes/UtilTest.php M tests/classes/Utils/ForeignKeyTest.php M tests/classes/Utils/FormatConverterTest.php M tests/classes/Utils/GisTest.php M tests/classes/Utils/SessionCacheTest.php M tests/classes/VersionInformationTest.php M tests/classes/WebAuthn/WebauthnLibServerTest.php M tests/classes/ZipExtensionTest.php Log Message: ----------- Make PHPUnit's assertions stricter Only replaces assertEquals with assertSame where it doesn't causes the test to fail. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: e07c692841a31181b85dd3175aa93dda61414bee https://github.com/phpmyadmin/phpmyadmin/commit/e07c692841a31181b85dd3175aa… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2024-02-16 (Fri, 02 February 2024) -03:00 Changed paths: M phpstan-baseline.neon M psalm-baseline.xml M tests/classes/Advisory/AdvisorTest.php M tests/classes/BrowseForeignersTest.php M tests/classes/Charsets/CollationTest.php M tests/classes/Command/TwigLintCommandTest.php M tests/classes/Config/ConfigFileTest.php M tests/classes/Config/DescriptionTest.php M tests/classes/Config/FormDisplayTemplateTest.php M tests/classes/Config/FormDisplayTest.php M tests/classes/Config/FormTest.php M tests/classes/Config/Forms/FormListTest.php M tests/classes/Config/PageSettingsTest.php M tests/classes/Config/ServerConfigChecksTest.php M tests/classes/ConfigStorage/RelationParametersTest.php M tests/classes/ConfigStorage/RelationTest.php M tests/classes/ConfigTest.php M tests/classes/ConsoleTest.php M tests/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M tests/classes/Controllers/Database/Structure/RealRowCountControllerTest.php M tests/classes/Controllers/Database/StructureControllerTest.php M tests/classes/Controllers/Export/Template/CreateControllerTest.php M tests/classes/Controllers/Export/Template/LoadControllerTest.php M tests/classes/Controllers/GisDataEditorControllerTest.php M tests/classes/Controllers/JavaScriptMessagesControllerTest.php M tests/classes/Controllers/Operations/TableControllerTest.php M tests/classes/Controllers/Server/Privileges/AccountLockControllerTest.php M tests/classes/Controllers/Server/Privileges/AccountUnlockControllerTest.php M tests/classes/Controllers/Server/Status/Monitor/GeneralLogControllerTest.php M tests/classes/Controllers/Server/Status/Monitor/LogVarsControllerTest.php M tests/classes/Controllers/Server/Status/Monitor/QueryAnalyzerControllerTest.php M tests/classes/Controllers/Server/Status/Monitor/SlowLogControllerTest.php M tests/classes/Controllers/Server/VariablesControllerTest.php M tests/classes/Controllers/Table/ChangeControllerTest.php M tests/classes/Controllers/Table/FindReplaceControllerTest.php M tests/classes/Controllers/Table/RelationControllerTest.php M tests/classes/Controllers/Table/ReplaceControllerTest.php M tests/classes/Controllers/Table/SearchControllerTest.php M tests/classes/Controllers/Triggers/IndexControllerTest.php M tests/classes/CoreTest.php M tests/classes/CreateAddFieldTest.php M tests/classes/Crypto/CryptoTest.php M tests/classes/Database/CentralColumnsTest.php M tests/classes/Database/Designer/CommonTest.php M tests/classes/Database/DesignerTest.php M tests/classes/Database/EventsTest.php M tests/classes/Database/RoutinesTest.php M tests/classes/Database/SearchTest.php M tests/classes/DatabaseInterfaceTest.php M tests/classes/Dbal/DbiDummyTest.php M tests/classes/Dbal/DbiMysqliTest.php M tests/classes/Display/ResultsTest.php M tests/classes/EncodingTest.php M tests/classes/Engines/BdbTest.php M tests/classes/Engines/BinlogTest.php M tests/classes/Engines/InnodbTest.php M tests/classes/Engines/MemoryTest.php M tests/classes/Engines/MrgMyisamTest.php M tests/classes/Engines/MyisamTest.php M tests/classes/Engines/NdbclusterTest.php M tests/classes/Engines/PbxtTest.php M tests/classes/Engines/PerformanceSchemaTest.php M tests/classes/Error/ErrorHandlerTest.php M tests/classes/Error/ErrorReportTest.php M tests/classes/Error/ErrorTest.php M tests/classes/Export/ExportTest.php M tests/classes/FileListingTest.php M tests/classes/FileTest.php M tests/classes/FlashMessagesTest.php M tests/classes/FontTest.php M tests/classes/FooterTest.php M tests/classes/Gis/Ds/PolygonTest.php M tests/classes/Gis/GisGeometryCollectionTest.php M tests/classes/Gis/GisGeometryTest.php M tests/classes/Gis/GisLineStringTest.php M tests/classes/Gis/GisMultiLineStringTest.php M tests/classes/Gis/GisMultiPointTest.php M tests/classes/Gis/GisMultiPolygonTest.php M tests/classes/Gis/GisPointTest.php M tests/classes/Gis/GisPolygonTest.php M tests/classes/Gis/GisVisualizationTest.php M tests/classes/GitTest.php M tests/classes/HeaderTest.php M tests/classes/Html/GeneratorTest.php M tests/classes/Html/MySQLDocumentationTest.php M tests/classes/Http/Middleware/TokenRequestParamCheckingTest.php M tests/classes/Identifiers/DatabaseNameTest.php M tests/classes/Identifiers/TableNameTest.php M tests/classes/Identifiers/TriggerNameTest.php M tests/classes/Import/ImportTest.php M tests/classes/Import/SimulateDmlTest.php M tests/classes/IndexColumnTest.php M tests/classes/IndexTest.php M tests/classes/InsertEditTest.php M tests/classes/IpAllowDenyTest.php M tests/classes/LanguageTest.php M tests/classes/LinterTest.php M tests/classes/ListDatabaseTest.php M tests/classes/LoggingTest.php M tests/classes/MessageTest.php M tests/classes/MimeTest.php M tests/classes/Navigation/Nodes/NodeDatabaseTest.php M tests/classes/Navigation/Nodes/NodeEventContainerTest.php M tests/classes/Navigation/Nodes/NodeEventTest.php M tests/classes/Navigation/Nodes/NodeFunctionContainerTest.php M tests/classes/Navigation/Nodes/NodeFunctionTest.php M tests/classes/Navigation/Nodes/NodeIndexContainerTest.php M tests/classes/Navigation/Nodes/NodeIndexTest.php M tests/classes/Navigation/Nodes/NodeProcedureContainerTest.php M tests/classes/Navigation/Nodes/NodeProcedureTest.php M tests/classes/Navigation/Nodes/NodeTableContainerTest.php M tests/classes/Navigation/Nodes/NodeTableTest.php M tests/classes/Navigation/Nodes/NodeTest.php M tests/classes/Navigation/Nodes/NodeTriggerContainerTest.php M tests/classes/Navigation/Nodes/NodeTriggerTest.php M tests/classes/Navigation/Nodes/NodeViewContainerTest.php M tests/classes/Navigation/Nodes/NodeViewTest.php M tests/classes/NormalizationTest.php M tests/classes/OperationsTest.php M tests/classes/Partitioning/PartitionTest.php M tests/classes/Partitioning/SubPartitionTest.php M tests/classes/Partitioning/TablePartitionDefinitionTest.php M tests/classes/Plugins/Auth/AuthenticationCookieTest.php M tests/classes/Plugins/Auth/AuthenticationHttpTest.php M tests/classes/Plugins/Auth/AuthenticationSignonTest.php M tests/classes/Plugins/Export/ExportCodegenTest.php M tests/classes/Plugins/Export/ExportCsvTest.php M tests/classes/Plugins/Export/ExportExcelTest.php M tests/classes/Plugins/Export/ExportHtmlwordTest.php M tests/classes/Plugins/Export/ExportJsonTest.php M tests/classes/Plugins/Export/ExportLatexTest.php M tests/classes/Plugins/Export/ExportMediawikiTest.php M tests/classes/Plugins/Export/ExportOdsTest.php M tests/classes/Plugins/Export/ExportOdtTest.php M tests/classes/Plugins/Export/ExportPdfTest.php M tests/classes/Plugins/Export/ExportPhparrayTest.php M tests/classes/Plugins/Export/ExportSqlTest.php M tests/classes/Plugins/Export/ExportTexytextTest.php M tests/classes/Plugins/Export/ExportXmlTest.php M tests/classes/Plugins/Export/ExportYamlTest.php M tests/classes/Plugins/Export/Helpers/TablePropertyTest.php M tests/classes/Plugins/Import/ImportCsvTest.php M tests/classes/Plugins/Import/ImportLdiTest.php M tests/classes/Plugins/Import/ImportMediawikiTest.php M tests/classes/Plugins/Import/ImportOdsTest.php M tests/classes/Plugins/Import/ImportShpTest.php M tests/classes/Plugins/Import/ImportXmlTest.php M tests/classes/Plugins/Schema/DiaRelationSchemaTest.php M tests/classes/Plugins/Schema/EpsRelationSchemaTest.php M tests/classes/Plugins/Schema/ExportRelationSchemaTest.php M tests/classes/Plugins/Schema/PdfRelationSchemaTest.php M tests/classes/Plugins/Schema/SvgRelationSchemaTest.php M tests/classes/Plugins/Transformations/TransformationPluginsTest.php M tests/classes/Plugins/TwoFactor/WebAuthnTest.php M tests/classes/PluginsTest.php M tests/classes/Properties/Options/Groups/OptionsPropertyMainGroupTest.php M tests/classes/Properties/Options/Groups/OptionsPropertyRootGroupTest.php M tests/classes/Properties/Options/Groups/OptionsPropertySubgroupTest.php M tests/classes/Properties/Options/Items/PropertyItemsTest.php M tests/classes/Properties/Options/OptionsPropertyGroupTest.php M tests/classes/Properties/Options/OptionsPropertyItemTest.php M tests/classes/Properties/Options/OptionsPropertyOneItemTest.php M tests/classes/Properties/Plugins/ExportPluginPropertiesTest.php M tests/classes/Properties/Plugins/ImportPluginPropertiesTest.php M tests/classes/Properties/Plugins/PluginPropertyItemTest.php M tests/classes/Properties/PropertyItemTest.php M tests/classes/Query/GeneratorTest.php M tests/classes/Routing/RoutingTest.php M tests/classes/SanitizeTest.php M tests/classes/ScriptsTest.php M tests/classes/Server/PluginsTest.php M tests/classes/Server/PrivilegesTest.php M tests/classes/Server/SysInfo/SysInfoTest.php M tests/classes/Setup/ConfigGeneratorTest.php M tests/classes/Setup/IndexTest.php M tests/classes/ShowGrantsTest.php M tests/classes/SqlTest.php M tests/classes/StorageEngineTest.php M tests/classes/SystemDatabaseTest.php M tests/classes/Table/IndexesTest.php M tests/classes/Table/SearchTest.php M tests/classes/Table/TableTest.php M tests/classes/TemplateTest.php M tests/classes/Theme/ThemeManagerTest.php M tests/classes/Theme/ThemeTest.php M tests/classes/Tracking/TrackerTest.php M tests/classes/Tracking/TrackingCheckerTest.php M tests/classes/Tracking/TrackingTest.php M tests/classes/TransformationsTest.php M tests/classes/Triggers/TriggersTest.php M tests/classes/TwoFactorTest.php M tests/classes/TypesByDatabaseVersionTest.php M tests/classes/TypesTest.php M tests/classes/UniqueConditionTest.php M tests/classes/UrlTest.php M tests/classes/UserPreferencesTest.php M tests/classes/UtilTest.php M tests/classes/Utils/ForeignKeyTest.php M tests/classes/Utils/FormatConverterTest.php M tests/classes/Utils/GisTest.php M tests/classes/Utils/SessionCacheTest.php M tests/classes/VersionInformationTest.php M tests/classes/WebAuthn/WebauthnLibServerTest.php M tests/classes/ZipExtensionTest.php Log Message: ----------- Merge pull request #18993 from MauricioFauth/phpunit-assert-same Make PHPUnit's assertions stricter