[phpMyAdmin Git] [phpmyadmin/phpmyadmin] 9e9611: Replace config global with Config singleton

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 9e9611d1622785e9ff6135da897ce0849b2ce726 https://github.com/phpmyadmin/phpmyadmin/commit/9e9611d1622785e9ff6135da897… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-15 (Tue, 08 August 2023) -03:00 Changed paths: M libraries/classes/Application.php M libraries/classes/Command/CacheWarmupCommand.php M libraries/classes/Config.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Config/PageSettings.php M libraries/classes/Config/Validator.php M libraries/classes/Controllers/Database/ImportController.php M libraries/classes/Controllers/Preferences/ManageController.php M libraries/classes/Controllers/Server/ImportController.php M libraries/classes/Controllers/Setup/HomeController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ImportController.php M libraries/classes/Core.php M libraries/classes/Crypto/Crypto.php M libraries/classes/Encoding.php M libraries/classes/ErrorHandler.php M libraries/classes/Export/Export.php M libraries/classes/Export/Options.php M libraries/classes/File.php M libraries/classes/Header.php M libraries/classes/InsertEdit.php M libraries/classes/LanguageManager.php M libraries/classes/Plugins/Auth/AuthenticationConfig.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Plugins/Import/ImportShp.php M libraries/classes/Plugins/Transformations/Abs/InlineTransformationsPlugin.php M libraries/classes/Plugins/TwoFactor/Key.php M libraries/classes/Plugins/TwoFactorPlugin.php M libraries/classes/ResponseRenderer.php M libraries/classes/Sanitize.php M libraries/classes/SqlQueryForm.php M libraries/classes/Template.php M libraries/classes/Theme/ThemeManager.php M libraries/classes/Url.php M libraries/services.php M phpstan-baseline.neon M psalm-baseline.xml M psalm.xml M test/classes/AbstractTestCase.php M test/classes/ApplicationTest.php M test/classes/Command/TwigLintCommandTest.php M test/classes/Config/FormDisplayTest.php M test/classes/Config/Forms/FormListTest.php M test/classes/ConfigTest.php M test/classes/Controllers/BrowseForeignersControllerTest.php M test/classes/Controllers/Export/ExportControllerTest.php M test/classes/Controllers/Server/Status/AdvisorControllerTest.php M test/classes/Controllers/Server/Status/Monitor/GeneralLogControllerTest.php M test/classes/Controllers/Server/Status/Monitor/LogVarsControllerTest.php M test/classes/Controllers/Server/Status/Monitor/QueryAnalyzerControllerTest.php M test/classes/Controllers/Server/Status/Monitor/SlowLogControllerTest.php M test/classes/Controllers/Server/Status/MonitorControllerTest.php M test/classes/Controllers/Server/Status/Processes/RefreshControllerTest.php M test/classes/Controllers/Server/Status/ProcessesControllerTest.php M test/classes/Controllers/Server/Status/QueriesControllerTest.php M test/classes/Controllers/Server/Status/StatusControllerTest.php M test/classes/Controllers/Server/Status/VariablesControllerTest.php M test/classes/Controllers/Table/AddFieldControllerTest.php M test/classes/Controllers/Table/CreateControllerTest.php M test/classes/Controllers/Table/DeleteRowsControllerTest.php M test/classes/Controllers/Table/ExportControllerTest.php M test/classes/Controllers/Table/ImportControllerTest.php M test/classes/Controllers/Table/OperationsControllerTest.php M test/classes/Controllers/Table/SqlControllerTest.php M test/classes/Controllers/Table/StructureControllerTest.php M test/classes/CoreTest.php M test/classes/Crypto/CryptoTest.php M test/classes/ErrorHandlerTest.php M test/classes/ErrorReportTest.php M test/classes/Export/OptionsTest.php M test/classes/InsertEditTest.php M test/classes/LanguageTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/TwoFactorTest.php M test/classes/UrlTest.php M test/classes/UserPreferencesTest.php Log Message: ----------- Replace config global with Config singleton This is as bad as the global variable, however at least will have better static analysis of it. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 1fc7f7f807af7bca5b66c7c1a231309fd183dbce https://github.com/phpmyadmin/phpmyadmin/commit/1fc7f7f807af7bca5b66c7c1a23… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-08-15 (Tue, 08 August 2023) -03:00 Changed paths: M libraries/classes/Application.php M libraries/classes/Command/CacheWarmupCommand.php M libraries/classes/Config.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Config/PageSettings.php M libraries/classes/Config/Validator.php M libraries/classes/Controllers/Database/ImportController.php M libraries/classes/Controllers/Preferences/ManageController.php M libraries/classes/Controllers/Server/ImportController.php M libraries/classes/Controllers/Setup/HomeController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ImportController.php M libraries/classes/Core.php M libraries/classes/Crypto/Crypto.php M libraries/classes/Encoding.php M libraries/classes/ErrorHandler.php M libraries/classes/Export/Export.php M libraries/classes/Export/Options.php M libraries/classes/File.php M libraries/classes/Header.php M libraries/classes/InsertEdit.php M libraries/classes/LanguageManager.php M libraries/classes/Plugins/Auth/AuthenticationConfig.php M libraries/classes/Plugins/Auth/AuthenticationCookie.php M libraries/classes/Plugins/AuthenticationPlugin.php M libraries/classes/Plugins/Import/ImportShp.php M libraries/classes/Plugins/Transformations/Abs/InlineTransformationsPlugin.php M libraries/classes/Plugins/TwoFactor/Key.php M libraries/classes/Plugins/TwoFactorPlugin.php M libraries/classes/ResponseRenderer.php M libraries/classes/Sanitize.php M libraries/classes/SqlQueryForm.php M libraries/classes/Template.php M libraries/classes/Theme/ThemeManager.php M libraries/classes/Url.php M libraries/services.php M phpstan-baseline.neon M psalm-baseline.xml M psalm.xml M test/classes/AbstractTestCase.php M test/classes/ApplicationTest.php M test/classes/Command/TwigLintCommandTest.php M test/classes/Config/FormDisplayTest.php M test/classes/Config/Forms/FormListTest.php M test/classes/ConfigTest.php M test/classes/Controllers/BrowseForeignersControllerTest.php M test/classes/Controllers/Export/ExportControllerTest.php M test/classes/Controllers/Server/Status/AdvisorControllerTest.php M test/classes/Controllers/Server/Status/Monitor/GeneralLogControllerTest.php M test/classes/Controllers/Server/Status/Monitor/LogVarsControllerTest.php M test/classes/Controllers/Server/Status/Monitor/QueryAnalyzerControllerTest.php M test/classes/Controllers/Server/Status/Monitor/SlowLogControllerTest.php M test/classes/Controllers/Server/Status/MonitorControllerTest.php M test/classes/Controllers/Server/Status/Processes/RefreshControllerTest.php M test/classes/Controllers/Server/Status/ProcessesControllerTest.php M test/classes/Controllers/Server/Status/QueriesControllerTest.php M test/classes/Controllers/Server/Status/StatusControllerTest.php M test/classes/Controllers/Server/Status/VariablesControllerTest.php M test/classes/Controllers/Table/AddFieldControllerTest.php M test/classes/Controllers/Table/CreateControllerTest.php M test/classes/Controllers/Table/DeleteRowsControllerTest.php M test/classes/Controllers/Table/ExportControllerTest.php M test/classes/Controllers/Table/ImportControllerTest.php M test/classes/Controllers/Table/OperationsControllerTest.php M test/classes/Controllers/Table/SqlControllerTest.php M test/classes/Controllers/Table/StructureControllerTest.php M test/classes/CoreTest.php M test/classes/Crypto/CryptoTest.php M test/classes/ErrorHandlerTest.php M test/classes/ErrorReportTest.php M test/classes/Export/OptionsTest.php M test/classes/InsertEditTest.php M test/classes/LanguageTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/TwoFactorTest.php M test/classes/UrlTest.php M test/classes/UserPreferencesTest.php Log Message: ----------- Merge pull request #18626 from MauricioFauth/config-global Replace config global with Config singleton