Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c411121fd808bb6c82b9f7444b4ea27be88fe643 https://github.com/phpmyadmin/phpmyadmin/commit/c411121fd808bb6c82b9f7444b4e... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2021-12-17 (Fri, 12 December 2021) -03:00
Changed paths: A libraries/classes/ConfigStorage/Relation.php A libraries/classes/ConfigStorage/RelationCleanup.php A libraries/classes/ConfigStorage/RelationParameters.php A test/classes/ConfigStorage/RelationCleanupTest.php A test/classes/ConfigStorage/RelationParametersTest.php A test/classes/ConfigStorage/RelationTest.php M libraries/classes/Bookmark.php M libraries/classes/Console.php M libraries/classes/Controllers/BrowseForeignersController.php M libraries/classes/Controllers/CheckRelationsController.php M libraries/classes/Controllers/Database/DataDictionaryController.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Database/QueryByExampleController.php M libraries/classes/Controllers/Database/Structure/DropTableController.php M libraries/classes/Controllers/Database/Structure/EmptyTableController.php M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/Export/Template/CreateController.php M libraries/classes/Controllers/Export/Template/DeleteController.php M libraries/classes/Controllers/Export/Template/LoadController.php M libraries/classes/Controllers/Export/Template/UpdateController.php M libraries/classes/Controllers/HomeController.php M libraries/classes/Controllers/NavigationController.php M libraries/classes/Controllers/Preferences/ExportController.php M libraries/classes/Controllers/Preferences/FeaturesController.php M libraries/classes/Controllers/Preferences/ImportController.php M libraries/classes/Controllers/Preferences/MainPanelController.php M libraries/classes/Controllers/Preferences/ManageController.php M libraries/classes/Controllers/Preferences/NavigationController.php M libraries/classes/Controllers/Preferences/SqlController.php M libraries/classes/Controllers/Preferences/TwoFactorController.php M libraries/classes/Controllers/Server/Databases/DestroyController.php M libraries/classes/Controllers/Server/DatabasesController.php M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Controllers/Server/UserGroupsController.php M libraries/classes/Controllers/Server/UserGroupsFormController.php M libraries/classes/Controllers/Table/AddFieldController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/CreateController.php M libraries/classes/Controllers/Table/DeleteRowsController.php M libraries/classes/Controllers/Table/DropColumnController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/RelationController.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/Structure/ChangeController.php M libraries/classes/Controllers/Table/Structure/SaveController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Database/Designer.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Database/MultiTableQuery.php M libraries/classes/Database/Qbe.php M libraries/classes/DatabaseInterface.php M libraries/classes/Display/Results.php M libraries/classes/ErrorReport.php M libraries/classes/Export/Options.php M libraries/classes/Footer.php M libraries/classes/Header.php M libraries/classes/InsertEdit.php M libraries/classes/Menu.php M libraries/classes/Navigation/Navigation.php M libraries/classes/Navigation/Nodes/Node.php M libraries/classes/Normalization.php M libraries/classes/Operations.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/ExportPlugin.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/Plugins/Schema/Pdf/Pdf.php M libraries/classes/Plugins/Schema/TableStats.php M libraries/classes/RecentFavoriteTable.php M libraries/classes/SavedSearches.php M libraries/classes/Server/Privileges.php M libraries/classes/Server/UserGroups.php M libraries/classes/Sql.php M libraries/classes/SystemDatabase.php M libraries/classes/Table.php M libraries/classes/Table/ColumnsDefinition.php M libraries/classes/Tracker.php M libraries/classes/Tracking.php M libraries/classes/Transformations.php M libraries/classes/Twig/RelationExtension.php M libraries/classes/UserPreferences.php M libraries/services.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/CheckRelationsControllerTest.php M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M test/classes/Controllers/Database/StructureControllerTest.php M test/classes/Controllers/Export/Template/CreateControllerTest.php M test/classes/Controllers/Export/Template/DeleteControllerTest.php M test/classes/Controllers/Export/Template/LoadControllerTest.php M test/classes/Controllers/Export/Template/UpdateControllerTest.php M test/classes/Controllers/Server/Databases/DestroyControllerTest.php M test/classes/Controllers/Server/DatabasesControllerTest.php M test/classes/Controllers/Table/RelationControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Controllers/Table/Structure/ChangeControllerTest.php M test/classes/Controllers/Table/Structure/SaveControllerTest.php M test/classes/Database/Designer/CommonTest.php M test/classes/Database/DesignerTest.php M test/classes/Database/QbeTest.php M test/classes/DatabaseInterfaceTest.php M test/classes/ErrorReportTest.php M test/classes/Export/OptionsTest.php M test/classes/Navigation/NavigationTest.php M test/classes/NormalizationTest.php M test/classes/OperationsTest.php M test/classes/Plugins/Export/ExportHtmlwordTest.php M test/classes/Plugins/Export/ExportLatexTest.php M test/classes/Plugins/Export/ExportOdtTest.php M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Plugins/Export/ExportTexytextTest.php M test/classes/Server/PrivilegesTest.php M test/classes/SqlTest.php M test/classes/TableTest.php M test/classes/TrackingTest.php M test/classes/UserPasswordTest.php D libraries/classes/Relation.php D libraries/classes/RelationCleanup.php D libraries/classes/RelationParameters.php D test/classes/RelationCleanupTest.php D test/classes/RelationParametersTest.php D test/classes/RelationTest.php
Log Message: ----------- Move Relation classes into the ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Commit: 995ec44d13cee4b26cdd6439f6366425add87b40 https://github.com/phpmyadmin/phpmyadmin/commit/995ec44d13cee4b26cdd6439f636... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2021-12-17 (Fri, 12 December 2021) -03:00
Changed paths: M libraries/classes/Common.php M libraries/classes/ConfigStorage/Relation.php M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbalInterface.php M libraries/classes/TwoFactor.php M psalm-baseline.xml M test/classes/ConfigStorage/RelationTest.php M test/classes/DatabaseInterfaceTest.php
Log Message: ----------- Move `DatabaseInterface::initRelationParamsCache` method to Relation class
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Commit: cb3f7fbb16c0d54414fed049d8e0c1c1e03d56db https://github.com/phpmyadmin/phpmyadmin/commit/cb3f7fbb16c0d54414fed049d8e0... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2021-12-17 (Fri, 12 December 2021) -03:00
Changed paths: A libraries/classes/ConfigStorage/UserGroups.php A test/classes/ConfigStorage/UserGroupsTest.php M libraries/classes/Controllers/Server/UserGroupsController.php M phpstan-baseline.neon M psalm-baseline.xml D libraries/classes/Server/UserGroups.php D test/classes/Server/UserGroupsTest.php
Log Message: ----------- Move Server\UserGroups to ConfigStorage namespace
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Commit: aaee7961c151225f555c1f41533078db082bed3e https://github.com/phpmyadmin/phpmyadmin/commit/aaee7961c151225f555c1f415330... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2021-12-17 (Fri, 12 December 2021) -03:00
Changed paths: M libraries/classes/ConfigStorage/Relation.php M libraries/services.php M test/classes/Controllers/CheckRelationsControllerTest.php M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M test/classes/Controllers/Export/Template/CreateControllerTest.php M test/classes/Controllers/Export/Template/DeleteControllerTest.php M test/classes/Controllers/Export/Template/LoadControllerTest.php M test/classes/Controllers/Export/Template/UpdateControllerTest.php M test/classes/Controllers/Server/Databases/DestroyControllerTest.php M test/classes/Controllers/Server/DatabasesControllerTest.php M test/classes/Controllers/Table/RelationControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Controllers/Table/Structure/ChangeControllerTest.php M test/classes/Controllers/Table/Structure/SaveControllerTest.php M test/classes/Database/DesignerTest.php M test/classes/ErrorReportTest.php M test/classes/NormalizationTest.php
Log Message: ----------- Remove `Template` dependency from `Relation` class
Related to 2299a62e49c223b162929e6dad0477617001cb69.
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Commit: ce18740be4c8455f4dd101d3b3e2297c0898a55a https://github.com/phpmyadmin/phpmyadmin/commit/ce18740be4c8455f4dd101d3b3e2... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2021-12-17 (Fri, 12 December 2021) -03:00
Changed paths: M libraries/classes/Config.php M libraries/classes/ConfigStorage/Relation.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Command/TwigLintCommandTest.php M test/classes/ConfigStorage/RelationTest.php M test/classes/ErrorReportTest.php
Log Message: ----------- Remove passing `null` to `Relation`'s constructor
Related to d296860a673015a8d380d3ee4f6287cdb65d938b.
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Commit: 42e4dd519e0244bb4b06b1c478c69adb93136883 https://github.com/phpmyadmin/phpmyadmin/commit/42e4dd519e0244bb4b06b1c478c6... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2021-12-17 (Fri, 12 December 2021) -03:00
Changed paths: M libraries/classes/ConfigStorage/Relation.php M psalm-baseline.xml M test/classes/ConfigStorage/RelationTest.php
Log Message: ----------- Refactor `Relation::getRelationParameters` method
Makes checkRelationsParam method private. Saves 'relation' to Session from RelationParameters class
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Commit: bf49480160aa02b760ef9a4fa9286dbbf4a3fa85 https://github.com/phpmyadmin/phpmyadmin/commit/bf49480160aa02b760ef9a4fa928... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2021-12-17 (Fri, 12 December 2021) -03:00
Changed paths: M psalm-baseline.xml M test/classes/ConfigStorage/RelationCleanupTest.php M test/classes/ConfigStorage/RelationTest.php M test/classes/ConfigStorage/UserGroupsTest.php M test/classes/Controllers/Export/Template/CreateControllerTest.php M test/classes/Controllers/Export/Template/LoadControllerTest.php M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/Database/CentralColumnsTest.php M test/classes/Database/Designer/CommonTest.php M test/classes/Display/ResultsTest.php M test/classes/Export/OptionsTest.php M test/classes/Navigation/Nodes/NodeDatabaseChildTest.php M test/classes/Plugins/Export/ExportHtmlwordTest.php M test/classes/Plugins/Export/ExportLatexTest.php M test/classes/Plugins/Export/ExportOdtTest.php M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Plugins/Export/ExportTexytextTest.php M test/classes/Server/PrivilegesTest.php M test/classes/SqlQueryFormTest.php M test/classes/SystemDatabaseTest.php M test/classes/TrackerTest.php M test/classes/TrackingTest.php M test/classes/TransformationsTest.php M test/classes/UserPreferencesTest.php
Log Message: ----------- Populate relation Session with RelationParameters class
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Commit: 5d58911ec55bfc3fe549956438cfaf68e8418219 https://github.com/phpmyadmin/phpmyadmin/commit/5d58911ec55bfc3fe549956438cf... Author: Maurício Meneghini Fauth mauricio@fauth.dev Date: 2021-12-17 (Fri, 12 December 2021) -03:00
Changed paths: A libraries/classes/ConfigStorage/Relation.php A libraries/classes/ConfigStorage/RelationCleanup.php A libraries/classes/ConfigStorage/RelationParameters.php A libraries/classes/ConfigStorage/UserGroups.php A test/classes/ConfigStorage/RelationCleanupTest.php A test/classes/ConfigStorage/RelationParametersTest.php A test/classes/ConfigStorage/RelationTest.php A test/classes/ConfigStorage/UserGroupsTest.php M libraries/classes/Bookmark.php M libraries/classes/Common.php M libraries/classes/Config.php M libraries/classes/Console.php M libraries/classes/Controllers/BrowseForeignersController.php M libraries/classes/Controllers/CheckRelationsController.php M libraries/classes/Controllers/Database/DataDictionaryController.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Database/QueryByExampleController.php M libraries/classes/Controllers/Database/Structure/DropTableController.php M libraries/classes/Controllers/Database/Structure/EmptyTableController.php M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/Export/Template/CreateController.php M libraries/classes/Controllers/Export/Template/DeleteController.php M libraries/classes/Controllers/Export/Template/LoadController.php M libraries/classes/Controllers/Export/Template/UpdateController.php M libraries/classes/Controllers/HomeController.php M libraries/classes/Controllers/NavigationController.php M libraries/classes/Controllers/Preferences/ExportController.php M libraries/classes/Controllers/Preferences/FeaturesController.php M libraries/classes/Controllers/Preferences/ImportController.php M libraries/classes/Controllers/Preferences/MainPanelController.php M libraries/classes/Controllers/Preferences/ManageController.php M libraries/classes/Controllers/Preferences/NavigationController.php M libraries/classes/Controllers/Preferences/SqlController.php M libraries/classes/Controllers/Preferences/TwoFactorController.php M libraries/classes/Controllers/Server/Databases/DestroyController.php M libraries/classes/Controllers/Server/DatabasesController.php M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Controllers/Server/UserGroupsController.php M libraries/classes/Controllers/Server/UserGroupsFormController.php M libraries/classes/Controllers/Table/AddFieldController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/CreateController.php M libraries/classes/Controllers/Table/DeleteRowsController.php M libraries/classes/Controllers/Table/DropColumnController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/RelationController.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/Controllers/Table/SearchController.php M libraries/classes/Controllers/Table/Structure/ChangeController.php M libraries/classes/Controllers/Table/Structure/SaveController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Database/Designer.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Database/MultiTableQuery.php M libraries/classes/Database/Qbe.php M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbalInterface.php M libraries/classes/Display/Results.php M libraries/classes/ErrorReport.php M libraries/classes/Export/Options.php M libraries/classes/Footer.php M libraries/classes/Header.php M libraries/classes/InsertEdit.php M libraries/classes/Menu.php M libraries/classes/Navigation/Navigation.php M libraries/classes/Navigation/Nodes/Node.php M libraries/classes/Normalization.php M libraries/classes/Operations.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/ExportPlugin.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/Plugins/Schema/Pdf/Pdf.php M libraries/classes/Plugins/Schema/TableStats.php M libraries/classes/RecentFavoriteTable.php M libraries/classes/SavedSearches.php M libraries/classes/Server/Privileges.php M libraries/classes/Sql.php M libraries/classes/SystemDatabase.php M libraries/classes/Table.php M libraries/classes/Table/ColumnsDefinition.php M libraries/classes/Tracker.php M libraries/classes/Tracking.php M libraries/classes/Transformations.php M libraries/classes/Twig/RelationExtension.php M libraries/classes/TwoFactor.php M libraries/classes/UserPreferences.php M libraries/services.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Command/TwigLintCommandTest.php M test/classes/Controllers/CheckRelationsControllerTest.php M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php M test/classes/Controllers/Database/StructureControllerTest.php M test/classes/Controllers/Export/Template/CreateControllerTest.php M test/classes/Controllers/Export/Template/DeleteControllerTest.php M test/classes/Controllers/Export/Template/LoadControllerTest.php M test/classes/Controllers/Export/Template/UpdateControllerTest.php M test/classes/Controllers/Server/Databases/DestroyControllerTest.php M test/classes/Controllers/Server/DatabasesControllerTest.php M test/classes/Controllers/Table/RelationControllerTest.php M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Controllers/Table/Structure/ChangeControllerTest.php M test/classes/Controllers/Table/Structure/SaveControllerTest.php M test/classes/Database/CentralColumnsTest.php M test/classes/Database/Designer/CommonTest.php M test/classes/Database/DesignerTest.php M test/classes/Database/QbeTest.php M test/classes/DatabaseInterfaceTest.php M test/classes/Display/ResultsTest.php M test/classes/ErrorReportTest.php M test/classes/Export/OptionsTest.php M test/classes/Navigation/NavigationTest.php M test/classes/Navigation/Nodes/NodeDatabaseChildTest.php M test/classes/NormalizationTest.php M test/classes/OperationsTest.php M test/classes/Plugins/Export/ExportHtmlwordTest.php M test/classes/Plugins/Export/ExportLatexTest.php M test/classes/Plugins/Export/ExportOdtTest.php M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Plugins/Export/ExportTexytextTest.php M test/classes/Server/PrivilegesTest.php M test/classes/SqlQueryFormTest.php M test/classes/SqlTest.php M test/classes/SystemDatabaseTest.php M test/classes/TableTest.php M test/classes/TrackerTest.php M test/classes/TrackingTest.php M test/classes/TransformationsTest.php M test/classes/UserPasswordTest.php M test/classes/UserPreferencesTest.php D libraries/classes/Relation.php D libraries/classes/RelationCleanup.php D libraries/classes/RelationParameters.php D libraries/classes/Server/UserGroups.php D test/classes/RelationCleanupTest.php D test/classes/RelationParametersTest.php D test/classes/RelationTest.php D test/classes/Server/UserGroupsTest.php
Log Message: ----------- Merge pull request #17245 from mauriciofauth/relation-refactor
Refactor the `Relation` and related classes
-
Maurício Meneghini Fauth