[phpmyadmin/phpmyadmin] b68a82: Remove the ResponseRenderer::checkParameters() method

9 Dec 2024

      Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: b68a82e38c8e36b92d33247c1fffb6251ed1bc71
https://github.com/phpmyadmin/phpmyadmin/commit/b68a82e38c8e36b92d33247c1fff...
Author: Maurício Meneghini Fauth <mauricio@mfauth.net>
Date: 2024-12-09 (Mon, 12 December 2024) -03:00

Changed paths: 
M phpstan-baseline.neon
M psalm-baseline.xml
M src/Controllers/Database/DataDictionaryController.php
M src/Controllers/Database/DesignerController.php
M src/Controllers/Database/EventsController.php
M src/Controllers/Database/ExportController.php
M src/Controllers/Database/ImportController.php
M src/Controllers/Database/RoutinesController.php
M src/Controllers/Database/SearchController.php
M src/Controllers/Database/SqlController.php
M src/Controllers/Database/Structure/RealRowCountController.php
M src/Controllers/Database/StructureController.php
M src/Controllers/Database/TrackingController.php
M src/Controllers/Export/ExportController.php
M src/Controllers/Operations/Database/CollationController.php
M src/Controllers/Operations/DatabaseController.php
M src/Controllers/Operations/TableController.php
M src/Controllers/Operations/ViewController.php
M src/Controllers/Sql/SqlController.php
M src/Controllers/Table/AddFieldController.php
M src/Controllers/Table/ChartController.php
M src/Controllers/Table/CreateController.php
M src/Controllers/Table/DeleteConfirmController.php
M src/Controllers/Table/ExportController.php
M src/Controllers/Table/FindReplaceController.php
M src/Controllers/Table/GetFieldController.php
M src/Controllers/Table/GisVisualizationController.php
M src/Controllers/Table/ImportController.php
M src/Controllers/Table/IndexRenameController.php
M src/Controllers/Table/IndexesController.php
M src/Controllers/Table/ReplaceController.php
M src/Controllers/Table/SearchController.php
M src/Controllers/Table/SqlController.php
M src/Controllers/Table/Structure/ChangeController.php
M src/Controllers/Table/Structure/PrimaryController.php
M src/Controllers/Table/StructureController.php
M src/Controllers/Table/TrackingController.php
M src/Controllers/Table/ZoomSearchController.php
M src/Controllers/Triggers/IndexController.php
M src/Controllers/View/CreateController.php
M src/ResponseRenderer.php
M tests/unit/ResponseRendererTest.php

Log Message:
-----------
Remove the ResponseRenderer::checkParameters() method

Refactor it to use ResponseRenderer::missingParameterError() instead.

This provides better parameter handling for the controllers.

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>

Commit: b759e811c0df333dc52a06c030b07a3b23c1bf15
https://github.com/phpmyadmin/phpmyadmin/commit/b759e811c0df333dc52a06c030b0...
Author: Maurício Meneghini Fauth <mauricio@mfauth.net>
Date: 2024-12-09 (Mon, 12 December 2024) -03:00

Changed paths: 
M phpstan-baseline.neon
M psalm-baseline.xml
M src/Controllers/Database/DataDictionaryController.php
M src/Controllers/Database/DesignerController.php
M src/Controllers/Database/EventsController.php
M src/Controllers/Database/ExportController.php
M src/Controllers/Database/ImportController.php
M src/Controllers/Database/RoutinesController.php
M src/Controllers/Database/SearchController.php
M src/Controllers/Database/SqlController.php
M src/Controllers/Database/Structure/RealRowCountController.php
M src/Controllers/Database/StructureController.php
M src/Controllers/Database/TrackingController.php
M src/Controllers/Export/ExportController.php
M src/Controllers/Operations/Database/CollationController.php
M src/Controllers/Operations/DatabaseController.php
M src/Controllers/Operations/TableController.php
M src/Controllers/Operations/ViewController.php
M src/Controllers/Sql/SqlController.php
M src/Controllers/Table/AddFieldController.php
M src/Controllers/Table/ChartController.php
M src/Controllers/Table/CreateController.php
M src/Controllers/Table/DeleteConfirmController.php
M src/Controllers/Table/ExportController.php
M src/Controllers/Table/FindReplaceController.php
M src/Controllers/Table/GetFieldController.php
M src/Controllers/Table/GisVisualizationController.php
M src/Controllers/Table/ImportController.php
M src/Controllers/Table/IndexRenameController.php
M src/Controllers/Table/IndexesController.php
M src/Controllers/Table/ReplaceController.php
M src/Controllers/Table/SearchController.php
M src/Controllers/Table/SqlController.php
M src/Controllers/Table/Structure/ChangeController.php
M src/Controllers/Table/Structure/PrimaryController.php
M src/Controllers/Table/StructureController.php
M src/Controllers/Table/TrackingController.php
M src/Controllers/Table/ZoomSearchController.php
M src/Controllers/Triggers/IndexController.php
M src/Controllers/View/CreateController.php
M src/ResponseRenderer.php
M tests/unit/ResponseRendererTest.php

Log Message:
-----------
Merge pull request #19440 from MauricioFauth/ResponseRenderer-checkParameters-removal

Remove the ResponseRenderer::checkParameters() method

Maurício Meneghini Fauth

tags

participants (1)