[phpmyadmin/sql-parser] 513ed8: Cleanup and improve readability:

9 Dec 2018


      Branch: refs/heads/master
Home: https://github.com/phpmyadmin/sql-parser
Commit: 513ed8175bdc0fc17a192ea29757cf8fee178c2a
https://github.com/phpmyadmin/sql-parser/commit/513ed8175bdc0fc17a192ea29757...
Author: Bruno Perel <brunoperel@gmail.com>
Date: 2018-11-26 (Mon, 11 November 2018) +01:00

Changed paths: 
M src/Components/CaseExpression.php
M src/Components/Condition.php
M src/Components/CreateDefinition.php
M src/Components/DataType.php
M src/Components/Expression.php
M src/Components/IntoKeyword.php
M src/Components/JoinKeyword.php
M src/Components/ParameterDefinition.php
M src/Components/UnionKeyword.php
M src/Context.php
M src/Lexer.php
M src/Parser.php
M src/Statement.php
M src/Statements/CreateStatement.php
M src/Statements/DeleteStatement.php
M src/Statements/LoadStatement.php
M src/Statements/SelectStatement.php
M src/Statements/TransactionStatement.php
M src/Token.php
M src/Utils/BufferedQuery.php
M src/Utils/Formatter.php
M src/Utils/Misc.php
M src/Utils/Query.php
M src/Utils/Table.php
M src/Utils/Tokens.php
M tests/Components/CreateDefinitionTest.php
M tests/Components/LimitTest.php
M tests/Utils/BufferedQueryTest.php

Log Message:
-----------
Cleanup and improve readability:
Avoid duplicate if conditions
Use switch/case instead of ifs when possible

Commit: ef7968e5a80de41c2bbd5ad3d93b6f47fe3f9705
https://github.com/phpmyadmin/sql-parser/commit/ef7968e5a80de41c2bbd5ad3d93b...
Author: Bruno Perel <brunoperel@gmail.com>
Date: 2018-11-26 (Mon, 11 November 2018) +01:00

Changed paths: 
M src/Components/AlterOperation.php
M src/Components/Array2d.php
M src/Components/Condition.php
M src/Components/Expression.php
M src/Components/IntoKeyword.php
M src/Components/OptionsArray.php
M src/Components/SetOperation.php
M src/Context.php
M src/Statement.php
M src/Statements/CreateStatement.php
M src/Statements/DeleteStatement.php
M src/Statements/InsertStatement.php
M src/Statements/ReplaceStatement.php
M src/Utils/BufferedQuery.php
M src/Utils/CLI.php
M src/Utils/Formatter.php
M src/Utils/Query.php
M tools/ContextGenerator.php

Log Message:
-----------
Use triple (in)equalities when type compatibility is ensured

Commit: 2d0b364f6424ce433f77e9f876bc7d1a0e0b6281
https://github.com/phpmyadmin/sql-parser/commit/2d0b364f6424ce433f77e9f876bc...
Author: Bruno Perel <brunoperel@gmail.com>
Date: 2018-11-27 (Tue, 11 November 2018) +01:00

Changed paths: 
M src/Components/CaseExpression.php
M src/Components/JoinKeyword.php
M src/Statements/CreateStatement.php

Log Message:
-----------
Fix tests

Commit: 4b3684f16ecb3539057cbba3141473c059141a45
https://github.com/phpmyadmin/sql-parser/commit/4b3684f16ecb3539057cbba31414...
Author: Bruno Perel <brunoperel@gmail.com>
Date: 2018-12-09 (Sun, 12 December 2018) +01:00

Changed paths: 
M src/Utils/Query.php

Log Message:
-----------
Fix unused variable

Commit: 5e8dbcf3ff0d1123efd731863083a9af539e5992
https://github.com/phpmyadmin/sql-parser/commit/5e8dbcf3ff0d1123efd731863083...
Author: Deven Bansod <devenbansod@users.noreply.github.com>
Date: 2018-12-09 (Sun, 12 December 2018) +05:30

Changed paths: 
M src/Components/AlterOperation.php
M src/Components/Array2d.php
M src/Components/CaseExpression.php
M src/Components/Condition.php
M src/Components/CreateDefinition.php
M src/Components/DataType.php
M src/Components/Expression.php
M src/Components/IntoKeyword.php
M src/Components/JoinKeyword.php
M src/Components/OptionsArray.php
M src/Components/ParameterDefinition.php
M src/Components/SetOperation.php
M src/Components/UnionKeyword.php
M src/Context.php
M src/Lexer.php
M src/Parser.php
M src/Statement.php
M src/Statements/CreateStatement.php
M src/Statements/DeleteStatement.php
M src/Statements/InsertStatement.php
M src/Statements/LoadStatement.php
M src/Statements/ReplaceStatement.php
M src/Statements/SelectStatement.php
M src/Statements/TransactionStatement.php
M src/Token.php
M src/Utils/BufferedQuery.php
M src/Utils/CLI.php
M src/Utils/Formatter.php
M src/Utils/Misc.php
M src/Utils/Query.php
M src/Utils/Table.php
M src/Utils/Tokens.php
M tests/Components/CreateDefinitionTest.php
M tests/Components/LimitTest.php
M tests/Utils/BufferedQueryTest.php
M tools/ContextGenerator.php

Log Message:
-----------
Merge pull request #206 from bperel/cleanup

Cleanup the code

* Avoid duplicate if conditions
* Use switch/case instead of ifs when possible
* Use triple (in)equalities when type compatibility is ensured

Bruno Perel

tags

participants (1)