[phpmyadmin/phpmyadmin] 5a34a3: Remove `db` and `table` properties from controllers - Git

2 Feb 2022


      Branch: refs/heads/master
Home: https://github.com/phpmyadmin/phpmyadmin
Commit: 5a34a3bb049df3fc8570ed9e4d57cf173273e622
https://github.com/phpmyadmin/phpmyadmin/commit/5a34a3bb049df3fc8570ed9e4d57...
Author: Maurício Meneghini Fauth mauricio@fauth.dev
Date: 2022-02-02 (Wed, 02 February 2022) -03:00
Changed paths: 
M libraries/classes/Common.php
M libraries/classes/Controllers/Database/CentralColumns/PopulateColumnsController.php
M libraries/classes/Controllers/Database/CentralColumnsController.php
M libraries/classes/Controllers/Database/DataDictionaryController.php
M libraries/classes/Controllers/Database/DesignerController.php
M libraries/classes/Controllers/Database/EventsController.php
M libraries/classes/Controllers/Database/ExportController.php
M libraries/classes/Controllers/Database/ImportController.php
M libraries/classes/Controllers/Database/MultiTableQueryController.php
M libraries/classes/Controllers/Database/Operations/CollationController.php
M libraries/classes/Controllers/Database/OperationsController.php
M libraries/classes/Controllers/Database/PrivilegesController.php
M libraries/classes/Controllers/Database/QueryByExampleController.php
M libraries/classes/Controllers/Database/RoutinesController.php
M libraries/classes/Controllers/Database/SearchController.php
M libraries/classes/Controllers/Database/SqlAutoCompleteController.php
M libraries/classes/Controllers/Database/SqlController.php
M libraries/classes/Controllers/Database/SqlFormatController.php
M libraries/classes/Controllers/Database/Structure/AddPrefixController.php
M libraries/classes/Controllers/Database/Structure/AddPrefixTableController.php
M libraries/classes/Controllers/Database/Structure/CentralColumns/AddController.php
M libraries/classes/Controllers/Database/Structure/CentralColumns/MakeConsistentController.php
M libraries/classes/Controllers/Database/Structure/CentralColumns/RemoveController.php
M libraries/classes/Controllers/Database/Structure/ChangePrefixFormController.php
M libraries/classes/Controllers/Database/Structure/CopyFormController.php
M libraries/classes/Controllers/Database/Structure/CopyTableController.php
M libraries/classes/Controllers/Database/Structure/CopyTableWithPrefixController.php
M libraries/classes/Controllers/Database/Structure/DropFormController.php
M libraries/classes/Controllers/Database/Structure/DropTableController.php
M libraries/classes/Controllers/Database/Structure/EmptyFormController.php
M libraries/classes/Controllers/Database/Structure/EmptyTableController.php
M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php
M libraries/classes/Controllers/Database/Structure/RealRowCountController.php
M libraries/classes/Controllers/Database/Structure/ReplacePrefixController.php
M libraries/classes/Controllers/Database/Structure/ShowCreateController.php
M libraries/classes/Controllers/Database/StructureController.php
M libraries/classes/Controllers/Database/TrackingController.php
M libraries/classes/Controllers/Database/TriggersController.php
M libraries/classes/Controllers/Server/PrivilegesController.php
M libraries/classes/Controllers/Table/AddFieldController.php
M libraries/classes/Controllers/Table/ChangeController.php
M libraries/classes/Controllers/Table/ChangeRowsController.php
M libraries/classes/Controllers/Table/ChartController.php
M libraries/classes/Controllers/Table/CreateController.php
M libraries/classes/Controllers/Table/DeleteConfirmController.php
M libraries/classes/Controllers/Table/DeleteRowsController.php
M libraries/classes/Controllers/Table/DropColumnConfirmationController.php
M libraries/classes/Controllers/Table/DropColumnController.php
M libraries/classes/Controllers/Table/ExportController.php
M libraries/classes/Controllers/Table/ExportRowsController.php
M libraries/classes/Controllers/Table/FindReplaceController.php
M libraries/classes/Controllers/Table/GetFieldController.php
M libraries/classes/Controllers/Table/GisVisualizationController.php
M libraries/classes/Controllers/Table/ImportController.php
M libraries/classes/Controllers/Table/IndexRenameController.php
M libraries/classes/Controllers/Table/IndexesController.php
M libraries/classes/Controllers/Table/Maintenance/AnalyzeController.php
M libraries/classes/Controllers/Table/Maintenance/CheckController.php
M libraries/classes/Controllers/Table/Maintenance/ChecksumController.php
M libraries/classes/Controllers/Table/Maintenance/OptimizeController.php
M libraries/classes/Controllers/Table/Maintenance/RepairController.php
M libraries/classes/Controllers/Table/OperationsController.php
M libraries/classes/Controllers/Table/Partition/AnalyzeController.php
M libraries/classes/Controllers/Table/Partition/CheckController.php
M libraries/classes/Controllers/Table/Partition/DropController.php
M libraries/classes/Controllers/Table/Partition/OptimizeController.php
M libraries/classes/Controllers/Table/Partition/RebuildController.php
M libraries/classes/Controllers/Table/Partition/RepairController.php
M libraries/classes/Controllers/Table/Partition/TruncateController.php
M libraries/classes/Controllers/Table/PrivilegesController.php
M libraries/classes/Controllers/Table/RecentFavoriteController.php
M libraries/classes/Controllers/Table/RelationController.php
M libraries/classes/Controllers/Table/ReplaceController.php
M libraries/classes/Controllers/Table/SearchController.php
M libraries/classes/Controllers/Table/SqlController.php
M libraries/classes/Controllers/Table/Structure/AddIndexController.php
M libraries/classes/Controllers/Table/Structure/AddKeyController.php
M libraries/classes/Controllers/Table/Structure/BrowseController.php
M libraries/classes/Controllers/Table/Structure/CentralColumnsAddController.php
M libraries/classes/Controllers/Table/Structure/CentralColumnsRemoveController.php
M libraries/classes/Controllers/Table/Structure/ChangeController.php
M libraries/classes/Controllers/Table/Structure/FulltextController.php
M libraries/classes/Controllers/Table/Structure/MoveColumnsController.php
M libraries/classes/Controllers/Table/Structure/PartitioningController.php
M libraries/classes/Controllers/Table/Structure/PrimaryController.php
M libraries/classes/Controllers/Table/Structure/ReservedWordCheckController.php
M libraries/classes/Controllers/Table/Structure/SaveController.php
M libraries/classes/Controllers/Table/Structure/SpatialController.php
M libraries/classes/Controllers/Table/Structure/UniqueController.php
M libraries/classes/Controllers/Table/StructureController.php
M libraries/classes/Controllers/Table/TrackingController.php
M libraries/classes/Controllers/Table/TriggersController.php
M libraries/classes/Controllers/Table/ZoomSearchController.php
M libraries/services_controllers.php
M psalm-baseline.xml
M test/classes/Controllers/Database/PrivilegesControllerTest.php
M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php
M test/classes/Controllers/Database/Structure/RealRowCountControllerTest.php
M test/classes/Controllers/Database/StructureControllerTest.php
M test/classes/Controllers/Table/FindReplaceControllerTest.php
M test/classes/Controllers/Table/IndexesControllerTest.php
M test/classes/Controllers/Table/PrivilegesControllerTest.php
M test/classes/Controllers/Table/RelationControllerTest.php
M test/classes/Controllers/Table/SearchControllerTest.php
M test/classes/Controllers/Table/Structure/ChangeControllerTest.php
M test/classes/Controllers/Table/Structure/SaveControllerTest.php
D libraries/classes/Controllers/Database/AbstractController.php
D libraries/classes/Controllers/Table/AbstractController.php
Log Message:
-----------
Remove `db` and `table` properties from controllers
Replaces them with their respective globals.
Signed-off-by: Maurício Meneghini Fauth mauricio@fauth.dev
Commit: 14f83476b011fef7246fb4edd94add9729aeedca
https://github.com/phpmyadmin/phpmyadmin/commit/14f83476b011fef7246fb4edd94a...
Author: Maurício Meneghini Fauth mauricio@fauth.dev
Date: 2022-02-02 (Wed, 02 February 2022) -03:00
Changed paths: 
M libraries/classes/Common.php
M libraries/classes/Controllers/Database/CentralColumns/PopulateColumnsController.php
M libraries/classes/Controllers/Database/CentralColumnsController.php
M libraries/classes/Controllers/Database/DataDictionaryController.php
M libraries/classes/Controllers/Database/DesignerController.php
M libraries/classes/Controllers/Database/EventsController.php
M libraries/classes/Controllers/Database/ExportController.php
M libraries/classes/Controllers/Database/ImportController.php
M libraries/classes/Controllers/Database/MultiTableQueryController.php
M libraries/classes/Controllers/Database/Operations/CollationController.php
M libraries/classes/Controllers/Database/OperationsController.php
M libraries/classes/Controllers/Database/PrivilegesController.php
M libraries/classes/Controllers/Database/QueryByExampleController.php
M libraries/classes/Controllers/Database/RoutinesController.php
M libraries/classes/Controllers/Database/SearchController.php
M libraries/classes/Controllers/Database/SqlAutoCompleteController.php
M libraries/classes/Controllers/Database/SqlController.php
M libraries/classes/Controllers/Database/SqlFormatController.php
M libraries/classes/Controllers/Database/Structure/AddPrefixController.php
M libraries/classes/Controllers/Database/Structure/AddPrefixTableController.php
M libraries/classes/Controllers/Database/Structure/CentralColumns/AddController.php
M libraries/classes/Controllers/Database/Structure/CentralColumns/MakeConsistentController.php
M libraries/classes/Controllers/Database/Structure/CentralColumns/RemoveController.php
M libraries/classes/Controllers/Database/Structure/ChangePrefixFormController.php
M libraries/classes/Controllers/Database/Structure/CopyFormController.php
M libraries/classes/Controllers/Database/Structure/CopyTableController.php
M libraries/classes/Controllers/Database/Structure/CopyTableWithPrefixController.php
M libraries/classes/Controllers/Database/Structure/DropFormController.php
M libraries/classes/Controllers/Database/Structure/DropTableController.php
M libraries/classes/Controllers/Database/Structure/EmptyFormController.php
M libraries/classes/Controllers/Database/Structure/EmptyTableController.php
M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php
M libraries/classes/Controllers/Database/Structure/RealRowCountController.php
M libraries/classes/Controllers/Database/Structure/ReplacePrefixController.php
M libraries/classes/Controllers/Database/Structure/ShowCreateController.php
M libraries/classes/Controllers/Database/StructureController.php
M libraries/classes/Controllers/Database/TrackingController.php
M libraries/classes/Controllers/Database/TriggersController.php
M libraries/classes/Controllers/Server/PrivilegesController.php
M libraries/classes/Controllers/Table/AddFieldController.php
M libraries/classes/Controllers/Table/ChangeController.php
M libraries/classes/Controllers/Table/ChangeRowsController.php
M libraries/classes/Controllers/Table/ChartController.php
M libraries/classes/Controllers/Table/CreateController.php
M libraries/classes/Controllers/Table/DeleteConfirmController.php
M libraries/classes/Controllers/Table/DeleteRowsController.php
M libraries/classes/Controllers/Table/DropColumnConfirmationController.php
M libraries/classes/Controllers/Table/DropColumnController.php
M libraries/classes/Controllers/Table/ExportController.php
M libraries/classes/Controllers/Table/ExportRowsController.php
M libraries/classes/Controllers/Table/FindReplaceController.php
M libraries/classes/Controllers/Table/GetFieldController.php
M libraries/classes/Controllers/Table/GisVisualizationController.php
M libraries/classes/Controllers/Table/ImportController.php
M libraries/classes/Controllers/Table/IndexRenameController.php
M libraries/classes/Controllers/Table/IndexesController.php
M libraries/classes/Controllers/Table/Maintenance/AnalyzeController.php
M libraries/classes/Controllers/Table/Maintenance/CheckController.php
M libraries/classes/Controllers/Table/Maintenance/ChecksumController.php
M libraries/classes/Controllers/Table/Maintenance/OptimizeController.php
M libraries/classes/Controllers/Table/Maintenance/RepairController.php
M libraries/classes/Controllers/Table/OperationsController.php
M libraries/classes/Controllers/Table/Partition/AnalyzeController.php
M libraries/classes/Controllers/Table/Partition/CheckController.php
M libraries/classes/Controllers/Table/Partition/DropController.php
M libraries/classes/Controllers/Table/Partition/OptimizeController.php
M libraries/classes/Controllers/Table/Partition/RebuildController.php
M libraries/classes/Controllers/Table/Partition/RepairController.php
M libraries/classes/Controllers/Table/Partition/TruncateController.php
M libraries/classes/Controllers/Table/PrivilegesController.php
M libraries/classes/Controllers/Table/RecentFavoriteController.php
M libraries/classes/Controllers/Table/RelationController.php
M libraries/classes/Controllers/Table/ReplaceController.php
M libraries/classes/Controllers/Table/SearchController.php
M libraries/classes/Controllers/Table/SqlController.php
M libraries/classes/Controllers/Table/Structure/AddIndexController.php
M libraries/classes/Controllers/Table/Structure/AddKeyController.php
M libraries/classes/Controllers/Table/Structure/BrowseController.php
M libraries/classes/Controllers/Table/Structure/CentralColumnsAddController.php
M libraries/classes/Controllers/Table/Structure/CentralColumnsRemoveController.php
M libraries/classes/Controllers/Table/Structure/ChangeController.php
M libraries/classes/Controllers/Table/Structure/FulltextController.php
M libraries/classes/Controllers/Table/Structure/MoveColumnsController.php
M libraries/classes/Controllers/Table/Structure/PartitioningController.php
M libraries/classes/Controllers/Table/Structure/PrimaryController.php
M libraries/classes/Controllers/Table/Structure/ReservedWordCheckController.php
M libraries/classes/Controllers/Table/Structure/SaveController.php
M libraries/classes/Controllers/Table/Structure/SpatialController.php
M libraries/classes/Controllers/Table/Structure/UniqueController.php
M libraries/classes/Controllers/Table/StructureController.php
M libraries/classes/Controllers/Table/TrackingController.php
M libraries/classes/Controllers/Table/TriggersController.php
M libraries/classes/Controllers/Table/ZoomSearchController.php
M libraries/services_controllers.php
M psalm-baseline.xml
M test/classes/Controllers/Database/PrivilegesControllerTest.php
M test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php
M test/classes/Controllers/Database/Structure/RealRowCountControllerTest.php
M test/classes/Controllers/Database/StructureControllerTest.php
M test/classes/Controllers/Table/FindReplaceControllerTest.php
M test/classes/Controllers/Table/IndexesControllerTest.php
M test/classes/Controllers/Table/PrivilegesControllerTest.php
M test/classes/Controllers/Table/RelationControllerTest.php
M test/classes/Controllers/Table/SearchControllerTest.php
M test/classes/Controllers/Table/Structure/ChangeControllerTest.php
M test/classes/Controllers/Table/Structure/SaveControllerTest.php
D libraries/classes/Controllers/Database/AbstractController.php
D libraries/classes/Controllers/Table/AbstractController.php
Log Message:
-----------
Merge pull request #17332 from mauriciofauth/db-table-ctrl-props-removal
Remove `db` and `table` properties from controllers