[phpmyadmin/phpmyadmin] ce12a8: Fix #20284 - Preserve numeric strings in XML imports
Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: ce12a87858394d62e8acecd2f8b6cbfa7e7a3b2e https://github.com/phpmyadmin/phpmyadmin/commit/ce12a87858394d62e8acecd2f8b6... Author: Eyüp Can Akman <eyupcanakman@gmail.com> Date: 2026-04-28 (Tue, 04 April 2026) +03:00 Changed paths: A test/test_data/phpmyadmin_importXML_Numeric_String_For_Testing.xml M libraries/classes/Import.php M phpstan-baseline.neon M test/classes/Plugins/Import/ImportXmlTest.php Log Message: ----------- Fix #20284 - Preserve numeric strings in XML imports When the XML file embeds the table structure, $analyses is null and buildSql() falls back to is_numeric() to decide whether to quote. That strips quotes from values like "01234", which silently drops the leading zero on a varchar column and causes a duplicate-key error if the table also contains "1234". Add a roundtrip check: a value is still treated as numeric only when casting it to int or float gives back the original string. "01234", "1e10" and similar fail the roundtrip and stay quoted; plain integers like 1 and 1234 keep their existing unquoted form. Signed-off-by: Eyüp Can Akman <eyupcanakman@gmail.com> Commit: 71d0cd633a5ad64b7d9483f68136dd97f57d834a https://github.com/phpmyadmin/phpmyadmin/commit/71d0cd633a5ad64b7d9483f68136... Author: test <ebe37302@tqosi.com> Date: 2026-04-28 (Tue, 04 April 2026) +00:00 Changed paths: M po/hr.po Log Message: ----------- Translated using Weblate (Croatian) Currently translated at 27.0% (929 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/hr/ Signed-off-by: test <ebe37302@tqosi.com> Commit: 6ea71b7cfd08b32ad064a5272263710dfb3db035 https://github.com/phpmyadmin/phpmyadmin/commit/6ea71b7cfd08b32ad064a5272263... Author: test <ebe37302@tqosi.com> Date: 2026-04-28 (Tue, 04 April 2026) +00:00 Changed paths: M po/hr.po Log Message: ----------- Translated using Weblate (Croatian) Currently translated at 27.0% (929 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/hr/ Signed-off-by: test <ebe37302@tqosi.com> Commit: 62c949bce77fb351eb4596782b1f25ebcf631e8d https://github.com/phpmyadmin/phpmyadmin/commit/62c949bce77fb351eb4596782b1f... Author: Milo Ivir <mail@milotype.de> Date: 2026-04-28 (Tue, 04 April 2026) +00:00 Changed paths: M po/hr.po Log Message: ----------- Translated using Weblate (Croatian) Currently translated at 27.0% (929 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/hr/ Signed-off-by: Milo Ivir <mail@milotype.de> Commit: a78c750423e369ea5438ccd74cd73158630f7848 https://github.com/phpmyadmin/phpmyadmin/commit/a78c750423e369ea5438ccd74cd7... Author: test <ebe37302@tqosi.com> Date: 2026-04-30 (Thu, 04 April 2026) +00:00 Changed paths: M po/hr.po Log Message: ----------- Translated using Weblate (Croatian) Currently translated at 27.5% (948 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/hr/ Signed-off-by: test <ebe37302@tqosi.com> Commit: 1b38fd902730e63611d8fb5b518ab019b64729b9 https://github.com/phpmyadmin/phpmyadmin/commit/1b38fd902730e63611d8fb5b518a... Author: Milo Ivir <mail@milotype.de> Date: 2026-04-30 (Thu, 04 April 2026) +00:00 Changed paths: M po/hr.po Log Message: ----------- Translated using Weblate (Croatian) Currently translated at 27.5% (948 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/hr/ Signed-off-by: Milo Ivir <mail@milotype.de> Commit: 7e2f166e55b86862ecf50052bbe933593e00e0cd https://github.com/phpmyadmin/phpmyadmin/commit/7e2f166e55b86862ecf50052bbe9... Author: Andrei Stepanov <adem4ik@gmail.com> Date: 2026-04-30 (Thu, 04 April 2026) +00:00 Changed paths: M po/ru.po Log Message: ----------- Translated using Weblate (Russian) Currently translated at 100.0% (3435 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/ru/ Signed-off-by: Andrei Stepanov <adem4ik@gmail.com> Commit: bd81cf82be2f0f65d399c317605502c7c36ccdb6 https://github.com/phpmyadmin/phpmyadmin/commit/bd81cf82be2f0f65d399c3176055... Author: Eyüp Can Akman <eyupcanakman@gmail.com> Date: 2026-04-30 (Thu, 04 April 2026) +03:00 Changed paths: M libraries/classes/Import.php Log Message: ----------- Simplify isVarchar check The !is_numeric guard is redundant; the round-trip already covers non-numeric inputs since (int) of a non-numeric string is 0. Signed-off-by: Eyüp Can Akman <eyupcanakman@gmail.com> Commit: fefb03f28d805e0d91fa1e647f45cd8302441c02 https://github.com/phpmyadmin/phpmyadmin/commit/fefb03f28d805e0d91fa1e647f45... Author: Andrei Stepanov <adem4ik@gmail.com> Date: 2026-05-02 (Sat, 05 May 2026) +00:00 Changed paths: M po/ru.po Log Message: ----------- Translated using Weblate (Russian) Currently translated at 100.0% (3435 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/ru/ Signed-off-by: Andrei Stepanov <adem4ik@gmail.com> Commit: 4389db0b04b700ddf53c44c2b5bf33c27058e0a0 https://github.com/phpmyadmin/phpmyadmin/commit/4389db0b04b700ddf53c44c2b5bf... Author: test <ebe37302@tqosi.com> Date: 2026-05-02 (Sat, 05 May 2026) +00:00 Changed paths: M po/hr.po Log Message: ----------- Translated using Weblate (Croatian) Currently translated at 27.8% (955 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/hr/ Signed-off-by: test <ebe37302@tqosi.com> Commit: 77c2ec0832d8316b14aca3abeff34e33db663480 https://github.com/phpmyadmin/phpmyadmin/commit/77c2ec0832d8316b14aca3abeff3... Author: Milo Ivir <mail@milotype.de> Date: 2026-05-02 (Sat, 05 May 2026) +00:00 Changed paths: M po/hr.po Log Message: ----------- Translated using Weblate (Croatian) Currently translated at 27.8% (955 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/hr/ Signed-off-by: Milo Ivir <mail@milotype.de> Commit: e214d7012c7b566e3c9c365a2670f953634713c6 https://github.com/phpmyadmin/phpmyadmin/commit/e214d7012c7b566e3c9c365a2670... Author: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Date: 2026-05-04 (Mon, 05 May 2026) +00:00 Changed paths: M po/lv.po Log Message: ----------- Translated using Weblate (Latvian) Currently translated at 25.2% (866 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/lv/ Signed-off-by: "ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝)" <coool@mail.lv> Commit: f620457baaf6d4e4edcb52918456c703dc029d72 https://github.com/phpmyadmin/phpmyadmin/commit/f620457baaf6d4e4edcb52918456... Author: ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝) <coool@mail.lv> Date: 2026-05-06 (Wed, 05 May 2026) +00:00 Changed paths: M po/lv.po Log Message: ----------- Translated using Weblate (Latvian) Currently translated at 26.3% (905 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/lv/ Signed-off-by: "ℂ𝕠𝕠𝕠𝕝 (𝕘𝕚𝕥𝕙𝕦𝕓.𝕔𝕠𝕞/ℂ𝕠𝕠𝕠𝕝)" <coool@mail.lv> Commit: 7893f1ec4eabe7ee898b65f17fbe4566ce8deab7 https://github.com/phpmyadmin/phpmyadmin/commit/7893f1ec4eabe7ee898b65f17fbe... Author: ButterflyOfFire <boffire@users.noreply.hosted.weblate.org> Date: 2026-05-07 (Thu, 05 May 2026) +02:00 Changed paths: M po/kab.po Log Message: ----------- Translated using Weblate (Kabyle) Currently translated at 2.4% (84 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/kab/ Signed-off-by: ButterflyOfFire <boffire@users.noreply.hosted.weblate.org> Commit: 89ba80a6f263d4200487d1cd1dd8a3c9e4c2d745 https://github.com/phpmyadmin/phpmyadmin/commit/89ba80a6f263d4200487d1cd1dd8... Author: Kristijan \"Fremen\" Velkovski <me@krisfremen.com> Date: 2026-05-07 (Thu, 05 May 2026) +02:00 Changed paths: M po/mk.po Log Message: ----------- Translated using Weblate (Macedonian) Currently translated at 30.1% (1035 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/mk/ Signed-off-by: "Kristijan \"Fremen\" Velkovski" <me@krisfremen.com> Commit: 9a293c2dce0c55dd16a1a7565ee1927f11684a08 https://github.com/phpmyadmin/phpmyadmin/commit/9a293c2dce0c55dd16a1a7565ee1... Author: Adam Havránek <adamhavra@seznam.cz> Date: 2026-05-08 (Fri, 05 May 2026) +02:00 Changed paths: M po/cs.po Log Message: ----------- Translated using Weblate (Czech) Currently translated at 100.0% (3435 of 3435 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/cs/ Signed-off-by: Adam Havránek <adamhavra@seznam.cz> Commit: b8d4ca52a936a6e8809cd0e53981dff4f26590de https://github.com/phpmyadmin/phpmyadmin/commit/b8d4ca52a936a6e8809cd0e53981... Author: Maurício Meneghini Fauth <mauricio@mfauth.com.br> Date: 2026-05-09 (Sat, 05 May 2026) -03:00 Changed paths: A test/test_data/phpmyadmin_importXML_Numeric_String_For_Testing.xml M libraries/classes/Import.php M phpstan-baseline.neon M test/classes/Plugins/Import/ImportXmlTest.php Log Message: ----------- Merge pull request #20296 from eyupcanakman/fix/xml-import-numeric-string-quoting Fix #20284 - Preserve numeric strings in XML imports Commit: eb5f9395829014c7727c4ff932e5a3c7d39651be https://github.com/phpmyadmin/phpmyadmin/commit/eb5f9395829014c7727c4ff932e5... Author: Maurício Meneghini Fauth <mauricio@mfauth.com.br> Date: 2026-05-09 (Sat, 05 May 2026) -03:00 Changed paths: A tests/test_data/phpmyadmin_importXML_Numeric_String_For_Testing.xml M phpstan-baseline.neon M psalm-baseline.xml M src/Import/Import.php M tests/unit/Plugins/Import/ImportXmlTest.php Log Message: ----------- Merge branch 'QA_5_2' Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
participants (1)
-
Eyüp Can Akman