[phpmyadmin/phpmyadmin] da9d90: Fix #15446 Tables added from other databases are not collapsing in the designer section
Branch: refs/heads/QA_4_9 Home: https://github.com/phpmyadmin/phpmyadmin Commit: da9d907ad1b17c31d293bff56f10fdaca52672c1 https://github.com/phpmyadmin/phpmyadmin/commit/da9d907ad1b17c31d293bff56f10... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-20 (Tue, 08 August 2019) +02:00
Changed paths: M js/designer/move.js M templates/database/designer/database_tables.twig
Log Message: ----------- Fix #15446 Tables added from other databases are not collapsing in the designer section
The events to link all buttons to collapse tables were initialized at page loading. But when a new table was added, the event wasn't declared for this one. With this commit, the event is now also declared on table addition.
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: 49dae2de12742b87a28cc6aa6c5e768be91d1b99 https://github.com/phpmyadmin/phpmyadmin/commit/49dae2de12742b87a28cc6aa6c5e... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-20 (Tue, 08 August 2019) +02:00
Changed paths: M db_designer.php
Log Message: ----------- Fix wrong id on table
When a table is added on the fly, the id was always built based on the first table of the targetted DB, not based on the selected table.
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: 14ba5a1b248791c71ad9e621330d4b4f361722bd https://github.com/phpmyadmin/phpmyadmin/commit/14ba5a1b248791c71ad9e621330d... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-20 (Tue, 08 August 2019) +02:00
Changed paths: M js/designer/move.js M libraries/classes/Database/Designer.php M templates/database/designer/database_tables.twig M templates/database/designer/table_list.twig
Log Message: ----------- Retrieve DB instead of relying on current one
When adding a table to the designer, it is useful to know the DB of this table to be able to jump to its structure.
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: c23bec2dee77f4b9af19f04f58d78db7cc75f5c4 https://github.com/phpmyadmin/phpmyadmin/commit/c23bec2dee77f4b9af19f04f58d7... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-20 (Tue, 08 August 2019) +02:00
Changed paths: M js/designer/move.js
Log Message: ----------- Be sure to use local variable
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: de57539fb71beacba54b18283893ca3cba6f01cf https://github.com/phpmyadmin/phpmyadmin/commit/de57539fb71beacba54b18283893... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-21 (Wed, 08 August 2019) +02:00
Changed paths: M db_designer.php M js/designer/move.js M js/messages.php M libraries/classes/Database/Designer.php M templates/database/designer/table_list.twig
Log Message: ----------- Build "tables list" in JS
This will allow to have the list generation in only one place, as the tables can now be added on the fly. So JS also needs to add items to this list.
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: ac340e29b6c53c4722789650c9500891c6b1f5e8 https://github.com/phpmyadmin/phpmyadmin/commit/ac340e29b6c53c4722789650c950... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-21 (Wed, 08 August 2019) +02:00
Changed paths: M js/designer/move.js
Log Message: ----------- Add missing overlay on added tables
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: b13c05edfa5effe098516ca6db4b84b3d9ea8693 https://github.com/phpmyadmin/phpmyadmin/commit/b13c05edfa5effe098516ca6db4b... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-21 (Wed, 08 August 2019) +02:00
Changed paths: M js/designer/move.js
Log Message: ----------- Toggling global collapse of tables now relies on tables items instead of j_tabs
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: fce235c7bcc49793f2914a00790e573f3c8d5386 https://github.com/phpmyadmin/phpmyadmin/commit/fce235c7bcc49793f2914a00790e... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-21 (Wed, 08 August 2019) +02:00
Changed paths: M js/designer/move.js
Log Message: ----------- Remove variable that is unused anymore
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: 3aa7a35daebd2b1f816ac97ffe3822af032bc0f2 https://github.com/phpmyadmin/phpmyadmin/commit/3aa7a35daebd2b1f816ac97ffe38... Author: William Desportes williamdes@wdes.fr Date: 2019-08-21 (Wed, 08 August 2019) +02:00
Changed paths: M libraries/tbl_columns_definition_form.inc.php
Log Message: ----------- #15363 - substr can return false on tbl_definition_form
Signed-off-by: William Desportes williamdes@wdes.fr
Commit: 67c94b17fd04ec4ba22b4f8e5dcf9d3e3ab94eec https://github.com/phpmyadmin/phpmyadmin/commit/67c94b17fd04ec4ba22b4f8e5dcf... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-21 (Wed, 08 August 2019) +02:00
Changed paths: M js/designer/move.js
Log Message: ----------- Designer export fails when a table name contains special chars
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: b37b479da03b02cab23ce039ecb299496afa6b6d https://github.com/phpmyadmin/phpmyadmin/commit/b37b479da03b02cab23ce039ecb2... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-21 (Wed, 08 August 2019) +02:00
Changed paths: M js/designer/move.js M js/messages.php
Log Message: ----------- Display an error when trying to import in designer a table that's already imported
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: 4f832662c5379cb61c932433623d48b68de9b91d https://github.com/phpmyadmin/phpmyadmin/commit/4f832662c5379cb61c932433623d... Author: William Desportes williamdes@wdes.fr Date: 2019-08-22 (Thu, 08 August 2019) +02:00
Changed paths: M js/designer/move.js
Log Message: ----------- Merge #15451 - Designer export fails when a table name contains special chars
Signed-off-by: William Desportes williamdes@wdes.fr
Commit: 5c7eb38a81712679c354d13cc9355e27db2eba21 https://github.com/phpmyadmin/phpmyadmin/commit/5c7eb38a81712679c354d13cc935... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-22 (Thu, 08 August 2019) +02:00
Changed paths: M js/designer/move.js
Log Message: ----------- Fix url encoding of table names
Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: 58e3b71ae251a6234551af6892f49942577cfacb https://github.com/phpmyadmin/phpmyadmin/commit/58e3b71ae251a6234551af6892f4... Author: Hugues Peccatte hugues.peccatte@gmail.com Date: 2019-08-22 (Thu, 08 August 2019) +02:00
Changed paths: M js/messages.php
Log Message: ----------- Update js/messages.php
add context for translators
Co-Authored-By: William Desportes williamdes@wdes.fr Signed-off-by: Hugues Peccatte hugues.peccatte@gmail.com
Commit: 9518e0d05304e7994dab70674f582dd86cfd4ab4 https://github.com/phpmyadmin/phpmyadmin/commit/9518e0d05304e7994dab70674f58... Author: William Desportes williamdes@wdes.fr Date: 2019-08-22 (Thu, 08 August 2019) +02:00
Changed paths: M js/designer/move.js M js/messages.php
Log Message: ----------- Merge #15452 - Display an error when trying to import in designer a table that's already imported
Signed-off-by: William Desportes williamdes@wdes.fr
Commit: 5940d11e72c4a9fa5c4a3beb24d3c2db9d4b0277 https://github.com/phpmyadmin/phpmyadmin/commit/5940d11e72c4a9fa5c4a3beb24d3... Author: William Desportes williamdes@wdes.fr Date: 2019-08-22 (Thu, 08 August 2019) +02:00
Changed paths: M db_designer.php M js/designer/move.js M js/messages.php M libraries/classes/Database/Designer.php M templates/database/designer/database_tables.twig M templates/database/designer/table_list.twig
Log Message: ----------- Merge #15448 - Fix many bugs when adding new tables to designer
Fixes: #15446 Pull-request: #15448 Signed-off-by: William Desportes williamdes@wdes.fr
Commit: a23f2ba51a93af0c5eedf91646aa9e04b9bc3a12 https://github.com/phpmyadmin/phpmyadmin/commit/a23f2ba51a93af0c5eedf91646aa... Author: William Desportes williamdes@wdes.fr Date: 2019-08-23 (Fri, 08 August 2019) +02:00
Changed paths: A libraries/classes/Database/Designer/DesignerTable.php M db_designer.php M js/designer/move.js M libraries/classes/Database/Designer.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Export.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/Plugins/Schema/TableStats.php M schema_export.php M templates/database/designer/database_tables.twig
Log Message: ----------- Fix some bugs with strange table and database names
- Fix export - Fix split on . to have db and table - Replace some $_REQUEST occurences - Add translations to "add tables from another database" : "None" > strNone - Refactor the ugly code that used globals to use an object "DesignerTable" - Fix save a new added table - Fix delete page items - Fix more bugs
Fixes: #15446 Fixes: #13370 Fixes: #14945 Closes: #15438
Signed-off-by: William Desportes williamdes@wdes.fr
-
Hugues Peccatte