[phpmyadmin/phpmyadmin] 6e3d38: Use strlen for calculating string index

16 Sep 2016

      Branch: refs/heads/master
  Home:   https://github.com/phpmyadmin/phpmyadmin
  Commit: 6e3d38a1d31c780722b0ed6f3dbf2a5c238c6dad
      https://github.com/phpmyadmin/phpmyadmin/commit/6e3d38a1d31c780722b0ed6f3dbf...
  Author: Michal Čihař <michal@cihar.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M libraries/plugins/schema/pdf/Pdf.php

  Log Message:
  -----------
  Use strlen for calculating string index

Issue #12397

Signed-off-by: Michal Čihař <michal@cihar.com>

  Commit: 3546bed47e51ad8bec18b6680aeaf6c031808d5e
      https://github.com/phpmyadmin/phpmyadmin/commit/3546bed47e51ad8bec18b6680aea...
  Author: Michal Čihař <michal@cihar.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M db_operations.php
    M export.php
    M import.php
    M import_status.php
    M libraries/Bookmark.php
    M libraries/Config.php
    M libraries/DbQbe.php
    M libraries/DbSearch.php
    M libraries/DisplayResults.php
    M libraries/Header.php
    M libraries/Index.php
    M libraries/ListDatabase.php
    M libraries/Menu.php
    M libraries/Message.php
    M libraries/Response.php
    M libraries/Table.php
    M libraries/URL.php
    M libraries/Util.php
    M libraries/controllers/server/ServerDatabasesController.php
    M libraries/controllers/table/TableChartController.php
    M libraries/controllers/table/TableSearchController.php
    M libraries/controllers/table/TableStructureController.php
    M libraries/core.lib.php
    M libraries/db_common.inc.php
    M libraries/db_table_exists.inc.php
    M libraries/display_export.lib.php
    M libraries/export.lib.php
    M libraries/insert_edit.lib.php
    M libraries/mult_submits.inc.php
    M libraries/operations.lib.php
    M libraries/plugins/ImportPlugin.php
    M libraries/plugins/auth/AuthenticationCookie.php
    M libraries/plugins/export/ExportXml.php
    M libraries/plugins/export/TableProperty.php
    M libraries/plugins/import/ImportCsv.php
    M libraries/plugins/import/ImportShp.php
    M libraries/relation.lib.php
    M libraries/replication_gui.lib.php
    M libraries/rte/rte_main.inc.php
    M libraries/server_privileges.lib.php
    M libraries/server_status_monitor.lib.php
    M libraries/server_status_processes.lib.php
    M libraries/sql.lib.php
    M libraries/sql_query_form.lib.php
    M libraries/tbl_info.inc.php
    M libraries/transformations.lib.php
    M sql.php
    M tbl_addfield.php
    M tbl_change.php
    M tbl_create.php
    M templates/database/structure/structure_table_row.phtml

  Log Message:
  -----------
  Avoid using mb_strlen for checking whether string is empty

Using strlen produces same results here, just way faster.

Fixes #12397

Signed-off-by: Michal Čihař <michal@cihar.com>

  Commit: a716fa6e7ed36624fbfce0e86cf8aa7f6d58d23b
      https://github.com/phpmyadmin/phpmyadmin/commit/a716fa6e7ed36624fbfce0e86cf8...
  Author: Michal Čihař <michal@cihar.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M libraries/export.lib.php

  Log Message:
  -----------
  We need to count bytes against memory limit not chars

Issue #12397

Signed-off-by: Michal Čihař <michal@cihar.com>

Compare: https://github.com/phpmyadmin/phpmyadmin/compare/ddb16a9ca1e5...a716fa6e7ed3

Michal Čihař

tags

participants (1)