Re: [Phpmyadmin-translators] [Phpmyadmin-devel] gsoc: Refactoring: Server view [some Chinese Translations]
Hi,
I have updated some Chinese Translations. All strings Untranslated strings (37) Fuzzy strings (25) Strings with suggestions (4) Strings with any failing checks (4) Format string does not match source (1) Source and translation do not both end with a full stop (3)
Recent contributions WhenUserActionTranslation 3 minutes ago xmujay xmujayNew translationphpMyAdmin/master - Simplified Chinese 3 minutes ago xmujay xmujayNew translationphpMyAdmin/4.0 - Simplified Chinese 4 minutes ago xmujay xmujayNew translationphpMyAdmin/master - Simplified Chinese 4 minutes ago xmujay xmujayNew translationphpMyAdmin/4.0 - Simplified Chinese 5 minutes ago xmujay xmujayNew translationphpMyAdmin/master - Simplified Chinese 5 minutes ago xmujay xmujayNew translationphpMyAdmin/4.0 - Simplified Chinese 6 minutes ago xmujay xmujayNew translationphpMyAdmin/master - Simplified Chinese 6 minutes ago xmujay xmujayNew translationphpMyAdmin/4.0 - Simplified Chinese 6 minutes ago xmujay xmujayNew translationphpMyAdmin/master - Simplified Chinese 6 minutes ago xmujay xmujayNew translationphpMyAdmin/4.0 - Simplified Chinese
I will keep doing the remaining Chinese transations. thanks
xmujay@gmail.com
From: Marc Delisle Date: 2013-04-01 23:56 To: phpmyadmin-devel Subject: Re: [Phpmyadmin-devel] gsoc: Refactoring: Server view Le 2013-04-01 11:26, xmujay@gmail.com a écrit :
Thanks Marc.
I make a simple compare with the db view which are with db_ prefix php file. I found that the render process is full of long code, so at least three things for code improvements: 1. split them to functions which can be re-used. 2. split them to simple files which can be included. 3. re-factor the code logic, improve the performance ...
Are there more guide from you that which Aspect that the code should be refactor? thanks for your advices!
Hi,
Note that we use bottom-posting on this list.
It's true that refactoring means to put long procedural code into functions.
About simple files, we avoid having too many small files (not good for performance). Have a look at libraries/TableSearch.class.php.
About improving the performance, IMO this is not related to code refactoring. A performance problem could be fixed without refactoring the code.
About more guides, did you have a look at the refactoring projects of last year? They are listed at [0].
See a refactoring example at [1].
[0] http://wiki.phpmyadmin.net/pma/GSoC_2012_Projects
[1] https://github.com/phpmyadmin/phpmyadmin/commit/2da7a2eba4c2c850c00645f77b81...
xmujay@gmail.com
From: Marc Delisle Date: 2013-04-01 19:12 To: phpmyadmin-devel Subject: Re: [Phpmyadmin-devel] gsoc: Refactoring: Server view Le 2013-03-31 05:10, xmujay@gmail.com a écrit :
Hi,
I am new here. I am quite interested on the topic of Refactoring: Server view.
from the code learning: 1. server view display code is listed on ROOT folder with prefix: server_ .php (most code is used to echo page elements) 2. the user request action is sent out using Ajax (js folder) 3. the backend logic is on library folder, some is on ROOT folder.
I want to know that: 1. what kind of improvement ? user experience and UI change or code refactor? 2. If it is user experience changes, are there some todo guides? 3. is there some user survey and user experience feed back to guide us improve the Server view ?
Hi, refactoring's goal is only to improve code, so no user experience nor UI change should be done.
See [0].
Note that we use bottom-posting on this list.
It's true that refactoring means to put long procedural code into functions.
Hi Marc, Thanks for your guide in last mail. In this week I have fininshed two things that let me get familiar with phpmyadmin and gsoc: Refactoring: Server view 1. Finished a lot of some Chinese tranlsations. 2. send a pull request on my Github about server view code refactor. https://github.com/phpmyadmin/phpmyadmin/pull/228
about the patch, I make the following changes for the refactoring: server view. render the HTML element at once fix HTML and PHP mixture fix code indention enhance the code Readability
Can you help me have a reivew? thanks
xmujay
From: Marc Delisle Date: 2013-04-01 23:56 To: phpmyadmin-devel Subject: Re: [Phpmyadmin-devel] gsoc: Refactoring: Server view Le 2013-04-01 11:26, xmujay@gmail.com a écrit :
Thanks Marc.
I make a simple compare with the db view which are with db_ prefix php file. I found that the render process is full of long code, so at least three things for code improvements: 1. split them to functions which can be re-used. 2. split them to simple files which can be included. 3. re-factor the code logic, improve the performance ...
Are there more guide from you that which Aspect that the code should be refactor? thanks for your advices!
Hi,
Note that we use bottom-posting on this list.
It's true that refactoring means to put long procedural code into functions.
About simple files, we avoid having too many small files (not good for performance). Have a look at libraries/TableSearch.class.php.
About improving the performance, IMO this is not related to code refactoring. A performance problem could be fixed without refactoring the code.
About more guides, did you have a look at the refactoring projects of last year? They are listed at [0].
See a refactoring example at [1].
[0] http://wiki.phpmyadmin.net/pma/GSoC_2012_Projects
[1] https://github.com/phpmyadmin/phpmyadmin/commit/2da7a2eba4c2c850c00645f77b81...
xmujay@gmail.com
From: Marc Delisle Date: 2013-04-01 19:12 To: phpmyadmin-devel Subject: Re: [Phpmyadmin-devel] gsoc: Refactoring: Server view Le 2013-03-31 05:10, xmujay@gmail.com a écrit :
Hi,
I am new here. I am quite interested on the topic of Refactoring: Server view.
from the code learning: 1. server view display code is listed on ROOT folder with prefix: server_ .php (most code is used to echo page elements) 2. the user request action is sent out using Ajax (js folder) 3. the backend logic is on library folder, some is on ROOT folder.
I want to know that: 1. what kind of improvement ? user experience and UI change or code refactor? 2. If it is user experience changes, are there some todo guides? 3. is there some user survey and user experience feed back to guide us improve the Server view ?
Hi, refactoring's goal is only to improve code, so no user experience nor UI change should be done.
See [0].
-
xmujay＠gmail.com