[Phpmyadmin-devel] pretty code, buggy code?

[Ignacio Vazquez-Abrams]

On Tue, 31 Jul 2001, Benjamin Gandon wrote:

> >   [snip]
> >   cols="<?php echo $cfgTextareaCols; ?>"><?php if
> > (!empty($special_chars)) echo $special_chars . "\n"; ?>
> > </textarea>
>
> I think your code still inserts a line feed at the end of
> the textarea. Correct code would be even less pretty:
>
> <textarea name="fields[<?php echo urlencode($field); ?>]"
>   rows="<?php echo $cfgTextareaRows; ?>"
>   cols="<?php echo $cfgTextareaCols; ?>"><?php if
> (!empty($special_chars)) echo $special_chars . "\n";
> ?></textarea>

No, because a single newline after the closing tag is silently ignored. I
propose the following:

<textarea name="fields[<?php echo urlencode($field); ?>]"
  rows="<?php echo $cfgTextareaRows; ?>"
  cols="<?php echo $cfgTextareaCols; ?>"
><?php if
(!empty($special_chars)) echo $special_chars . "\n"; ?>
</textarea>

-- 
Ignacio Vazquez-Abrams  <ignacio at openservices.net>