[Phpmyadmin-devel] Re: [PATCH] Fix incorrect row count in db_details.php

[Joshua Nye]

This removes from the total sum of rows the incorrect row counts from any tables that aren't ISAM/MyISAM/Heap.

-Josh

[root at lars htdocs]# diff -u phpMyAdmin/db_details.php phpMyAdmin-new/db_details.php  
--- phpMyAdmin/db_details.php   Wed Feb 20 16:40:22 2002
+++ phpMyAdmin-new/db_details.php       Thu Feb 21 08:09:55 2002
@@ -257,11 +257,11 @@
                     } else {
                         list($formated_size, $unit) =  PMA_formatByteDown($tblsize, 3, 0);
                     }
+                    $sum_entries                        += $sts_data['Rows'];
                 } else if ($cfgShowStats) {
                     $formated_size                  = ' - ';
                     $unit                           = '';
                 }
-                $sum_entries                        += $sts_data['Rows'];
             }
             // MyISAM MERGE Table
             else if ($cfgShowStats && $mergetable == TRUE) {
  ----- Original Message ----- 
  From: Joshua Nye 
  To: phpmyadmin-devel at lists.sourceforge.net 
  Sent: Wednesday, February 20, 2002 4:40 PM
  Subject: [PATCH] Fix incorrect row count in db_details.php


  I noticed that my row count displayed was incorrect for InnoDB tables as opposed to a SELECT COUNT(*).

  --Josh

  --- ../phpMyAdmin/db_details.php        Tue Feb 19 18:35:40 2002
  +++ db_details.php      Wed Feb 20 16:37:13 2002
  @@ -278,8 +278,10 @@
               echo "\n" . '        ';
               if ($mergetable == TRUE) {
                   echo '<i>' . number_format($sts_data['Rows'], 0, $number_decimal_separator, $number_thousands_separator) . '</i>' .
   "\n";
  -            } else {
  +            } elseif($nonisam == FALSE) {
                   echo number_format($sts_data['Rows'], 0, $number_decimal_separator, $number_thousands_separator) . "\n";
  +            } else {
  +                echo "-";
               }
               ?>
       </td>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20020221/46bac17d/attachment.html>