[Phpmyadmin-devel] Re: Kanji encoding featured (for only japanese)

[luc]

Hi Lo$B}D(B,

Lo$B}D(B wrote:
> I'm currently working on your patch: I'm aplying our coding standards to it.
> Could you please complete the attached library (see the "?" inside).

It's your beautiful aplying :-)

> Just two notes :
> - could you please add an e-mail addess near the author name?

I added my working e-mail address.

> - at the beginning of "PMA_kanji_str_conv" you put a "global" statement
>   for "$internal_enc" but this variable isn't used inside the function!

Yes, you are correct.
No need variable $internal_enc in this function.
Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kanji-encoding.lib.tgz
Type: application/x-unknown-content-type-winzip
Size: 1500 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20020224/965b04b0/attachment.bin>