[Phpmyadmin-devel] minor (uncritical) Bug? in recent versions!?

[Marc Delisle]

Christoph,

Please join the discussion in this pending patch:
https://sourceforge.net/tracker/index.php?func=detail&aid=495360&group_id=23067&atid=377410

Marc

Christoph Ertelt a écrit :

> Hi there developers
>
> I just discovered a more or less disturbing behavior of the language-select
> functionality.
>
> The problem is, I used a GET-variable named 'lang' in another PHP-based
> system in another directory (not a subdirectory of phpMyAdmin) on the same
> server.
> But due to the register-globals order the cookie value overwrote the
> get-paramter - so my lang-value was lost and it sucked to delete cookies
> everytime I accessed phpMyAdmin and missed the 'Refuse'-button ;)
>
> Problem seems to me to be (what english :) ), the call to setcookie (called
> in main.php as of 2.2.4-cvs 2002-01-07). It is called without a path
> argument, resulting a fallback to '/'.
> So IMHO it should be:
> setcookie('lang', $lang, time() + 60*60*24*30, substr($SCRIPT_NAME, 0,
> strrpos($SCRIPT_NAME, '/')));
>
> I would appreciate if you could approve this as a positive/useful
> contribution. :)
>
> regards
>
>    Christoph Ertelt
>
>