[Phpmyadmin-devel] Charsets patch

[Robin Johnson]

On Fri, 14 Jun 2002, Michal Cihar wrote:
> as my patch was today commited into cvs here are few important notes about it:
>
> - ANY mysql function that takes or returns string must be replaced by
> PMA_mysql* function. To do this automatically there is available shell
> script http://cihar.liten.cz/PMA-patch/01-mysql-wrappers/PMA-cvt
Ok.

> - ANY link (or form) should contain convcharset variable to keep this
> value while user uses these links
>
> I think that second thing would cause less problems if the part of
> links/hidden inputs that is used everywhere (probaly: lang, server and
> convcharset) would be generated just once in common.lib.php3 and not in
> reaaly plenty places all over the code. What do you think about it?
Yes, that would definetly go a long way to improving the consistancy of
forms and the code. I'd be all for it. This would also make it really easy
to add more hidden inputs later on, without having to re-do every file out
there.

echo "<form ...>";
echo PMA_FormVariables();
echo "... rest of form ...";
echo "</form>


-- 
Robin Hugh Johnson
E-Mail     : robbat2 at orbis-terrarum.net
Home Page  : http://www.orbis-terrarum.net/?l=people.robbat2
ICQ#       : 30269588 or 41961639