[Phpmyadmin-devel] Re: japanese-sjis SQL-parser error

[luc]

Hi Robin, Marc and list.

Marc Delisle wrote:
> Robin Johnson wrote:
>    :
>> Hi Luc and list.
>> Sorry about the delay, I've been really busy with university, exams and
>> work.
>>  :
>> Solution:
>> Replace ALL string functions in the code (strlen, substr, strpos etc.)
>> with a variable $GLOBALS['PMA_MB_functionname'] that is then called.
>> Additionally to this, we have a little bit of code that puts the correct
>> function name in those variables, depending on the availability (PHP
>> version is important here) and the need for multibyte characaters. Eg
>> mb_strlen or strlen would go into $GLOBALS['PMA_MB_strlen'] which could
>> then be used in the code directly, and handle everything properly.
>>
>> Any comments/suggetions/flames on this?
> 
> Looks ok to me, but looks like a lot of work, unless we can automate the
> source code changes.

If it is then looks a happy for me.