[Phpmyadmin-devel] BugFix question - Bug #641765

[Robin Johnson]

Yo,

I'm busy fixing bug #641765
And i've come across a strange bit in sql.php3 @ line 88
$parsed_sql = PMA_SQP_parse((get_magic_quotes_gpc() ?
stripslashes($sql_query) : $sql_query)); //86
$analyzed_sql = PMA_SQP_analyze($parsed_sql); //87
$sql_query = PMA_SQP_formatHtml($parsed_sql, 'query_only'); //88

These lines are from:
"Committed Marc's patches to the SQL parser and pretty printer from bugs
#605030 and #631421"

I'm trying to look for the reasoning behind line 88.
It is, for all-practical purposes, useless, since it just puts the same
query back into the $sql_query variable. It is also part of the problem
with #641765, since the SQL parser was giving an empty $parsed_sql
return value in specific cases.

I'm commenting it out for now, since that seems to have no ill side
effects. Any objections can get it put back in.

-- 
Robin Hugh Johnson
E-Mail     : robbat2 at orbis-terrarum.net
Home Page  : http://www.orbis-terrarum.net/?l=people.robbat2
ICQ#       : 30269588 or 41961639
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20030112/04acb3e6/attachment.sig>